Re: [PATCH] drm/msm/dp: remove most of usbpd-related remains

[Dmitry Baryshkov <dmitry.baryshkov@linaro.org>]

On Sun, 16 May 2021 at 08:41, Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Sat 15 May 14:56 CDT 2021, Dmitry Baryshkov wrote:
>
> > Remove most of remains of downstream usbpd code. Mainline kernel uses
> > different approach for managing Type-C / USB-PD, so this remains unused.
> > Do not touch usbpd callbacks for now, since they look usefull enough as
> > an example of how to handle connect/disconnect (to be rewritten into .
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > ---
> >  drivers/gpu/drm/msm/Makefile        |  1 -
> >  drivers/gpu/drm/msm/dp/dp_ctrl.c    |  4 +-
> >  drivers/gpu/drm/msm/dp/dp_ctrl.h    |  3 +-
> >  drivers/gpu/drm/msm/dp/dp_debug.c   |  6 +--
> >  drivers/gpu/drm/msm/dp/dp_debug.h   |  4 +-
> >  drivers/gpu/drm/msm/dp/dp_display.c | 36 ++-------------
> >  drivers/gpu/drm/msm/dp/dp_hpd.c     | 69 -----------------------------
> >  drivers/gpu/drm/msm/dp/dp_hpd.h     | 51 ---------------------
> >  drivers/gpu/drm/msm/dp/dp_power.c   |  2 +-
> >  drivers/gpu/drm/msm/dp/dp_power.h   |  3 +-
> >  10 files changed, 11 insertions(+), 168 deletions(-)
> >  delete mode 100644 drivers/gpu/drm/msm/dp/dp_hpd.c
> >
> [..]
> > diff --git a/drivers/gpu/drm/msm/dp/dp_hpd.c b/drivers/gpu/drm/msm/dp/dp_hpd.c
>
> It seems to me that this would be a reasonable place to plug in the
> typec_mux stuff. And as we're starting that exercise we should perhaps
> hold off on applying until we've figured out how that would look?

I'm fine with holding this for a while. Note, that actual code
handling the connection/disconnection is left in place. I've just
dropped unused data structures and related code.
In fact this started as I started looking for the place to put
typec-mux code and whether fields from dp_usbpd struct are used or not
(they are not).



-- 
With best wishes
Dmitry