From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Georgi Djakov <djakov@kernel.org>,
AngeloGioacchino Del Regno <kholk11@gmail.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"open list:DRM DRIVER FOR MSM ADRENO GPU"
<linux-arm-msm@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 3/3] arm64: dts: qcom: sdm630: Add missing a2noc qos clocks
Date: Mon, 23 Aug 2021 19:51:32 +0300 [thread overview]
Message-ID: <CAA8EJpqPMMvtDL5NqUJTDfVEAqX9VD9Y_TWmXxh8DpS8hwDuJg@mail.gmail.com> (raw)
In-Reply-To: <20210823095603.5538-4-shawn.guo@linaro.org>
On Mon, 23 Aug 2021 at 12:56, Shawn Guo <shawn.guo@linaro.org> wrote:
>
> It adds the missing a2noc clocks required for QoS registers programming
> per downstream kernel[1].
>
> [1] https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/sdm660-bus.dtsi?h=LA.UM.8.2.r1-04800-sdm660.0#n43
>
> Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sdm630.dtsi | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index 9153e6616ba4..b3a7f3bf1560 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -652,11 +652,22 @@
>
> a2noc: interconnect@1704000 {
> compatible = "qcom,sdm660-a2noc";
> - reg = <0x01704000 0xc100>;
> + reg = <0x01704000 0x1c000>;
Shawn, as you are at it, do we want to keep these nocs shifted
compared to the downstream dtsi (so that the offset of QoS registers
is 0) or we'd better introduce QoS register offset and move noc start
address to the same address as in downstream?
> #interconnect-cells = <1>;
> - clock-names = "bus", "bus_a";
> + clock-names = "bus",
> + "bus_a",
> + "ipa",
> + "ufs_axi",
> + "aggre2_ufs_axi",
> + "aggre2_usb3_axi",
> + "cfg_noc_usb2_axi";
> clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>,
> - <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>;
> + <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>,
> + <&rpmcc RPM_SMD_IPA_CLK>,
> + <&gcc GCC_UFS_AXI_CLK>,
> + <&gcc GCC_AGGRE2_UFS_AXI_CLK>,
> + <&gcc GCC_AGGRE2_USB3_AXI_CLK>,
> + <&gcc GCC_CFG_NOC_USB2_AXI_CLK>;
> };
>
> mnoc: interconnect@1745000 {
> --
> 2.17.1
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2021-08-23 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 9:56 [PATCH 0/3] Add missing A2NoC QoS clocks for SDM660 interconnect driver Shawn Guo
2021-08-23 9:56 ` [PATCH 1/3] dt-bindings: interconnect: sdm660: Add missing a2noc qos clocks Shawn Guo
2021-08-23 13:30 ` Rob Herring
2021-08-23 9:56 ` [PATCH 2/3] interconnect: qcom: " Shawn Guo
2021-08-23 15:57 ` Bjorn Andersson
2021-08-23 9:56 ` [PATCH 3/3] arm64: dts: qcom: sdm630: " Shawn Guo
2021-08-23 16:51 ` Dmitry Baryshkov [this message]
2021-08-24 1:17 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8EJpqPMMvtDL5NqUJTDfVEAqX9VD9Y_TWmXxh8DpS8hwDuJg@mail.gmail.com \
--to=dmitry.baryshkov@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=kholk11@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).