From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Taniya Das <tdas@codeaurora.org>,
Jonathan Marek <jonathan@marek.ca>,
Michael Turquette <mturquette@baylibre.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
linux-clk <linux-clk@vger.kernel.org>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
Mark Brown <broonie@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH v2 3/7] PM: domains: Add support for runtime PM
Date: Fri, 9 Jul 2021 14:39:37 +0300 [thread overview]
Message-ID: <CAA8EJpqykAyBKBADuGUQeZjG5-NPC6HgieNQLtWeA+McG_BMqw@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFoNPkFqGMvR=JGXNVXp-UfWLUqReZ0DGP8+0PBh+7dCRg@mail.gmail.com>
Hi,
On Fri, 9 Jul 2021 at 11:25, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> On Fri, 9 Jul 2021 at 06:32, Dmitry Baryshkov
> <dmitry.baryshkov@linaro.org> wrote:
> >
> > Registers for some genpds can be located in the SoC area, powered up by
> > another power domain. To enabled access to those registers, respective
> > domain should be turned on.
> >
> > This patch adds basic infrastructure to the genpd code to allow
> > implementing drivers for such genpd. PM domain can provide the parent
> > device through the genpd->dev.parent pointer. If its provided at the
> > pm_genpd_init() call time and if it is pm-enabled, genpd power_on and
> > power_off operations will call pm_runtime_get_sync() before powering up
> > the domain and pm_runtime_put_sync() after powering it down.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Hi Dmitry,
>
> Using runtime PM for the genpd provider device, is not the correct
> approach. If the provider domain needs another domain to be powered on
> to work correctly, that per definition means that it has a parent
> domain.
>
> I suggest you try to build the correct PM domain topology, via using
> pm_genpd_add_subdomain() or of_genpd_add_subdomain(), then genpd will
> manages the power on/off for parent/child domain internally.
Indeed, this patch seems redundant now, with the
pm_genpd_add_subdomain call in place.
Would you like me to resend a v3 just dropping this patch?
>
> Kind regards
> Uffe
>
> > ---
> > drivers/base/power/domain.c | 33 +++++++++++++++++++++++++++++++++
> > include/linux/pm_domain.h | 6 ++++++
> > 2 files changed, 39 insertions(+)
> >
> > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> > index e5d97174c254..7d49531c9731 100644
> > --- a/drivers/base/power/domain.c
> > +++ b/drivers/base/power/domain.c
> > @@ -482,6 +482,30 @@ void dev_pm_genpd_set_next_wakeup(struct device *dev, ktime_t next)
> > }
> > EXPORT_SYMBOL_GPL(dev_pm_genpd_set_next_wakeup);
> >
> > +static int _genpd_pm_runtime_get(struct generic_pm_domain *genpd)
> > +{
> > + int ret;
> > +
> > + if (!(genpd->flags & _GENPD_FLAG_RPM_ENABLED))
> > + return 0;
> > +
> > + ret = pm_runtime_get_sync(genpd->dev.parent);
> > + if (ret < 0) {
> > + pm_runtime_put_noidle(genpd->dev.parent);
> > + return ret;
> > + }
> > +
> > + return 0;
> > +}
> > +
> > +static void _genpd_pm_runtime_put(struct generic_pm_domain *genpd)
> > +{
> > + if (!(genpd->flags & _GENPD_FLAG_RPM_ENABLED))
> > + return;
> > +
> > + pm_runtime_put_sync(genpd->dev.parent);
> > +}
> > +
> > static int _genpd_power_on(struct generic_pm_domain *genpd, bool timed)
> > {
> > unsigned int state_idx = genpd->state_idx;
> > @@ -497,6 +521,10 @@ static int _genpd_power_on(struct generic_pm_domain *genpd, bool timed)
> > if (ret)
> > return ret;
> >
> > + ret = _genpd_pm_runtime_get(genpd);
> > + if (ret)
> > + return ret;
> > +
> > if (!genpd->power_on)
> > goto out;
> >
> > @@ -526,6 +554,7 @@ static int _genpd_power_on(struct generic_pm_domain *genpd, bool timed)
> > raw_notifier_call_chain(&genpd->power_notifiers, GENPD_NOTIFY_ON, NULL);
> > return 0;
> > err:
> > + _genpd_pm_runtime_put(genpd);
> > raw_notifier_call_chain(&genpd->power_notifiers, GENPD_NOTIFY_OFF,
> > NULL);
> > return ret;
> > @@ -572,6 +601,7 @@ static int _genpd_power_off(struct generic_pm_domain *genpd, bool timed)
> > genpd->name, "off", elapsed_ns);
> >
> > out:
> > + _genpd_pm_runtime_put(genpd);
> > raw_notifier_call_chain(&genpd->power_notifiers, GENPD_NOTIFY_OFF,
> > NULL);
> > return 0;
> > @@ -1986,6 +2016,9 @@ int pm_genpd_init(struct generic_pm_domain *genpd,
> > genpd->domain.ops.complete = genpd_complete;
> > genpd->domain.start = genpd_dev_pm_start;
> >
> > + if (genpd->dev.parent && pm_runtime_enabled(genpd->dev.parent))
> > + genpd->flags |= _GENPD_FLAG_RPM_ENABLED;
> > +
> > if (genpd->flags & GENPD_FLAG_PM_CLK) {
> > genpd->dev_ops.stop = pm_clk_suspend;
> > genpd->dev_ops.start = pm_clk_resume;
> > diff --git a/include/linux/pm_domain.h b/include/linux/pm_domain.h
> > index 21a0577305ef..e86cd7cfc9ec 100644
> > --- a/include/linux/pm_domain.h
> > +++ b/include/linux/pm_domain.h
> > @@ -60,6 +60,10 @@
> > * GENPD_FLAG_MIN_RESIDENCY: Enable the genpd governor to consider its
> > * components' next wakeup when determining the
> > * optimal idle state.
> > + *
> > + * _GENPD_FLAG_RPM_ENABLED: Use genpd's parent dev for runtime power
> > + * management. There is no need to set this flag,
> > + * it will be detected automatically.
> > */
> > #define GENPD_FLAG_PM_CLK (1U << 0)
> > #define GENPD_FLAG_IRQ_SAFE (1U << 1)
> > @@ -69,6 +73,8 @@
> > #define GENPD_FLAG_RPM_ALWAYS_ON (1U << 5)
> > #define GENPD_FLAG_MIN_RESIDENCY (1U << 6)
> >
> > +#define _GENPD_FLAG_RPM_ENABLED (1U << 31)
> > +
> > enum gpd_status {
> > GENPD_STATE_ON = 0, /* PM domain is on */
> > GENPD_STATE_OFF, /* PM domain is off */
> > --
> > 2.30.2
> >
--
With best wishes
Dmitry
next prev parent reply other threads:[~2021-07-09 11:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 4:31 [RESEND PATCH v2 0/7] clk: qcom: use power-domain for sm8250's clock controllers Dmitry Baryshkov
2021-07-09 4:31 ` [RESEND PATCH v2 1/7] dt-bindings: clock: qcom,dispcc-sm8x50: add mmcx power domain Dmitry Baryshkov
2021-07-09 4:31 ` [RESEND PATCH v2 2/7] dt-bindings: clock: qcom,videocc: " Dmitry Baryshkov
2021-07-09 4:31 ` [RESEND PATCH v2 3/7] PM: domains: Add support for runtime PM Dmitry Baryshkov
2021-07-09 8:24 ` Ulf Hansson
2021-07-09 11:39 ` Dmitry Baryshkov [this message]
2021-07-09 12:20 ` Ulf Hansson
2021-07-09 4:31 ` [RESEND PATCH v2 4/7] clk: qcom: gdsc: enable optional power domain support Dmitry Baryshkov
2021-07-09 9:32 ` Ulf Hansson
2021-07-09 11:46 ` Dmitry Baryshkov
2021-07-09 12:18 ` Ulf Hansson
2021-07-09 12:59 ` Dmitry Baryshkov
2021-07-09 13:14 ` Ulf Hansson
2021-07-09 13:22 ` Dmitry Baryshkov
2021-07-09 14:11 ` Ulf Hansson
2021-07-09 14:14 ` Dmitry Baryshkov
2021-07-09 14:04 ` Bjorn Andersson
2021-07-09 14:13 ` Ulf Hansson
2021-07-09 14:15 ` Dmitry Baryshkov
2021-07-09 4:31 ` [RESEND PATCH v2 5/7] arm64: dts: qcom: sm8250: remove mmcx regulator Dmitry Baryshkov
2021-07-09 4:31 ` [RESEND PATCH v2 6/7] clk: qcom: dispcc-sm8250: stop using " Dmitry Baryshkov
2021-07-09 4:31 ` [RESEND PATCH v2 7/7] clk: qcom: videocc-sm8250: " Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8EJpqykAyBKBADuGUQeZjG5-NPC6HgieNQLtWeA+McG_BMqw@mail.gmail.com \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathan@marek.ca \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).