From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Melody Olvera <quic_molvera@quicinc.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles
Date: Tue, 4 Oct 2022 01:14:00 +0300 [thread overview]
Message-ID: <CAA8EJprE-mOOH8VF3m8TRb+0q=3_8NpvzdEAugabDaDbq6FMVQ@mail.gmail.com> (raw)
In-Reply-To: <e9c44e3b-b29f-0f47-b822-da0f4f2264cc@quicinc.com>
On Tue, 4 Oct 2022 at 01:02, Melody Olvera <quic_molvera@quicinc.com> wrote:
>
>
> On 10/1/2022 4:25 AM, Krzysztof Kozlowski wrote:
> > On 01/10/2022 05:06, Melody Olvera wrote:
> >> Add compatibles for scm driver for QDU1000 and QRU1000 platforms.
> >>
> >> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> >> ---
> >> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> >> index c5b76c9f7ad0..b47a5dda3c3e 100644
> >> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> >> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml
> >> @@ -51,6 +51,8 @@ properties:
> >> - qcom,scm-sm8250
> >> - qcom,scm-sm8350
> >> - qcom,scm-sm8450
> >> + - qcom,scm-qdu1000
> >> + - qcom,scm-qru1000
I think after seeing all the patchsets it's time to ask the following
question. Do we really need a duplicate compatibility families:
qdu1000 vs qru1000? I'd suggest using a single set of compatibile
strings in most of the cases.
Settle down onto a single name (qdu,qru, qdru, whatever) and define
distinct compat strings only when there is an actual difference?
E.g .we don't have separate compatible strings for all the sda660,
apq8096, etc. unless this is required by the corresponding hardware
block not being compatible with corresponding sdm or msm counterpart.
> > Items should be ordered alphabetically.
> Will fix.
> >
> >> - qcom,scm-qcs404
> >> - const: qcom,scm
> > Patch is incomplete. Missing changes for allOf.
> Will add.
> >
> >>
> > Best regards,
> > Krzysztof
>
> Thanks,
>
> Melody
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-10-03 22:14 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 3:06 [PATCH 0/5] Add misc support for QDU1000/QRU1000 SoCs Melody Olvera
2022-10-01 3:06 ` [PATCH 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles Melody Olvera
2022-10-01 9:25 ` Krzysztof Kozlowski
2022-10-03 22:02 ` Melody Olvera
2022-10-03 22:14 ` Dmitry Baryshkov [this message]
2022-10-04 6:53 ` Krzysztof Kozlowski
2022-10-04 7:36 ` Dmitry Baryshkov
2022-10-04 15:52 ` Melody Olvera
2022-10-04 16:08 ` Melody Olvera
2022-10-04 21:05 ` Dmitry Baryshkov
2022-10-05 8:27 ` Krzysztof Kozlowski
2022-10-05 21:08 ` Trilok Soni
2022-10-01 3:06 ` [PATCH 2/5] dt-bindings: arm: qcom: Document QDU1000/QRU1000 SoCs and boards Melody Olvera
2022-10-01 9:26 ` Krzysztof Kozlowski
2022-10-04 15:16 ` Melody Olvera
2022-10-03 13:24 ` Rob Herring
2022-10-01 3:06 ` [PATCH 3/5] dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding Melody Olvera
2022-10-01 9:27 ` Krzysztof Kozlowski
2022-10-04 15:19 ` Melody Olvera
2022-10-01 3:06 ` [PATCH 4/5] soc: qcom: rpmhpd: Add QDU1000/QRU1000 power domains Melody Olvera
2022-10-01 7:50 ` Dmitry Baryshkov
2022-10-07 3:11 ` Bjorn Andersson
2022-10-12 20:32 ` Melody Olvera
2022-10-01 3:06 ` [PATCH 5/5] soc: qcom: socinfo: Add QDU1000/QRU1000 and variant IDs Melody Olvera
2022-10-01 9:28 ` Krzysztof Kozlowski
2022-10-01 9:34 ` [PATCH 0/5] Add misc support for QDU1000/QRU1000 SoCs Krzysztof Kozlowski
2022-10-04 15:27 ` Melody Olvera
2022-10-04 16:05 ` Melody Olvera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA8EJprE-mOOH8VF3m8TRb+0q=3_8NpvzdEAugabDaDbq6FMVQ@mail.gmail.com' \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=quic_molvera@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).