From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE38C2BBD0 for ; Tue, 8 Sep 2020 07:27:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E34E021D1A for ; Tue, 8 Sep 2020 07:27:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VYOBXZVm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729240AbgIHH1u (ORCPT ); Tue, 8 Sep 2020 03:27:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728654AbgIHH1s (ORCPT ); Tue, 8 Sep 2020 03:27:48 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00E8CC061573; Tue, 8 Sep 2020 00:27:47 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id j2so17945113wrx.7; Tue, 08 Sep 2020 00:27:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KOkWytvEQvcwRPaTbbeU+nJ2kZpJZSrQDxi081fe4SY=; b=VYOBXZVmm6Me9qi2cd3T0B/OHWxYd9Ambemd6O5THwOeqoYikp+sY/gKnIm7j4SjE5 nVFpiqk8CNOhnkwk3Z0bUqDXZyYc4d7SD2dAsnn9g4HyCLk+kXTqxBr8ly6SsM6zBBLO w/n7zcnOX9DC9ykasRnl+a2R/+yCpi25q5t9LQbCKdpGjiZzaA6DUGUWU/v+zKU41Xah 3v+dN1tAuBLvJ41uDHHJUI+9N+fy04RyuaKu0eeVLtMxE00q16uOds4Z2hnuFvdDat/d 4f9Dop7JC5IP6sZlOgVPP54Q+Epr3d78yyyDtWgtGftL/frpXXVK3527GizQK67Bel0P /fxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KOkWytvEQvcwRPaTbbeU+nJ2kZpJZSrQDxi081fe4SY=; b=oKBe8PwCAO7QIXyryiLbh3eMeJ0zIWc6Xb0nOTtjRkPoAp4EFJw88OpEkTItUIetAq eO39rZdvWerHtVMNiLM/mk6R3phH7DpTLusTUxtVAJBDpTnVGuBAf2rkMbRWsjwKMD1P awgNOkkokmJ+IZIMJ18N7m4l8R7SxgyH4dT5Sc/GMQ2zvzij9KOhCM40IlCYbizfy1x0 BlpP9zDOKXnw+FDI/gSqEdNktTJ9m9DUWCIBS03w/hgiEp/1zeate5CT5yBBKHMxEof9 oUVPgXJcyTDFoxN2Tl/kTqBlmn746+MW6KTeadYyHKs6w3ByS4uCQsWl1Cs+ijqtACUb zoKQ== X-Gm-Message-State: AOAM530NlEf3j64Y+hZWGXoOsR4I78ZFMpf/ztpQARz+RUAg+e6n4I8D jhmtQfDIcJgREEDAz/IeGPg/34wc6F9U2L2Xn0E= X-Google-Smtp-Source: ABdhPJzy45/B81xFTZ9qjxIyvVXE4rPehBDIzrqnJqdm5h0UGpJq905XCRaEh6NE80cNlJ8M295wsyMpnc8KnrLSWF8= X-Received: by 2002:a05:6000:36d:: with SMTP id f13mr24484491wrf.425.1599550066606; Tue, 08 Sep 2020 00:27:46 -0700 (PDT) MIME-Version: 1.0 References: <20200901152713.18629-1-krzk@kernel.org> In-Reply-To: <20200901152713.18629-1-krzk@kernel.org> From: Chunyan Zhang Date: Tue, 8 Sep 2020 15:27:10 +0800 Message-ID: Subject: Re: [PATCH 01/11] spi: sprd: Release DMA channel also on probe deferral To: Krzysztof Kozlowski Cc: Tudor Ambarus , Mark Brown , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Andy Gross , Bjorn Andersson , Orson Zhai , Baolin Wang , Maxime Coquelin , Alexandre Torgue , Masahisa Kojima , Jassi Brar , Laxman Dewangan , Thierry Reding , Jonathan Hunter , linux-spi@vger.kernel.org, Linux ARM , Linux Kernel Mailing List , linux-rpi-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org, stable Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 1 Sep 2020 at 23:27, Krzysztof Kozlowski wrote: > > If dma_request_chan() for TX channel fails with EPROBE_DEFER, the RX > channel would not be released and on next re-probe it would be requested > second time. > > Fixes: 386119bc7be9 ("spi: sprd: spi: sprd: Add DMA mode support") > Cc: > Signed-off-by: Krzysztof Kozlowski Acked-by: Chunyan Zhang Thanks, Chunyan > --- > drivers/spi/spi-sprd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c > index 6678f1cbc566..0443fec3a6ab 100644 > --- a/drivers/spi/spi-sprd.c > +++ b/drivers/spi/spi-sprd.c > @@ -563,11 +563,11 @@ static int sprd_spi_dma_request(struct sprd_spi *ss) > > ss->dma.dma_chan[SPRD_SPI_TX] = dma_request_chan(ss->dev, "tx_chn"); > if (IS_ERR_OR_NULL(ss->dma.dma_chan[SPRD_SPI_TX])) { > + dma_release_channel(ss->dma.dma_chan[SPRD_SPI_RX]); > if (PTR_ERR(ss->dma.dma_chan[SPRD_SPI_TX]) == -EPROBE_DEFER) > return PTR_ERR(ss->dma.dma_chan[SPRD_SPI_TX]); > > dev_err(ss->dev, "request TX DMA channel failed!\n"); > - dma_release_channel(ss->dma.dma_chan[SPRD_SPI_RX]); > return PTR_ERR(ss->dma.dma_chan[SPRD_SPI_TX]); > } > > -- > 2.17.1 >