From: Petr Vorel <email@example.com>
To: Bjorn Andersson <firstname.lastname@example.org>
Cc: Petr Vorel <email@example.com>,
Konrad Dybcio <firstname.lastname@example.org>,
Andy Gross <email@example.com>,
Dominik Kobinski <firstname.lastname@example.org>,
Jamie Douglass <email@example.com>
Subject: Re: [RFC PATCH 1/1] arm64: dts: qcom: msm8994-huawei-angler: Add regulators
Date: Fri, 7 Apr 2023 20:50:34 +0200 [thread overview]
Message-ID: <CAB1t1Cw3cB2fo9fCQam+aJQXM92uJzzb72Lng=D6Ey5HXi9YRQ@mail.gmail.com> (raw)
first, thanks a lot for your comments.
On Fri, 7 Apr 2023 at 18:54, Bjorn Andersson <firstname.lastname@example.org> wrote:
> On Fri, Feb 03, 2023 at 01:21:18PM +0100, Petr Vorel wrote:
> > From: Petr Vorel <email@example.com>
> Please add a commit message...
I thought the subject would be enough, as I added all regulators from
But as the approach is different, I'll be more descriptive when adding
just regulators which are actually needed.
> > Signed-off-by: Petr Vorel <firstname.lastname@example.org>
> > ---
> > Hi all,
> > please what is the mapping of qcom,init-current from downstream to
> > mainline? Or is it not used at all?
> It affects the mode the regulator operates in, you can find
> regulator-system-load in a few cases in other files as reference for
> when we force things into "high performance mode".
> There are some cases, such as eMMC/uSD where problems has been seen when
> the regulator is allowed to operate in low power mode...
+1, thank you.
> > Also, how can I verify these connections in downstream DTB?
> > vdd_l1-supply = <&pm8994_s1>;
> > vdd_l2_26_28-supply = <&pm8994_s3>;
> I don't think you can, without form of hardware documentation.
> I _think_ the RPM will take care of dependencies for you, and care
> should be taken before changing many of the regulators...
> So I'd suggest that you simply introduce the regulators that you need to
> touch from Linux today, rather than trying to add them all at once and
> then build from there.
Sure, makes sense.
prev parent reply other threads:[~2023-04-07 18:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 12:21 [RFC PATCH 1/1] arm64: dts: qcom: msm8994-huawei-angler: Add regulators Petr Vorel
2023-02-07 19:22 ` Petr Vorel
2023-04-07 16:57 ` Bjorn Andersson
2023-04-07 18:50 ` Petr Vorel [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).