From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13960C433E0 for ; Tue, 9 Feb 2021 02:00:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7C4564EBC for ; Tue, 9 Feb 2021 02:00:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230048AbhBIB7z (ORCPT ); Mon, 8 Feb 2021 20:59:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229999AbhBIB7y (ORCPT ); Mon, 8 Feb 2021 20:59:54 -0500 Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27353C06178B for ; Mon, 8 Feb 2021 17:59:14 -0800 (PST) Received: by mail-ot1-x336.google.com with SMTP id y11so16147298otq.1 for ; Mon, 08 Feb 2021 17:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CM5ltyHoHHbZYLOgDq3mYmPpHArKleBbSZcdJnFQ1co=; b=VNzBW35mfUL4JLrBGXZzO0LzVGcu60Sal3lpJpzpJsHT7NQTt3QyeaZL3JYuO8G4JX qUB+Xj2siMlhDDdYUZpxlvM817ahGUV5+gnijzPPclWDlP2+IuSKig7nDa/U//Qpdxqc VtgAw/WlsIqWEl/mQ7KYCu8MVWUxAkos+L18fAkOM7pLrFgMcDgg9z5Jkd87p2un+w21 +qfurkDbb2DgmyeJoQexxQED0XscuerxPvHCck+55ZIKXm6T+W1XNr/xH8StqL7mcd1Q U0Utr3SBo1edyzU8SLrnMwkmRooiqV+lfCN+N1u1ihrc56DjtaCqI+Jwc/2b0EoGN8OE 6usw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CM5ltyHoHHbZYLOgDq3mYmPpHArKleBbSZcdJnFQ1co=; b=GtnARlaoIlOnentkK51wLfGTVXVtzH9eYyztQqwGIjKpx6IEieFY5NDlBzCgcwmZ+w NaQZ+qwLIdIR1vZFnjNX6WHofBpNTAhWV17S3hEqp5jSP2+/cELojod5oEjjVacwPKsX /I7e8x0aKhndr6WYCAlcGxeCbG4EfpchpJwBxVl3RlNCtmAmPg7rZMRQbXdgqRtfZj8Q CL8vDpCVvAcFoKOPenZM6wR7RYCrcsHw/kp2aCbVKnyyH3osAngbWFQwjrNtpwwpLaUE B4Yg/kGj38v71CwMsySlIk7vIM23OS6c80bnxImZeviGNzWNAUrcapkURrPdR3zi+eH8 TdZw== X-Gm-Message-State: AOAM5318MHSVxxUO1SGNuOYYEGf4mdRgz2obxHAyyxrI0DEAdfNgYv1L AGIavlBFp8qxHUFgC2wwCnAT4j2YF1zSq7gBkAV2lQ== X-Google-Smtp-Source: ABdhPJy/fpshIH2JrEeihE3hResbnsn94vscsrPR1dHimzAhVPvv0cTpwI0VbfgKSuJE19snvxCF2QO6NsSZr7j82X8= X-Received: by 2002:a9d:5f0b:: with SMTP id f11mr13838524oti.263.1612835953572; Mon, 08 Feb 2021 17:59:13 -0800 (PST) MIME-Version: 1.0 References: <20210203113914.1072380-1-bryan.odonoghue@linaro.org> <20210203113914.1072380-2-bryan.odonoghue@linaro.org> <20210204233905.GA1334487@robh.at.kernel.org> In-Reply-To: From: "Bryan O'Donoghue" Date: Tue, 9 Feb 2021 01:59:02 +0000 Message-ID: Subject: Re: [PATCH 1/1] dt-bindings: media: venus: Add sm8250 dt schema To: Rob Herring Cc: Vikash Garodia , "Gross, Andy" , Dikshita Agarwal , Bjorn Andersson , linux-arm-msm , devicetree@vger.kernel.org, Stanimir Varbanov , Jonathan Marek Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 9 Feb 2021 at 01:39, Rob Herring wrote: > > On Thu, Feb 4, 2021 at 5:39 PM Rob Herring wrote: > > > > On Wed, 03 Feb 2021 11:39:14 +0000, Bryan O'Donoghue wrote: > > > Add a schema description for the venus video encoder/decoder on the sm8250. > > > > > > Signed-off-by: Bryan O'Donoghue > > > --- > > > .../bindings/media/qcom,sm8250-venus.yaml | 153 ++++++++++++++++++ > > > 1 file changed, 153 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > > > > > > > Applied, thanks! > > And now dropped. The example has lots of errors and I got tired of > fixing them and didn't know if the undocumented properties should be > removed or documented. Here's what I fixed so far: > > diff --git a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > index 1d4b1ab63297..fe66de5d91ea 100644 > --- a/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > +++ b/Documentation/devicetree/bindings/media/qcom,sm8250-venus.yaml > @@ -116,10 +116,13 @@ examples: > - | > #include > #include > + #include > + #include > + #include > > venus: video-codec@aa00000 { > compatible = "qcom,sm8250-venus"; > - reg = <0 0x0aa00000 0 0xff000>; > + reg = <0x0aa00000 0xff000>; > interrupts = ; > power-domains = <&videocc MVS0C_GDSC>, > <&videocc MVS0_GDSC>, > @@ -129,12 +132,12 @@ examples: > > clocks = <&gcc GCC_VIDEO_AXI0_CLK>, > <&videocc VIDEO_CC_MVS0C_CLK>, > - <&videocc VIDEO_CC_MVS0_CLK>; > + <&videocc VIDEO_CC_MVS0_CLK_SRC>; > clock-names = "iface", "core", "vcodec0_core"; > > interconnects = <&gem_noc MASTER_AMPSS_M0 &config_noc > SLAVE_VENUS_CFG>, > <&mmss_noc MASTER_VIDEO_P0 &mc_virt SLAVE_EBI_CH0>; > - interconnect-names = "cpu-cfg", "video-mem"; > + interconnect-names = "video-mem", "cpu-cfg"; > > iommus = <&apps_smmu 0x2100 0x0400>; > memory-region = <&video_mem>; > diff --git a/arch/arm64/boot/dts/arm/foundation-v8.dtsi > b/arch/arm64/boot/dts/arm/foundation-v8.dtsi > index 05ae893d1b2e..312c076379e1 100644 > --- a/arch/arm64/boot/dts/arm/foundation-v8.dtsi > +++ b/arch/arm64/boot/dts/arm/foundation-v8.dtsi > @@ -36,6 +36,7 @@ cpu0: cpu@0 { > compatible = "arm,armv8"; > reg = <0x0 0x0>; > next-level-cache = <&L2_0>; > + next-level-cache {}; > }; > cpu1: cpu@1 { > device_type = "cpu"; Sorry about that Rob, I thought my build script ran the dt checker