From: Jassi Brar <jassisinghbrar@gmail.com>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Sivaprakash Murugesan <sivaprak@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Benjamin Li <benl@squareup.com>,
Devicetree List <devicetree@vger.kernel.org>,
linux-arm-msm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support
Date: Sun, 20 Jun 2021 23:27:49 -0500 [thread overview]
Message-ID: <CABb+yY3CA+gvRJi7nyA4wxwP3-XtbfDhq51eP8Q+vL7TbMncUQ@mail.gmail.com> (raw)
In-Reply-To: <20210523060009.GA29015@dragon>
On Sun, May 23, 2021 at 1:00 AM Shawn Guo <shawn.guo@linaro.org> wrote:
>
> On Mon, May 03, 2021 at 04:13:34PM +0800, Shawn Guo wrote:
> > MSM8939 has 3 APCS instances for Cluster0 (little cores), Cluster1 (big
> > cores) and CCI (Cache Coherent Interconnect). Although only APCS of
> > Cluster0 and Cluster1 have IPC bits, each of 3 APCS has A53PLL clock
> > control bits. That said, we need to register 3 'qcom-apcs-msm8916-clk'
> > devices to instantiate all 3 clocks. Let's use PLATFORM_DEVID_AUTO
> > rather than PLATFORM_DEVID_NONE for platform_device_register_data()
> > call. Otherwise, the second A53PLL clock registration will fail due
> > to duplicate device name.
> >
> > [ 0.519657] sysfs: cannot create duplicate filename '/bus/platform/devices/qcom-apcs-msm8916-clk'
> > ...
> > [ 0.661158] qcom_apcs_ipc b111000.mailbox: failed to register APCS clk
> >
> > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Hi Jassi,
>
> Any comment on this patch?
>
1) I was not on the CC list, so I don't have this patch in my mbox.
2) Shouldn't this patch be broken into a fix and an enablement patch?
cheers.
next prev parent reply other threads:[~2021-06-21 4:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 8:13 [PATCH v2 0/2] Add MSM8939 APCS support Shawn Guo
2021-05-03 8:13 ` [PATCH v2 1/2] dt-bindings: mailbox: qcom: Add MSM8939 APCS compatible Shawn Guo
2021-05-06 15:23 ` Rob Herring
2021-05-03 8:13 ` [PATCH v2 2/2] mailbox: qcom: Add MSM8939 APCS support Shawn Guo
2021-05-23 6:00 ` Shawn Guo
2021-06-21 4:27 ` Jassi Brar [this message]
2021-06-21 6:33 ` Shawn Guo
2021-06-21 14:49 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABb+yY3CA+gvRJi7nyA4wxwP3-XtbfDhq51eP8Q+vL7TbMncUQ@mail.gmail.com \
--to=jassisinghbrar@gmail.com \
--cc=benl@squareup.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=sivaprak@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).