From: Jun Nie <jun.nie@linaro.org>
To: Benjamin Li <benl@squareup.com>
Cc: Georgi Djakov <georgi.djakov@linaro.org>,
square <square@linaro.org>,
kernel@squareup.com, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Georgi Djakov <djakov@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] interconnect: qcom: msm8939: remove rpm-ids from non-RPM nodes
Date: Thu, 4 Feb 2021 10:56:51 +0800 [thread overview]
Message-ID: <CABymUCO22hzg-K+ws2ZfvsqAcuNq6iKvRv1dch5M4pPOcQZKpg@mail.gmail.com> (raw)
In-Reply-To: <20210203163407.9222-3-benl@squareup.com>
'Benjamin Li' via square <square@linaro.org> 于2021年2月4日周四 上午12:34写道：
>
> Changes corresponding to commit c497f9322af9 ("interconnect: qcom: msm8916:
> Remove rpm-ids from non-RPM nodes") to remove this log spam on 8939:
>
> [ 1.901376] qcom_icc_rpm_smd_send slv 24 error -6
> [ 2.005977] qcom_icc_rpm_smd_send mas 20 error -6
> [ 2.010250] qcom_icc_rpm_smd_send slv 20 error -6
> [ 2.014684] qcom_icc_rpm_smd_send slv 106 error -6
> [ 2.019338] qcom_icc_rpm_smd_send slv 107 error -6
> [ 2.024615] qcom_icc_rpm_smd_send slv 29 error -6
> [ 2.028782] qcom_icc_rpm_smd_send mas 3 error -6
> [ 2.034657] qcom_icc_rpm_smd_send mas 100 error -6
> (plus another slv 131 that's hidden by the mas 100 failure)
>
> Signed-off-by: Benjamin Li <benl@squareup.com>
> ---
Ben,
Suggest to add comments to address the issue you fixed as commit
c497f9322af does, at least a short version. So that people do not
have to look into c497f9322af again.
Regards,
Jun
prev parent reply other threads:[~2021-02-04 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 16:34 [PATCH 0/2] Clean up MSM8939 interconnect driver Benjamin Li
2021-02-03 16:34 ` [PATCH 1/2] interconnect: qcom: icc-rpm: record slave RPM id in error log Benjamin Li
2021-02-03 16:34 ` [PATCH 2/2] interconnect: qcom: msm8939: remove rpm-ids from non-RPM nodes Benjamin Li
2021-02-04 2:56 ` Jun Nie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABymUCO22hzg-K+ws2ZfvsqAcuNq6iKvRv1dch5M4pPOcQZKpg@mail.gmail.com \
--to=jun.nie@linaro.org \
--cc=agross@kernel.org \
--cc=benl@squareup.com \
--cc=bjorn.andersson@linaro.org \
--cc=djakov@kernel.org \
--cc=georgi.djakov@linaro.org \
--cc=kernel@squareup.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=square@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).