From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 689E0C433F5 for ; Tue, 28 Sep 2021 13:51:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B738611EF for ; Tue, 28 Sep 2021 13:51:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241110AbhI1Nwl (ORCPT ); Tue, 28 Sep 2021 09:52:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240979AbhI1Nwk (ORCPT ); Tue, 28 Sep 2021 09:52:40 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89578C061604 for ; Tue, 28 Sep 2021 06:51:00 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id u18so91355729lfd.12 for ; Tue, 28 Sep 2021 06:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hqwz9jzyEQV5H4SW8S/gf8kyYKDVCl9EoNAa0kvGs9E=; b=lK1N+HWcCfWtNCrGgY4s6GgX9CsGhnRcYX4lqPYKVXVMLm9dFqGOmTWH6W7yDgrYlP r5EfG2iKtNsCiPEpu2jIIZUO/prlSrOSngipvA1TaZXN//4VkeA+JwIztwUCHInTjF+X dIEeqXK9vl1zabQddSGCMK/1z7p7VHD0/EGwo/HlhXJ3zAduBt5JgEYfTeOMBww2Fp7C uuEQ+v8uMPilV3Gj8rG9xjCBY2Z3AgQB7zHz7LAOKEGK+E4GoP5y67eAshWxmcfY0b/C tbJ5BllnohxxoWYH9FNEsSkrxF7kZTx9LML4VnlI/nkZyyXKBdokKSpCUGceySjEP260 j7fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hqwz9jzyEQV5H4SW8S/gf8kyYKDVCl9EoNAa0kvGs9E=; b=k5mx7wSsl9RVCpBbiltRpeIWVGcAwNgAvTE+VQ6Y4FXASIGdSUU6Ez8g7XBy8W/dgB b2H9v/e5S7Ay+7YjFQg6xv5xDmQ9YD5buUgDwEd8SEac05dtIPMstE25MIbhZ8RxLu5v 9wvp/IeFQcpsyEFRHQ9+c7s7ucRBGufNSYeq8yvSGYfPq8+fu+2A9Q0ke0iI8nikNfA4 UIcMesNXWh+wCoSleKPKhI8dWB+L+TELQHQEkxfrnPF75znilREtsgETlWpYSB9etvxp D6eCNgh/3vjepD3kOaWUgC1LlCAIKKsPacOPu3RWB7Kb1kR90hGn9EOxz81b4S8OoSSW 0N1g== X-Gm-Message-State: AOAM530nggSQtemzoCBMQBtt2AeWC65kMt4x7DaKRN+OeLyU2Q9vbH0U zrXrYphNNWROs8QyItWVbsSjmILsOpnmIoYjDUb1FA== X-Google-Smtp-Source: ABdhPJzKB7hvIUZRQ/aoIoW5cqtS9HhlPZ5bpsUvwPy/3OPtxA+hpK098gljBYdBI6LlYdW5gw8hagp89uPCk1TRlmw= X-Received: by 2002:a05:651c:4ca:: with SMTP id e10mr43638lji.259.1632837047280; Tue, 28 Sep 2021 06:50:47 -0700 (PDT) MIME-Version: 1.0 References: <20210928013621.1245-1-caihuoqing@baidu.com> <20210928013621.1245-7-caihuoqing@baidu.com> In-Reply-To: <20210928013621.1245-7-caihuoqing@baidu.com> From: Linus Walleij Date: Tue, 28 Sep 2021 15:50:36 +0200 Message-ID: Subject: Re: [PATCH v2 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe() To: Cai Huoqing Cc: Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , Bjorn Andersson , Heiko Stuebner , Linux ARM , linux-iio , linux-kernel , "open list:ARM/Amlogic Meson..." , MSM , "open list:ARM/Rockchip SoC..." Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Sep 28, 2021 at 3:37 AM Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing (...) > - return -ENXIO; > + return -ENODEV; Why? I think it's the right change, but should be in the changelog. Yours, Linus Walleij