From: Linus Walleij <linus.walleij@linaro.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Julian Braha <julianbraha@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Martin Botka <martin.botka@somainline.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: qcom: fix GPIOLIB dependencies
Date: Fri, 23 Jul 2021 11:51:27 +0200 [thread overview]
Message-ID: <CACRpkdYw5WUbExhGArO=inGQV=4j4SmMhCPa7=qBSePkELB+wg@mail.gmail.com> (raw)
In-Reply-To: <20210723091400.1669716-1-arnd@kernel.org>
On Fri, Jul 23, 2021 at 11:14 AM Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Enabling the PINCTRL_SM8350 symbol without GPIOLIB or SCM causes a build
> failure:
>
> WARNING: unmet direct dependencies detected for PINCTRL_MSM
> Depends on [m]: PINCTRL [=y] && (ARCH_QCOM [=y] || COMPILE_TEST [=y]) && GPIOLIB [=y] && (QCOM_SCM [=m] || !QCOM_SCM [=m])
> Selected by [y]:
> - PINCTRL_SM8350 [=y] && PINCTRL [=y] && (ARCH_QCOM [=y] || COMPILE_TEST [=y]) && GPIOLIB [=y] && OF [=y]
> aarch64-linux-ld: drivers/pinctrl/qcom/pinctrl-msm.o: in function `msm_gpio_irq_set_type':
> pinctrl-msm.c:(.text.msm_gpio_irq_set_type+0x1c8): undefined reference to `qcom_scm_io_readl'
>
> The main problem here is the 'select PINCTRL_MSM', which needs to be a
> 'depends on' as it is for all the other front-ends. As the GPIOLIB
> dependency is now implied by that, symbol, remove the duplicate
> dependencies in the process.
>
> Fixes: d5d348a3271f ("pinctrl: qcom: Add SM8350 pinctrl driver")
> Fixes: 376f9e34c10f ("drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Nice catch!
Applied for fixes.
Yours,
Linus Walleij
prev parent reply other threads:[~2021-07-23 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 9:13 [PATCH] pinctrl: qcom: fix GPIOLIB dependencies Arnd Bergmann
2021-07-23 9:51 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYw5WUbExhGArO=inGQV=4j4SmMhCPa7=qBSePkELB+wg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=agross@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=john.stultz@linaro.org \
--cc=julianbraha@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.botka@somainline.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).