archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <>
To: Caleb Connolly <>
Cc: Thierry Reding <>,
	Sam Ravnborg <>, David Airlie <>,
	Daniel Vetter <>,
	<>, Hans de Goede <>,
	Andy Shevchenko <>," 
	<~postmarketos/>,, MSM <>,
	"open list:DRM PANEL DRIVERS" <>,
	linux-kernel <>
Subject: Re: [PATCH 2/4] drm: panel: sofef00: remove reset GPIO handling
Date: Thu, 24 Jun 2021 17:32:04 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sun, May 2, 2021 at 3:43 AM Caleb Connolly <> wrote:

> Resetting the panel on fajita causes it to never come back, we aren't
> quite sure why this is so for now lets remove reset handling as it is
> effectively broken. It is also not needed on enchilada.

Where are the device trees for these platforms?

Are there schematics so we/someone with access to the schematics
can figure it out?

It's not something trivial like forgotten to put GPIO_ACTIVE_LOW
on the gpio phandle?

> -static void sofef00_panel_reset(struct sofef00_panel *ctx)
> -{
> -       gpiod_set_value_cansleep(ctx->reset_gpio, 0);
> -       usleep_range(5000, 6000);
> -       gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> -       usleep_range(2000, 3000);
> -       gpiod_set_value_cansleep(ctx->reset_gpio, 0);
> -       usleep_range(12000, 13000);
> -}

This code looks a bit weird to begin with, I don't see the point
with the first setting the gpiod low, either it was low already or
high already neither matters, driving it asserted will assert it
either way.

No big deal though.

> -       ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);

As Bjorn says: just use *_optional and comment the line out in the
device tree if there is a problem.

Linus Walleij

      parent reply	other threads:[~2021-06-24 15:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-02  1:42 OnePlus 6 fixups Caleb Connolly
2021-05-02  1:42 ` [PATCH 1/4] arm64: dts: qcom: sdm845-oneplus-common: remove panel reset gpio Caleb Connolly
2021-05-02  1:42 ` [PATCH 2/4] drm: panel: sofef00: remove reset GPIO handling Caleb Connolly
2021-05-25 15:36   ` Bjorn Andersson
2021-06-24 15:32   ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --cc=~postmarketos/ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).