From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F877C49EA7 for ; Thu, 24 Jun 2021 15:32:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C458613EC for ; Thu, 24 Jun 2021 15:32:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231817AbhFXPeh (ORCPT ); Thu, 24 Jun 2021 11:34:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230008AbhFXPeg (ORCPT ); Thu, 24 Jun 2021 11:34:36 -0400 Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 764CFC061574 for ; Thu, 24 Jun 2021 08:32:17 -0700 (PDT) Received: by mail-lf1-x12e.google.com with SMTP id x24so10927154lfr.10 for ; Thu, 24 Jun 2021 08:32:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=04JLKQO/fFyUkOGcPqBL7gujdp8kkZAbX0MtPTll5vk=; b=JArqNkSlZaSXwPoifYE4gZ1v0dG7zlhwLa8GNdYgG+9JRwcLa1pU5tNBwDuwJmzQWt D9u5zRUOEIPiVOX640qgnHBqK+HGjwyX44j3FIceBSs4RuYZ+JIwjdhlyxBfTbqFXjmX mGDOmzAQUXO8Q4IPRfejKbSV4RYj3lZkLY9nxn9BdwYwAC5Y4A/XPZGL/Gt4vaOBsBtq EBQbsz76PUgzhqjQ2VcfwHHjcaS4nv3kN8OQDUcdbVW4ItIjpAuqkLuDOgu4IRp7R9wY dP63H3Y4ug8hi+z/mP0t/OzKfXenKK0Kqx00dJkzTgY7KylvnMTKTUh00JQOV6KzRyz+ TFZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=04JLKQO/fFyUkOGcPqBL7gujdp8kkZAbX0MtPTll5vk=; b=mttKUYelPmu+WnswOkjSDK6fb0+vchKbeIoaycLe0mqLww9/XOF5K1uhUa2SO0jEHk PTRmCmDQEvU+vMiINRx8Zd72UcZn/DO9nVT8fcZV23RC6lUUaaBvRorpyaol/zIWApfe FSqIQSCyTtoLJm6T6C6VcB/JFQMXpn69enTHt8bK/pKzDLTuoN+P0g3pvRJX66GfhK/U 3FgWa9467B/rDLL02ht8wg9RT75rUP2fjIjj5sYREk90Q1YaeCZ9cw9Y3AUGXE4THGkL 4jZAuwHRVYHF1MnjTh1I8ly7lL4C/j1W5uz0ch7WaIWTOZuXBo10SiUz0XON94EW7SmF xQ5g== X-Gm-Message-State: AOAM533maoddFjgNpwtc91E9Qo0OTZYb7li93pZDzz+its3Q1tnjHh+T NhoIbWiCq6hkAWq92bDpVyLkPAcPX4BvEzQWDWYQRQ== X-Google-Smtp-Source: ABdhPJxs7rnOO/BgTWo9qd7jVgTTntGtpEBOuLOjuElmlZzwGEGI4e1z1SM7AgDZqF2e7uG2v5GyqhsTn1JVO9E0HUg= X-Received: by 2002:a19:6e44:: with SMTP id q4mr4362200lfk.586.1624548735768; Thu, 24 Jun 2021 08:32:15 -0700 (PDT) MIME-Version: 1.0 References: <20210502014146.85642-1-caleb@connolly.tech> <20210502014146.85642-3-caleb@connolly.tech> In-Reply-To: <20210502014146.85642-3-caleb@connolly.tech> From: Linus Walleij Date: Thu, 24 Jun 2021 17:32:04 +0200 Message-ID: Subject: Re: [PATCH 2/4] drm: panel: sofef00: remove reset GPIO handling To: Caleb Connolly Cc: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS , Hans de Goede , Andy Shevchenko ," <~postmarketos/upstreaming@lists.sr.ht>, phone-devel@vger.kernel.org, MSM , "open list:DRM PANEL DRIVERS" , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun, May 2, 2021 at 3:43 AM Caleb Connolly wrote: > Resetting the panel on fajita causes it to never come back, we aren't > quite sure why this is so for now lets remove reset handling as it is > effectively broken. It is also not needed on enchilada. Where are the device trees for these platforms? Are there schematics so we/someone with access to the schematics can figure it out? It's not something trivial like forgotten to put GPIO_ACTIVE_LOW on the gpio phandle? > -static void sofef00_panel_reset(struct sofef00_panel *ctx) > -{ > - gpiod_set_value_cansleep(ctx->reset_gpio, 0); > - usleep_range(5000, 6000); > - gpiod_set_value_cansleep(ctx->reset_gpio, 1); > - usleep_range(2000, 3000); > - gpiod_set_value_cansleep(ctx->reset_gpio, 0); > - usleep_range(12000, 13000); > -} This code looks a bit weird to begin with, I don't see the point with the first setting the gpiod low, either it was low already or high already neither matters, driving it asserted will assert it either way. No big deal though. > - ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); As Bjorn says: just use *_optional and comment the line out in the device tree if there is a problem. Yours, Linus Walleij