* [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A
@ 2021-04-01 12:35 satya priya
2021-04-01 12:35 ` [PATCH V2 1/3] pinctrl: qcom: spmi-gpio: Add support for four variants satya priya
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: satya priya @ 2021-04-01 12:35 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Andy Gross, Bjorn Andersson
Cc: kgunda, linux-gpio, linux-kernel, devicetree, linux-arm-msm, satya priya
satya priya (3):
pinctrl: qcom: spmi-gpio: Add support for four variants
dt-bindings: pinctrl: qcom-pmic-gpio: Update the binding to add four
new variants
dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings
to YAML
.../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 272 --------------------
.../bindings/pinctrl/qcom,pmic-gpio.yaml | 281 +++++++++++++++++++++
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 4 +
3 files changed, 285 insertions(+), 272 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH V2 1/3] pinctrl: qcom: spmi-gpio: Add support for four variants 2021-04-01 12:35 [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A satya priya @ 2021-04-01 12:35 ` satya priya 2021-04-01 15:25 ` Bjorn Andersson 2021-04-01 12:35 ` [PATCH V2 2/3] dt-bindings: pinctrl: qcom-pmic-gpio: Update the binding to add four new variants satya priya ` (2 subsequent siblings) 3 siblings, 1 reply; 10+ messages in thread From: satya priya @ 2021-04-01 12:35 UTC (permalink / raw) To: Linus Walleij, Rob Herring, Andy Gross, Bjorn Andersson Cc: kgunda, linux-gpio, linux-kernel, devicetree, linux-arm-msm, satya priya Add PM7325, PM8350c, PMK8350 and PMR735A compatibles for GPIO support. Signed-off-by: satya priya <skakit@codeaurora.org> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- Changes in V2: - No change. drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c index 9801c71..90f4f78 100644 --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c @@ -1131,6 +1131,10 @@ static const struct of_device_id pmic_gpio_of_match[] = { { .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 }, /* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */ { .compatible = "qcom,pmx55-gpio", .data = (void *) 11 }, + { .compatible = "qcom,pm7325-gpio", .data = (void *) 10 }, + { .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 }, + { .compatible = "qcom,pmk8350-gpio", .data = (void *) 4 }, + { .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 }, { }, }; -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH V2 1/3] pinctrl: qcom: spmi-gpio: Add support for four variants 2021-04-01 12:35 ` [PATCH V2 1/3] pinctrl: qcom: spmi-gpio: Add support for four variants satya priya @ 2021-04-01 15:25 ` Bjorn Andersson 0 siblings, 0 replies; 10+ messages in thread From: Bjorn Andersson @ 2021-04-01 15:25 UTC (permalink / raw) To: satya priya Cc: Linus Walleij, Rob Herring, Andy Gross, kgunda, linux-gpio, linux-kernel, devicetree, linux-arm-msm On Thu 01 Apr 07:35 CDT 2021, satya priya wrote: > Add PM7325, PM8350c, PMK8350 and PMR735A compatibles for GPIO > support. > > Signed-off-by: satya priya <skakit@codeaurora.org> > Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > Changes in V2: > - No change. > > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > index 9801c71..90f4f78 100644 > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > @@ -1131,6 +1131,10 @@ static const struct of_device_id pmic_gpio_of_match[] = { > { .compatible = "qcom,pm6150l-gpio", .data = (void *) 12 }, > /* pmx55 has 11 GPIOs with holes on 3, 7, 10, 11 */ > { .compatible = "qcom,pmx55-gpio", .data = (void *) 11 }, > + { .compatible = "qcom,pm7325-gpio", .data = (void *) 10 }, > + { .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 }, > + { .compatible = "qcom,pmk8350-gpio", .data = (void *) 4 }, Please try to keep the list sorted alphabetically, that way you'd see that linux-next already has pm8350c and pmk8350 defined - or at least Linus would notice when he tries to apply your patch. Regards, Bjorn > + { .compatible = "qcom,pmr735a-gpio", .data = (void *) 4 }, > { }, > }; > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V2 2/3] dt-bindings: pinctrl: qcom-pmic-gpio: Update the binding to add four new variants 2021-04-01 12:35 [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A satya priya 2021-04-01 12:35 ` [PATCH V2 1/3] pinctrl: qcom: spmi-gpio: Add support for four variants satya priya @ 2021-04-01 12:35 ` satya priya 2021-04-01 15:26 ` Bjorn Andersson 2021-04-01 12:35 ` [PATCH V2 3/3] dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings to YAML satya priya 2021-04-08 13:48 ` [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A Linus Walleij 3 siblings, 1 reply; 10+ messages in thread From: satya priya @ 2021-04-01 12:35 UTC (permalink / raw) To: Linus Walleij, Rob Herring, Andy Gross, Bjorn Andersson Cc: kgunda, linux-gpio, linux-kernel, devicetree, linux-arm-msm, satya priya Update the binding to add PM7325, PM8350C, PMK8350 and PMR735A GPIO support. Signed-off-by: satya priya <skakit@codeaurora.org> --- Changes in V2: - Placed this patch before conversion patch and updated commit text to be more clear. Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt index 7648ab0..da7c35e 100644 --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt @@ -30,6 +30,10 @@ PMIC's from Qualcomm. "qcom,pm6150-gpio" "qcom,pm6150l-gpio" "qcom,pmx55-gpio" + "qcom,pm7325-gpio" + "qcom,pm8350c-gpio" + "qcom,pmk8350-gpio" + "qcom,pmr735a-gpio" And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio" if the device is on an spmi bus or an ssbi bus respectively @@ -113,6 +117,10 @@ to specify in a pin configuration subnode: gpio1-gpio12 for pm6150l gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10 and gpio11) + gpio1-gpio10 for pm7325 + gpio1-gpio9 for pm8350c + gpio1-gpio4 for pmk8350 + gpio1-gpio4 for pmr735a - function: Usage: required -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH V2 2/3] dt-bindings: pinctrl: qcom-pmic-gpio: Update the binding to add four new variants 2021-04-01 12:35 ` [PATCH V2 2/3] dt-bindings: pinctrl: qcom-pmic-gpio: Update the binding to add four new variants satya priya @ 2021-04-01 15:26 ` Bjorn Andersson 0 siblings, 0 replies; 10+ messages in thread From: Bjorn Andersson @ 2021-04-01 15:26 UTC (permalink / raw) To: satya priya Cc: Linus Walleij, Rob Herring, Andy Gross, kgunda, linux-gpio, linux-kernel, devicetree, linux-arm-msm On Thu 01 Apr 07:35 CDT 2021, satya priya wrote: > Update the binding to add PM7325, PM8350C, PMK8350 and PMR735A GPIO support. > > Signed-off-by: satya priya <skakit@codeaurora.org> > --- > Changes in V2: > - Placed this patch before conversion patch and updated commit text > to be more clear. > > Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt > index 7648ab0..da7c35e 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt > @@ -30,6 +30,10 @@ PMIC's from Qualcomm. > "qcom,pm6150-gpio" > "qcom,pm6150l-gpio" > "qcom,pmx55-gpio" > + "qcom,pm7325-gpio" > + "qcom,pm8350c-gpio" > + "qcom,pmk8350-gpio" > + "qcom,pmr735a-gpio" As with the driver, please try to keep these sorted alphabetically and please rebase on linux-next, which already defines 2 of these. Regards, Bjorn > > And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio" > if the device is on an spmi bus or an ssbi bus respectively > @@ -113,6 +117,10 @@ to specify in a pin configuration subnode: > gpio1-gpio12 for pm6150l > gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10 > and gpio11) > + gpio1-gpio10 for pm7325 > + gpio1-gpio9 for pm8350c > + gpio1-gpio4 for pmk8350 > + gpio1-gpio4 for pmr735a > > - function: > Usage: required > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH V2 3/3] dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings to YAML 2021-04-01 12:35 [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A satya priya 2021-04-01 12:35 ` [PATCH V2 1/3] pinctrl: qcom: spmi-gpio: Add support for four variants satya priya 2021-04-01 12:35 ` [PATCH V2 2/3] dt-bindings: pinctrl: qcom-pmic-gpio: Update the binding to add four new variants satya priya @ 2021-04-01 12:35 ` satya priya 2021-04-08 20:53 ` Rob Herring 2021-04-08 13:48 ` [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A Linus Walleij 3 siblings, 1 reply; 10+ messages in thread From: satya priya @ 2021-04-01 12:35 UTC (permalink / raw) To: Linus Walleij, Rob Herring, Andy Gross, Bjorn Andersson Cc: kgunda, linux-gpio, linux-kernel, devicetree, linux-arm-msm, satya priya Convert Qualcomm PMIC GPIO bindings from .txt to .yaml format. Signed-off-by: satya priya <skakit@codeaurora.org> --- Changes in V3: - As per Rob's comments fixed bot erros. - Moved this patch to end of the series so that other patches are not blocked on this. .../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 280 -------------------- .../bindings/pinctrl/qcom,pmic-gpio.yaml | 281 +++++++++++++++++++++ 2 files changed, 281 insertions(+), 280 deletions(-) delete mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt deleted file mode 100644 index da7c35e..0000000 --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt +++ /dev/null @@ -1,280 +0,0 @@ -Qualcomm PMIC GPIO block - -This binding describes the GPIO block(s) found in the 8xxx series of -PMIC's from Qualcomm. - -- compatible: - Usage: required - Value type: <string> - Definition: must be one of: - "qcom,pm8005-gpio" - "qcom,pm8018-gpio" - "qcom,pm8038-gpio" - "qcom,pm8058-gpio" - "qcom,pm8916-gpio" - "qcom,pm8917-gpio" - "qcom,pm8921-gpio" - "qcom,pm8941-gpio" - "qcom,pm8950-gpio" - "qcom,pm8994-gpio" - "qcom,pm8998-gpio" - "qcom,pma8084-gpio" - "qcom,pmi8950-gpio" - "qcom,pmi8994-gpio" - "qcom,pmi8998-gpio" - "qcom,pms405-gpio" - "qcom,pm660-gpio" - "qcom,pm660l-gpio" - "qcom,pm8150-gpio" - "qcom,pm8150b-gpio" - "qcom,pm6150-gpio" - "qcom,pm6150l-gpio" - "qcom,pmx55-gpio" - "qcom,pm7325-gpio" - "qcom,pm8350c-gpio" - "qcom,pmk8350-gpio" - "qcom,pmr735a-gpio" - - And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio" - if the device is on an spmi bus or an ssbi bus respectively - -- reg: - Usage: required - Value type: <prop-encoded-array> - Definition: Register base of the GPIO block and length. - -- interrupts: - Usage: required - Value type: <prop-encoded-array> - Definition: Must contain an array of encoded interrupt specifiers for - each available GPIO - -- gpio-controller: - Usage: required - Value type: <none> - Definition: Mark the device node as a GPIO controller - -- #gpio-cells: - Usage: required - Value type: <u32> - Definition: Must be 2; - the first cell will be used to define gpio number and the - second denotes the flags for this gpio - -Please refer to ../gpio/gpio.txt and ../interrupt-controller/interrupts.txt for -a general description of GPIO and interrupt bindings. - -Please refer to pinctrl-bindings.txt in this directory for details of the -common pinctrl bindings used by client devices, including the meaning of the -phrase "pin configuration node". - -The pin configuration nodes act as a container for an arbitrary number of -subnodes. Each of these subnodes represents some desired configuration for a -pin or a list of pins. This configuration can include the -mux function to select on those pin(s), and various pin configuration -parameters, as listed below. - - -SUBNODES: - -The name of each subnode is not important; all subnodes should be enumerated -and processed purely based on their content. - -Each subnode only affects those parameters that are explicitly listed. In -other words, a subnode that lists a mux function but no pin configuration -parameters implies no information about any pin configuration parameters. -Similarly, a pin subnode that describes a pullup parameter implies no -information about e.g. the mux function. - -The following generic properties as defined in pinctrl-bindings.txt are valid -to specify in a pin configuration subnode: - -- pins: - Usage: required - Value type: <string-array> - Definition: List of gpio pins affected by the properties specified in - this subnode. Valid pins are: - gpio1-gpio4 for pm8005 - gpio1-gpio6 for pm8018 - gpio1-gpio12 for pm8038 - gpio1-gpio40 for pm8058 - gpio1-gpio4 for pm8916 - gpio1-gpio38 for pm8917 - gpio1-gpio44 for pm8921 - gpio1-gpio36 for pm8941 - gpio1-gpio8 for pm8950 (hole on gpio3) - gpio1-gpio22 for pm8994 - gpio1-gpio26 for pm8998 - gpio1-gpio22 for pma8084 - gpio1-gpio2 for pmi8950 - gpio1-gpio10 for pmi8994 - gpio1-gpio12 for pms405 (holes on gpio1, gpio9 and gpio10) - gpio1-gpio10 for pm8150 (holes on gpio2, gpio5, gpio7 - and gpio8) - gpio1-gpio12 for pm8150b (holes on gpio3, gpio4, gpio7) - gpio1-gpio12 for pm8150l (hole on gpio7) - gpio1-gpio10 for pm6150 - gpio1-gpio12 for pm6150l - gpio1-gpio11 for pmx55 (holes on gpio3, gpio7, gpio10 - and gpio11) - gpio1-gpio10 for pm7325 - gpio1-gpio9 for pm8350c - gpio1-gpio4 for pmk8350 - gpio1-gpio4 for pmr735a - -- function: - Usage: required - Value type: <string> - Definition: Specify the alternative function to be configured for the - specified pins. Valid values are: - "normal", - "paired", - "func1", - "func2", - "dtest1", - "dtest2", - "dtest3", - "dtest4", - And following values are supported by LV/MV GPIO subtypes: - "func3", - "func4" - -- bias-disable: - Usage: optional - Value type: <none> - Definition: The specified pins should be configured as no pull. - -- bias-pull-down: - Usage: optional - Value type: <none> - Definition: The specified pins should be configured as pull down. - -- bias-pull-up: - Usage: optional - Value type: <empty> - Definition: The specified pins should be configured as pull up. - -- qcom,pull-up-strength: - Usage: optional - Value type: <u32> - Definition: Specifies the strength to use for pull up, if selected. - Valid values are; as defined in - <dt-bindings/pinctrl/qcom,pmic-gpio.h>: - 1: 30uA (PMIC_GPIO_PULL_UP_30) - 2: 1.5uA (PMIC_GPIO_PULL_UP_1P5) - 3: 31.5uA (PMIC_GPIO_PULL_UP_31P5) - 4: 1.5uA + 30uA boost (PMIC_GPIO_PULL_UP_1P5_30) - If this property is omitted 30uA strength will be used if - pull up is selected - -- bias-high-impedance: - Usage: optional - Value type: <none> - Definition: The specified pins will put in high-Z mode and disabled. - -- input-enable: - Usage: optional - Value type: <none> - Definition: The specified pins are put in input mode. - -- output-high: - Usage: optional - Value type: <none> - Definition: The specified pins are configured in output mode, driven - high. - -- output-low: - Usage: optional - Value type: <none> - Definition: The specified pins are configured in output mode, driven - low. - -- power-source: - Usage: optional - Value type: <u32> - Definition: Selects the power source for the specified pins. Valid - power sources are defined per chip in - <dt-bindings/pinctrl/qcom,pmic-gpio.h> - -- qcom,drive-strength: - Usage: optional - Value type: <u32> - Definition: Selects the drive strength for the specified pins. Value - drive strengths are: - 0: no (PMIC_GPIO_STRENGTH_NO) - 1: high (PMIC_GPIO_STRENGTH_HIGH) 0.9mA @ 1.8V - 1.9mA @ 2.6V - 2: medium (PMIC_GPIO_STRENGTH_MED) 0.6mA @ 1.8V - 1.25mA @ 2.6V - 3: low (PMIC_GPIO_STRENGTH_LOW) 0.15mA @ 1.8V - 0.3mA @ 2.6V - as defined in <dt-bindings/pinctrl/qcom,pmic-gpio.h> - -- drive-push-pull: - Usage: optional - Value type: <none> - Definition: The specified pins are configured in push-pull mode. - -- drive-open-drain: - Usage: optional - Value type: <none> - Definition: The specified pins are configured in open-drain mode. - -- drive-open-source: - Usage: optional - Value type: <none> - Definition: The specified pins are configured in open-source mode. - -- qcom,analog-pass: - Usage: optional - Value type: <none> - Definition: The specified pins are configured in analog-pass-through mode. - -- qcom,atest: - Usage: optional - Value type: <u32> - Definition: Selects ATEST rail to route to GPIO when it's configured - in analog-pass-through mode. - Valid values are 1-4 corresponding to ATEST1 to ATEST4. - -- qcom,dtest-buffer: - Usage: optional - Value type: <u32> - Definition: Selects DTEST rail to route to GPIO when it's configured - as digital input. - Valid values are 1-4 corresponding to DTEST1 to DTEST4. - -Example: - - pm8921_gpio: gpio@150 { - compatible = "qcom,pm8921-gpio", "qcom,ssbi-gpio"; - reg = <0x150 0x160>; - interrupts = <192 1>, <193 1>, <194 1>, - <195 1>, <196 1>, <197 1>, - <198 1>, <199 1>, <200 1>, - <201 1>, <202 1>, <203 1>, - <204 1>, <205 1>, <206 1>, - <207 1>, <208 1>, <209 1>, - <210 1>, <211 1>, <212 1>, - <213 1>, <214 1>, <215 1>, - <216 1>, <217 1>, <218 1>, - <219 1>, <220 1>, <221 1>, - <222 1>, <223 1>, <224 1>, - <225 1>, <226 1>, <227 1>, - <228 1>, <229 1>, <230 1>, - <231 1>, <232 1>, <233 1>, - <234 1>, <235 1>; - - gpio-controller; - #gpio-cells = <2>; - - pm8921_gpio_keys: gpio-keys { - volume-keys { - pins = "gpio20", "gpio21"; - function = "normal"; - - input-enable; - bias-pull-up; - drive-push-pull; - qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>; - power-source = <PM8921_GPIO_S4>; - }; - }; - }; diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml new file mode 100644 index 0000000..e7e7027 --- /dev/null +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml @@ -0,0 +1,281 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pinctrl/qcom,pmic-gpio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm PMIC GPIO block + +maintainers: + - Bjorn Andersson <bjorn.andersson@sonymobile.com> + +description: | + This binding describes the GPIO block(s) found in the 8xxx series of + PMIC's from Qualcomm. + +properties: + compatible: + items: + - enum: + - qcom,pm8005-gpio + - qcom,pm8018-gpio + - qcom,pm8038-gpio + - qcom,pm8058-gpio + - qcom,pm8916-gpio + - qcom,pm8917-gpio + - qcom,pm8921-gpio + - qcom,pm8941-gpio + - qcom,pm8950-gpio + - qcom,pm8994-gpio + - qcom,pm8998-gpio + - qcom,pma8084-gpio + - qcom,pmi8950-gpio + - qcom,pmi8994-gpio + - qcom,pmi8998-gpio + - qcom,pms405-gpio + - qcom,pm660-gpio + - qcom,pm660l-gpio + - qcom,pm8150-gpio + - qcom,pm8150b-gpio + - qcom,pm6150-gpio + - qcom,pm6150l-gpio + - qcom,pmx55-gpio + - qcom,pm7325-gpio + - qcom,pm8350c-gpio + - qcom,pmk8350-gpio + - qcom,pmr735a-gpio + + - enum: + - qcom,spmi-gpio + - qcom,ssbi-gpio + + reg: + description: Register base of the GPIO block and length. + + interrupts: + description: | + Must contain an array of encoded interrupt specifiers for + each available GPIO + + '#interrupt-cells': + const: 2 + + interrupt-controller: true + + gpio-controller: true + + gpio-ranges: + maxItems: 1 + + '#gpio-cells': + const: 2 + description: | + The first cell will be used to define gpio number and the + second denotes the flags for this gpio + + gpio-keys: + type: object + properties: + volume-keys: + type: object + properties: + pins: + description: | + List of gpio pins affected by the properties specified in + this subnode. Valid pins are + - gpio1-gpio4 for pm8005 + - gpio1-gpio6 for pm8018 + - gpio1-gpio12 for pm8038 + - gpio1-gpio40 for pm8058 + - gpio1-gpio4 for pm8916 + - gpio1-gpio38 for pm8917 + - gpio1-gpio44 for pm8921 + - gpio1-gpio36 for pm8941 + - gpio1-gpio8 for pm8950 (hole on gpio3) + - gpio1-gpio22 for pm8994 + - gpio1-gpio26 for pm8998 + - gpio1-gpio22 for pma8084 + - gpio1-gpio2 for pmi8950 + - gpio1-gpio10 for pmi8994 + - gpio1-gpio12 for pms405 (holes on gpio1, gpio9 + and gpio10) + - gpio1-gpio10 for pm8150 (holes on gpio2, gpio5, + gpio7 and gpio8) + - gpio1-gpio12 for pm8150b (holes on gpio3, gpio4 + and gpio7) + - gpio1-gpio12 for pm8150l (hole on gpio7) + - gpio1-gpio10 for pm6150 + - gpio1-gpio12 for pm6150l + - gpio1-gpio10 for pm7325 + - gpio1-gpio9 for pm8350c + - gpio1-gpio4 for pmk8350 + - gpio1-gpio4 for pmr735a + + $ref: /schemas/types.yaml#/definitions/string-array + items: + pattern: "^gpio([0-9]+)$" + + function: + $ref: /schemas/types.yaml#/definitions/string + description: | + Specify the alternative function to be configured for the + specified pins. + items: + - enum: + - normal + - paired + - func1 + - func2 + - dtest1 + - dtest2 + - dtest3 + - dtest4 + - func3 # supported by LV/MV GPIO subtypes + - func4 # supported by LV/MV GPIO subtypes + + bias-disable: + $ref: /schemas/types.yaml#/definitions/flag + description: + The specified pins should be configured as no pull. + + bias-pull-down: + $ref: /schemas/types.yaml#/definitions/flag + description: + The specified pins should be configured as pull down. + + bias-pull-up: + $ref: /schemas/types.yaml#/definitions/flag + description: + The specified pins should be configured as pull up. + + qcom,pull-up-strength: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Specifies the strength to use for pull up, if selected. + Valid values are defined in + <dt-bindings/pinctrl/qcom,pmic-gpio.h> + If this property is omitted 30uA strength will be used + if pull up is selected + + bias-high-impedance: + $ref: /schemas/types.yaml#/definitions/flag + description: + The specified pins will put in high-Z mode and disabled. + + input-enable: + $ref: /schemas/types.yaml#/definitions/flag + description: The specified pins are put in input mode. + + output-high: + $ref: /schemas/types.yaml#/definitions/flag + description: | + The specified pins are configured in output mode, + driven high. + + output-low: + $ref: /schemas/types.yaml#/definitions/flag + description: | + The specified pins are configured in output mode, + driven low. + + power-source: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Selects the power source for the specified pins. + Valid power sources are defined per chip in + <dt-bindings/pinctrl/qcom,pmic-gpio.h> + + qcom,drive-strength: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Selects the drive strength for the specified pins + Valid drive strength values are defined in + <dt-bindings/pinctrl/qcom,pmic-gpio.h> + + drive-push-pull: + $ref: /schemas/types.yaml#/definitions/flag + description: + The specified pins are configured in push-pull mode. + + drive-open-drain: + $ref: /schemas/types.yaml#/definitions/flag + description: + The specified pins are configured in open-drain mode. + + drive-open-source: + $ref: /schemas/types.yaml#/definitions/flag + description: + The specified pins are configured in open-source mode. + + qcom,analog-pass: + $ref: /schemas/types.yaml#/definitions/flag + description: | + The specified pins are configured in + analog-pass-through mode. + + qcom,atest: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Selects ATEST rail to route to GPIO when it's + configured in analog-pass-through mode. + enum: [1 2 3 4] + + qcom,dtest-buffer: + $ref: /schemas/types.yaml#/definitions/uint32 + description: | + Selects DTEST rail to route to GPIO when it's + configured as digital input. + enum: [1 2 3 4] + + required: + - pins + - function + + additionalProperties: true + +additionalProperties: true + +required: + - compatible + - reg + +examples: + - | + #include <dt-bindings/pinctrl/qcom,pmic-gpio.h> + + pm8921_gpio: gpio@150 { + compatible = "qcom,pm8921-gpio", "qcom,ssbi-gpio"; + reg = <0x150 0x160>; + interrupts = <192 1>, <193 1>, <194 1>, + <195 1>, <196 1>, <197 1>, + <198 1>, <199 1>, <200 1>, + <201 1>, <202 1>, <203 1>, + <204 1>, <205 1>, <206 1>, + <207 1>, <208 1>, <209 1>, + <210 1>, <211 1>, <212 1>, + <213 1>, <214 1>, <215 1>, + <216 1>, <217 1>, <218 1>, + <219 1>, <220 1>, <221 1>, + <222 1>, <223 1>, <224 1>, + <225 1>, <226 1>, <227 1>, + <228 1>, <229 1>, <230 1>, + <231 1>, <232 1>, <233 1>, + <234 1>, <235 1>; + + gpio-controller; + #gpio-cells = <2>; + + pm8921_gpio_keys: gpio-keys { + volume-keys { + pins = "gpio20", "gpio21"; + function = "normal"; + + input-enable; + bias-pull-up; + drive-push-pull; + qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>; + power-source = <PM8921_GPIO_S4>; + }; + }; + }; +... -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH V2 3/3] dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings to YAML 2021-04-01 12:35 ` [PATCH V2 3/3] dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings to YAML satya priya @ 2021-04-08 20:53 ` Rob Herring 2021-05-06 4:48 ` skakit 0 siblings, 1 reply; 10+ messages in thread From: Rob Herring @ 2021-04-08 20:53 UTC (permalink / raw) To: satya priya Cc: Linus Walleij, Andy Gross, Bjorn Andersson, kgunda, linux-gpio, linux-kernel, devicetree, linux-arm-msm On Thu, Apr 01, 2021 at 06:05:45PM +0530, satya priya wrote: > Convert Qualcomm PMIC GPIO bindings from .txt to .yaml format. > > Signed-off-by: satya priya <skakit@codeaurora.org> > --- > Changes in V3: > - As per Rob's comments fixed bot erros. > - Moved this patch to end of the series so that other patches are not > blocked on this. > > .../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 280 -------------------- > .../bindings/pinctrl/qcom,pmic-gpio.yaml | 281 +++++++++++++++++++++ > 2 files changed, 281 insertions(+), 280 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt > create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > new file mode 100644 > index 0000000..e7e7027 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > @@ -0,0 +1,281 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/qcom,pmic-gpio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm PMIC GPIO block > + > +maintainers: > + - Bjorn Andersson <bjorn.andersson@sonymobile.com> > + > +description: | > + This binding describes the GPIO block(s) found in the 8xxx series of > + PMIC's from Qualcomm. > + > +properties: > + compatible: > + items: > + - enum: > + - qcom,pm8005-gpio > + - qcom,pm8018-gpio > + - qcom,pm8038-gpio > + - qcom,pm8058-gpio > + - qcom,pm8916-gpio > + - qcom,pm8917-gpio > + - qcom,pm8921-gpio > + - qcom,pm8941-gpio > + - qcom,pm8950-gpio > + - qcom,pm8994-gpio > + - qcom,pm8998-gpio > + - qcom,pma8084-gpio > + - qcom,pmi8950-gpio > + - qcom,pmi8994-gpio > + - qcom,pmi8998-gpio > + - qcom,pms405-gpio > + - qcom,pm660-gpio > + - qcom,pm660l-gpio > + - qcom,pm8150-gpio > + - qcom,pm8150b-gpio > + - qcom,pm6150-gpio > + - qcom,pm6150l-gpio > + - qcom,pmx55-gpio > + - qcom,pm7325-gpio > + - qcom,pm8350c-gpio > + - qcom,pmk8350-gpio > + - qcom,pmr735a-gpio > + > + - enum: > + - qcom,spmi-gpio > + - qcom,ssbi-gpio Any combination of the 1st and 2nd entry is valid? > + > + reg: > + description: Register base of the GPIO block and length. Just: maxItems: 1 > + > + interrupts: > + description: | > + Must contain an array of encoded interrupt specifiers for > + each available GPIO Need to define how many interrupts. I assume there's some max. > + > + '#interrupt-cells': > + const: 2 > + > + interrupt-controller: true > + > + gpio-controller: true > + > + gpio-ranges: > + maxItems: 1 > + > + '#gpio-cells': > + const: 2 > + description: | > + The first cell will be used to define gpio number and the > + second denotes the flags for this gpio > + > + gpio-keys: > + type: object > + properties: > + volume-keys: > + type: object Needs a $ref to pinmux-node.yaml and pincfg-node.yaml. > + properties: > + pins: > + description: | > + List of gpio pins affected by the properties specified in > + this subnode. Valid pins are > + - gpio1-gpio4 for pm8005 > + - gpio1-gpio6 for pm8018 > + - gpio1-gpio12 for pm8038 > + - gpio1-gpio40 for pm8058 > + - gpio1-gpio4 for pm8916 > + - gpio1-gpio38 for pm8917 > + - gpio1-gpio44 for pm8921 > + - gpio1-gpio36 for pm8941 > + - gpio1-gpio8 for pm8950 (hole on gpio3) > + - gpio1-gpio22 for pm8994 > + - gpio1-gpio26 for pm8998 > + - gpio1-gpio22 for pma8084 > + - gpio1-gpio2 for pmi8950 > + - gpio1-gpio10 for pmi8994 > + - gpio1-gpio12 for pms405 (holes on gpio1, gpio9 > + and gpio10) > + - gpio1-gpio10 for pm8150 (holes on gpio2, gpio5, > + gpio7 and gpio8) > + - gpio1-gpio12 for pm8150b (holes on gpio3, gpio4 > + and gpio7) > + - gpio1-gpio12 for pm8150l (hole on gpio7) > + - gpio1-gpio10 for pm6150 > + - gpio1-gpio12 for pm6150l > + - gpio1-gpio10 for pm7325 > + - gpio1-gpio9 for pm8350c > + - gpio1-gpio4 for pmk8350 > + - gpio1-gpio4 for pmr735a > + > + $ref: /schemas/types.yaml#/definitions/string-array Already has a type in pinmux-node.yaml. > + items: > + pattern: "^gpio([0-9]+)$" > + > + function: > + $ref: /schemas/types.yaml#/definitions/string ditto > + description: | > + Specify the alternative function to be configured for the > + specified pins. > + items: > + - enum: > + - normal > + - paired > + - func1 > + - func2 > + - dtest1 > + - dtest2 > + - dtest3 > + - dtest4 > + - func3 # supported by LV/MV GPIO subtypes > + - func4 # supported by LV/MV GPIO subtypes > + > + bias-disable: > + $ref: /schemas/types.yaml#/definitions/flag And all these have a type and description. Just: bias-disable: true If no further constraints. > + description: > + The specified pins should be configured as no pull. > + > + bias-pull-down: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The specified pins should be configured as pull down. > + > + bias-pull-up: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The specified pins should be configured as pull up. > + > + qcom,pull-up-strength: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Specifies the strength to use for pull up, if selected. > + Valid values are defined in > + <dt-bindings/pinctrl/qcom,pmic-gpio.h> > + If this property is omitted 30uA strength will be used > + if pull up is selected > + > + bias-high-impedance: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The specified pins will put in high-Z mode and disabled. > + > + input-enable: > + $ref: /schemas/types.yaml#/definitions/flag > + description: The specified pins are put in input mode. > + > + output-high: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + The specified pins are configured in output mode, > + driven high. > + > + output-low: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + The specified pins are configured in output mode, > + driven low. > + > + power-source: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Selects the power source for the specified pins. > + Valid power sources are defined per chip in > + <dt-bindings/pinctrl/qcom,pmic-gpio.h> > + > + qcom,drive-strength: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Selects the drive strength for the specified pins > + Valid drive strength values are defined in > + <dt-bindings/pinctrl/qcom,pmic-gpio.h> > + > + drive-push-pull: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The specified pins are configured in push-pull mode. > + > + drive-open-drain: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The specified pins are configured in open-drain mode. > + > + drive-open-source: > + $ref: /schemas/types.yaml#/definitions/flag > + description: > + The specified pins are configured in open-source mode. > + > + qcom,analog-pass: > + $ref: /schemas/types.yaml#/definitions/flag > + description: | > + The specified pins are configured in > + analog-pass-through mode. > + > + qcom,atest: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Selects ATEST rail to route to GPIO when it's > + configured in analog-pass-through mode. > + enum: [1 2 3 4] > + > + qcom,dtest-buffer: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: | > + Selects DTEST rail to route to GPIO when it's > + configured as digital input. > + enum: [1 2 3 4] > + > + required: > + - pins > + - function > + > + additionalProperties: true > + > +additionalProperties: true Should be 'false'. > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + #include <dt-bindings/pinctrl/qcom,pmic-gpio.h> > + > + pm8921_gpio: gpio@150 { > + compatible = "qcom,pm8921-gpio", "qcom,ssbi-gpio"; > + reg = <0x150 0x160>; > + interrupts = <192 1>, <193 1>, <194 1>, > + <195 1>, <196 1>, <197 1>, > + <198 1>, <199 1>, <200 1>, > + <201 1>, <202 1>, <203 1>, > + <204 1>, <205 1>, <206 1>, > + <207 1>, <208 1>, <209 1>, > + <210 1>, <211 1>, <212 1>, > + <213 1>, <214 1>, <215 1>, > + <216 1>, <217 1>, <218 1>, > + <219 1>, <220 1>, <221 1>, > + <222 1>, <223 1>, <224 1>, > + <225 1>, <226 1>, <227 1>, > + <228 1>, <229 1>, <230 1>, > + <231 1>, <232 1>, <233 1>, > + <234 1>, <235 1>; > + > + gpio-controller; > + #gpio-cells = <2>; > + > + pm8921_gpio_keys: gpio-keys { > + volume-keys { > + pins = "gpio20", "gpio21"; > + function = "normal"; > + > + input-enable; > + bias-pull-up; > + drive-push-pull; > + qcom,drive-strength = <PMIC_GPIO_STRENGTH_NO>; > + power-source = <PM8921_GPIO_S4>; > + }; > + }; > + }; > +... > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2 3/3] dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings to YAML 2021-04-08 20:53 ` Rob Herring @ 2021-05-06 4:48 ` skakit 0 siblings, 0 replies; 10+ messages in thread From: skakit @ 2021-05-06 4:48 UTC (permalink / raw) To: Rob Herring Cc: Linus Walleij, Andy Gross, Bjorn Andersson, kgunda, linux-gpio, linux-kernel, devicetree, linux-arm-msm Hi Rob, On 2021-04-09 02:23, Rob Herring wrote: > On Thu, Apr 01, 2021 at 06:05:45PM +0530, satya priya wrote: >> Convert Qualcomm PMIC GPIO bindings from .txt to .yaml format. >> >> Signed-off-by: satya priya <skakit@codeaurora.org> >> --- >> Changes in V3: >> - As per Rob's comments fixed bot erros. >> - Moved this patch to end of the series so that other patches are not >> blocked on this. >> >> .../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 280 >> -------------------- >> .../bindings/pinctrl/qcom,pmic-gpio.yaml | 281 >> +++++++++++++++++++++ >> 2 files changed, 281 insertions(+), 280 deletions(-) >> delete mode 100644 >> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt >> create mode 100644 >> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml > > >> diff --git >> a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >> b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >> new file mode 100644 >> index 0000000..e7e7027 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.yaml >> @@ -0,0 +1,281 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pinctrl/qcom,pmic-gpio.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm PMIC GPIO block >> + >> +maintainers: >> + - Bjorn Andersson <bjorn.andersson@sonymobile.com> >> + >> +description: | >> + This binding describes the GPIO block(s) found in the 8xxx series >> of >> + PMIC's from Qualcomm. >> + >> +properties: >> + compatible: >> + items: >> + - enum: >> + - qcom,pm8005-gpio >> + - qcom,pm8018-gpio >> + - qcom,pm8038-gpio >> + - qcom,pm8058-gpio >> + - qcom,pm8916-gpio >> + - qcom,pm8917-gpio >> + - qcom,pm8921-gpio >> + - qcom,pm8941-gpio >> + - qcom,pm8950-gpio >> + - qcom,pm8994-gpio >> + - qcom,pm8998-gpio >> + - qcom,pma8084-gpio >> + - qcom,pmi8950-gpio >> + - qcom,pmi8994-gpio >> + - qcom,pmi8998-gpio >> + - qcom,pms405-gpio >> + - qcom,pm660-gpio >> + - qcom,pm660l-gpio >> + - qcom,pm8150-gpio >> + - qcom,pm8150b-gpio >> + - qcom,pm6150-gpio >> + - qcom,pm6150l-gpio >> + - qcom,pmx55-gpio >> + - qcom,pm7325-gpio >> + - qcom,pm8350c-gpio >> + - qcom,pmk8350-gpio >> + - qcom,pmr735a-gpio >> + >> + - enum: >> + - qcom,spmi-gpio >> + - qcom,ssbi-gpio > > Any combination of the 1st and 2nd entry is valid? > No, for pmics which use spmi and ssbi buses, "qcom,spmi-gpio" and "qcom,ssbi-gpio" compatibles should be used respectively. >> + >> + reg: >> + description: Register base of the GPIO block and length. > > Just: > > maxItems: 1 > ok. >> + >> + interrupts: >> + description: | >> + Must contain an array of encoded interrupt specifiers for >> + each available GPIO > > Need to define how many interrupts. I assume there's some max. > ok will add maxItems. >> + >> + '#interrupt-cells': >> + const: 2 >> + >> + interrupt-controller: true >> + >> + gpio-controller: true >> + >> + gpio-ranges: >> + maxItems: 1 >> + >> + '#gpio-cells': >> + const: 2 >> + description: | >> + The first cell will be used to define gpio number and the >> + second denotes the flags for this gpio >> + >> + gpio-keys: >> + type: object >> + properties: >> + volume-keys: >> + type: object > > Needs a $ref to pinmux-node.yaml and pincfg-node.yaml. > can I add like below? volume-keys: type: object + anyOf: + - $ref: "pinmux-node.yaml" + - $ref: "pincfg-node.yaml" >> + properties: >> + pins: >> + description: | >> + List of gpio pins affected by the properties >> specified in >> + this subnode. Valid pins are >> + - gpio1-gpio4 for pm8005 >> + - gpio1-gpio6 for pm8018 >> + - gpio1-gpio12 for pm8038 >> + - gpio1-gpio40 for pm8058 >> + - gpio1-gpio4 for pm8916 >> + - gpio1-gpio38 for pm8917 >> + - gpio1-gpio44 for pm8921 >> + - gpio1-gpio36 for pm8941 >> + - gpio1-gpio8 for pm8950 (hole on gpio3) >> + - gpio1-gpio22 for pm8994 >> + - gpio1-gpio26 for pm8998 >> + - gpio1-gpio22 for pma8084 >> + - gpio1-gpio2 for pmi8950 >> + - gpio1-gpio10 for pmi8994 >> + - gpio1-gpio12 for pms405 (holes on gpio1, gpio9 >> + and gpio10) >> + - gpio1-gpio10 for pm8150 (holes on gpio2, >> gpio5, >> + gpio7 and gpio8) >> + - gpio1-gpio12 for pm8150b (holes on gpio3, >> gpio4 >> + and gpio7) >> + - gpio1-gpio12 for pm8150l (hole on gpio7) >> + - gpio1-gpio10 for pm6150 >> + - gpio1-gpio12 for pm6150l >> + - gpio1-gpio10 for pm7325 >> + - gpio1-gpio9 for pm8350c >> + - gpio1-gpio4 for pmk8350 >> + - gpio1-gpio4 for pmr735a >> + >> + $ref: /schemas/types.yaml#/definitions/string-array > > Already has a type in pinmux-node.yaml. > Okay, will add above and remove here. >> + items: >> + pattern: "^gpio([0-9]+)$" >> + >> + function: >> + $ref: /schemas/types.yaml#/definitions/string > > ditto > Okay, will add above and remove here. >> + description: | >> + Specify the alternative function to be configured for >> the >> + specified pins. >> + items: >> + - enum: >> + - normal >> + - paired >> + - func1 >> + - func2 >> + - dtest1 >> + - dtest2 >> + - dtest3 >> + - dtest4 >> + - func3 # supported by LV/MV GPIO subtypes >> + - func4 # supported by LV/MV GPIO subtypes >> + >> + bias-disable: >> + $ref: /schemas/types.yaml#/definitions/flag > > And all these have a type and description. Just: > > bias-disable: true > > If no further constraints. > Okay. >> + description: >> + The specified pins should be configured as no pull. >> + >> + bias-pull-down: >> + $ref: /schemas/types.yaml#/definitions/flag [...] >> + additionalProperties: true >> + >> +additionalProperties: true > > Should be 'false'. > Okay. Thanks, Satya Priya ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A 2021-04-01 12:35 [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A satya priya ` (2 preceding siblings ...) 2021-04-01 12:35 ` [PATCH V2 3/3] dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings to YAML satya priya @ 2021-04-08 13:48 ` Linus Walleij 2021-04-09 8:20 ` skakit 3 siblings, 1 reply; 10+ messages in thread From: Linus Walleij @ 2021-04-08 13:48 UTC (permalink / raw) To: satya priya Cc: Rob Herring, Andy Gross, Bjorn Andersson, Kiran Gunda, open list:GPIO SUBSYSTEM, linux-kernel, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, MSM On Thu, Apr 1, 2021 at 2:36 PM satya priya <skakit@codeaurora.org> wrote: > satya priya (3): > pinctrl: qcom: spmi-gpio: Add support for four variants > dt-bindings: pinctrl: qcom-pmic-gpio: Update the binding to add four > new variants > dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings > to YAML Please collect the ACKs and rebase like Björn says, sort stuff alphabetically and resend so I can try to apply it! The YAML conversion may need a nod from the DT people as well. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A 2021-04-08 13:48 ` [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A Linus Walleij @ 2021-04-09 8:20 ` skakit 0 siblings, 0 replies; 10+ messages in thread From: skakit @ 2021-04-09 8:20 UTC (permalink / raw) To: Linus Walleij Cc: Rob Herring, Andy Gross, Bjorn Andersson, Kiran Gunda, open list:GPIO SUBSYSTEM, linux-kernel, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, MSM On 2021-04-08 19:18, Linus Walleij wrote: > On Thu, Apr 1, 2021 at 2:36 PM satya priya <skakit@codeaurora.org> > wrote: > >> satya priya (3): >> pinctrl: qcom: spmi-gpio: Add support for four variants >> dt-bindings: pinctrl: qcom-pmic-gpio: Update the binding to add four >> new variants >> dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio >> bindings >> to YAML > > Please collect the ACKs and rebase like Björn says, sort stuff > alphabetically > and resend so I can try to apply it! The YAML conversion may need a nod > from > the DT people as well. > Sure, will address the comments and resend. > Yours, > Linus Walleij Thanks, Satya Priya ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-05-06 4:49 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-01 12:35 [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A satya priya 2021-04-01 12:35 ` [PATCH V2 1/3] pinctrl: qcom: spmi-gpio: Add support for four variants satya priya 2021-04-01 15:25 ` Bjorn Andersson 2021-04-01 12:35 ` [PATCH V2 2/3] dt-bindings: pinctrl: qcom-pmic-gpio: Update the binding to add four new variants satya priya 2021-04-01 15:26 ` Bjorn Andersson 2021-04-01 12:35 ` [PATCH V2 3/3] dt-bindings: pinctrl: qcom-pmic-gpio: Convert qcom pmic gpio bindings to YAML satya priya 2021-04-08 20:53 ` Rob Herring 2021-05-06 4:48 ` skakit 2021-04-08 13:48 ` [PATCH V2 0/3] Add GPIO support for PM7325, PM8350c, PMK8350 and PMR735A Linus Walleij 2021-04-09 8:20 ` skakit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).