From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6303C43467 for ; Wed, 14 Oct 2020 09:20:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5353F214D8 for ; Wed, 14 Oct 2020 09:20:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lmrB2YzC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387869AbgJNJUu (ORCPT ); Wed, 14 Oct 2020 05:20:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731054AbgJNJUn (ORCPT ); Wed, 14 Oct 2020 05:20:43 -0400 Received: from mail-ua1-x943.google.com (mail-ua1-x943.google.com [IPv6:2607:f8b0:4864:20::943]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C6C2C0613A9 for ; Tue, 13 Oct 2020 14:38:29 -0700 (PDT) Received: by mail-ua1-x943.google.com with SMTP id j15so447317uaa.8 for ; Tue, 13 Oct 2020 14:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iaXaNW2aV97D5ctXO138LriNxFwgSSTpbL/SoLhTQI0=; b=lmrB2YzCp8StLVkt9dtcv9/wpvpxiyXtb0Iz9iRWltXMcOEpwym2EHbwSvmAaX5CXS D2Qm+WjJU2LmSziIQxPeS7HFHoDRRwE5FZhOHuV5qPOQ1mcuxxjhHosaXwqXkdjlDKs/ W5cZvBus9lgLJgunyaPlGy4gGK6mZnxF6VBeE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iaXaNW2aV97D5ctXO138LriNxFwgSSTpbL/SoLhTQI0=; b=E8s0poY9RzfdGG75MDVLpGeYQrgtq47cfo13D50e5rheRaFutBNxY0C6UHL2UHLfUX bXTODrRPfq5rDUXV7Cuh4RcloZbb8VMgTVFFVYn+H4p73Vcjn5HgYpIC8CCPDKf2908w U8m3AwphYhHwbF9tMgclptzL0wGZ/ma24gphnLyssmqu+Qx4oUbWDMVP75ToW7fxklRD TEuqo1+XcdPGZsvbmNj3agmEd/xCWEli62J8FSBYHlpsSwsYhkJ9nCQFfgQE4mfmyvh/ YtS0bmI3kJrQJIK9+6FqUngzsxjc3HL/NdrzbNwm6td0plmghd1MjOlsVnEb9sM6LStk 9Zfg== X-Gm-Message-State: AOAM533QUUbdYEEmPAXCYGhZqC3H1OTT89xEJAUBHBrW9xNh7NuZhLTc SkOVkAWTRTynOE39rwEF77Er9HW2MWAgrw== X-Google-Smtp-Source: ABdhPJyJdfCR8spqEpb7dkeKvJBcfAV7Ref7fHA2NbC13cuMX7KfSP7O43he1uPmM/KtplnJdxPcFQ== X-Received: by 2002:ab0:2982:: with SMTP id u2mr1603008uap.68.1602625108299; Tue, 13 Oct 2020 14:38:28 -0700 (PDT) Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com. [209.85.222.53]) by smtp.gmail.com with ESMTPSA id u15sm169843vsp.9.2020.10.13.14.38.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Oct 2020 14:38:27 -0700 (PDT) Received: by mail-ua1-f53.google.com with SMTP id f15so448086uaq.9 for ; Tue, 13 Oct 2020 14:38:27 -0700 (PDT) X-Received: by 2002:a9f:31ce:: with SMTP id w14mr1686577uad.104.1602625107073; Tue, 13 Oct 2020 14:38:27 -0700 (PDT) MIME-Version: 1.0 References: <20201008225235.2035820-1-dianders@chromium.org> <20201008155154.3.I646736d3969dc47de8daceb379c6ba85993de9f4@changeid> <160228992470.310579.7455188858203154687@swboyd.mtv.corp.google.com> In-Reply-To: <160228992470.310579.7455188858203154687@swboyd.mtv.corp.google.com> From: Doug Anderson Date: Tue, 13 Oct 2020 14:38:15 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 3/3] soc: qcom: geni: Optimize select fifo/dma mode To: Stephen Boyd Cc: Akash Asthana , Bjorn Andersson , Wolfram Sang , linux-arm-msm , linux-i2c@vger.kernel.org, Andy Gross , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Fri, Oct 9, 2020 at 5:32 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-10-08 15:52:35) > > diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c > > index 751a49f6534f..746854745b15 100644 > > --- a/drivers/soc/qcom/qcom-geni-se.c > > +++ b/drivers/soc/qcom/qcom-geni-se.c > > @@ -266,49 +266,53 @@ EXPORT_SYMBOL(geni_se_init); > > static void geni_se_select_fifo_mode(struct geni_se *se) > > { > > u32 proto = geni_se_read_proto(se); > > - u32 val; > > + u32 val, val_old; > > > > geni_se_irq_clear(se); > > > > - val = readl_relaxed(se->base + SE_GENI_M_IRQ_EN); > > if (proto != GENI_SE_UART) { > > + val_old = val = readl_relaxed(se->base + SE_GENI_M_IRQ_EN); > > val |= M_CMD_DONE_EN | M_TX_FIFO_WATERMARK_EN; > > val |= M_RX_FIFO_WATERMARK_EN | M_RX_FIFO_LAST_EN; > > - } > > - writel_relaxed(val, se->base + SE_GENI_M_IRQ_EN); > > + if (val != val_old) > > + writel_relaxed(val, se->base + SE_GENI_M_IRQ_EN); > > > > - val = readl_relaxed(se->base + SE_GENI_S_IRQ_EN); > > - if (proto != GENI_SE_UART) > > - val |= S_CMD_DONE_EN; > > - writel_relaxed(val, se->base + SE_GENI_S_IRQ_EN); > > + val = readl_relaxed(se->base + SE_GENI_S_IRQ_EN); > > Can we use the val_old trick here too? > > > + if (!(val & S_CMD_DONE_EN)) > > + writel_relaxed(val | S_CMD_DONE_EN, > > Because this val | S_CMD_DONE_EN thing is just hard to read :/ This is done in v2. Thanks for your review! -Doug