From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE4DC433E0 for ; Thu, 25 Mar 2021 16:19:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C86F61A21 for ; Thu, 25 Mar 2021 16:19:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229984AbhCYQSk (ORCPT ); Thu, 25 Mar 2021 12:18:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229662AbhCYQSL (ORCPT ); Thu, 25 Mar 2021 12:18:11 -0400 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E300C06175F for ; Thu, 25 Mar 2021 09:18:10 -0700 (PDT) Received: by mail-yb1-xb34.google.com with SMTP id i144so2881128ybg.1 for ; Thu, 25 Mar 2021 09:18:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QQUSMG2MYvr7z2lGID3UbwL8eVjOA95JzM6A/R4Iu1E=; b=IRAPbpwUGbuUSp2HYxkhC7c7pPoKfFtl7jbJslD/5YuRK/PXAtdEHHvefviHJJNJU8 /GNZ4Jvf/qQ0BFs1R+xzmZfjtVA6o+81OWemBKmiDSNjAWnip31eC5PgkpPyVCB0uwWR OBeVkR2CBo6VbKoDIeLGSVzeL9PSH9zXyt/Uxj6OAPQAeJxGnVVv0hTRgBhlWAGkhKgv oxHvU/MptLG2T5zdSLxoGRgVCwyjfl7VGTEv2bHv6Nqx9PCqD08DDB14ZIDdxPsoUGxA nCxZznnptNnoDeEZwYSwC/yZT0w0BWchvcZpQ8ZhPQqWoQCM9X8XofRfO7wWT+wvnbR9 AdSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QQUSMG2MYvr7z2lGID3UbwL8eVjOA95JzM6A/R4Iu1E=; b=QV6WNX8FQoMD9GJB1GGMOosAXJYQ08XKdUlKiZ89IBkr2yS/1HVrH6Q9oKpht5V4tp FWe/Yxb29SoMM4xNzhuwTznwjgi3PaDMFBBSKbFOWA1dVWaLOP1N4VlbFrt8u0Jg7uqx XdoQ3eNWyvJPGJ58ChiDADXZwtOSEq/gw/Nar/xGpjGY3Xo+0nPvzFVyn69KoWb6vlfK /GQ5hopSVw6W057ZqpUHM4kUv6g/vr00ZJ1V2nVi2rvCRvBLnd8a8A2Qglxg94PmeraP 49zS8gWhoAXSPHIn3K58u6KylfeuRaNbDi+2jxcD4rStQQDW5WkkYd4I3sMIvUpO749z I3/A== X-Gm-Message-State: AOAM5330eO+CuaMuDmvibrJ1u+FzqUmyisv6zwGoWmbGAWYhP8pn1saO lVUChFoEYc5i8ykf8DAiBtap6bhonBhD2zdKQvAoRQ== X-Google-Smtp-Source: ABdhPJyCI41mEQVSMR5OzYWKNCakBrYDxOD4TjekSAjXtIhStEvQQQrTQE12lRIasP2p34vK39aXj/x47+APczR7xLE= X-Received: by 2002:a5b:54a:: with SMTP id r10mr12095885ybp.476.1616689089164; Thu, 25 Mar 2021 09:18:09 -0700 (PDT) MIME-Version: 1.0 References: <1616264220-25825-1-git-send-email-sbhanu@codeaurora.org> In-Reply-To: From: Doug Anderson Date: Thu, 25 Mar 2021 09:17:57 -0700 Message-ID: Subject: Re: [PATCH V2] arm64: dts: qcom: sc7280: Add nodes for eMMC and SD card To: Veerabhadrarao Badiganti Cc: Shaik Sajida Bhanu , Adrian Hunter , Ulf Hansson , Rob Herring , Asutosh Das , Sahitya Tummala , Ram Prakash Gupta , Sayali Lokhande , sartgarg@codeaurora.org, Rajendra Nayak , Sai Prakash Ranjan , Sibi Sankar , cang@codeaurora.org, pragalla@codeaurora.org, nitirawa@codeaurora.org, Linux MMC List , LKML , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Andy Gross , Bjorn Andersson Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Wed, Mar 24, 2021 at 8:59 PM Veerabhadrarao Badiganti wrote: > > >> + clocks = <&gcc GCC_SDCC1_APPS_CLK>, > >> + <&gcc GCC_SDCC1_AHB_CLK>, > >> + <&rpmhcc RPMH_CXO_CLK>; > >> + clock-names = "core", "iface", "xo"; > > I'm curious: why is the "xo" clock needed here but not for sc7180? > Actually its needed even for sc7180. We are making use of this clock in > msm_init_cm_dll() > The default PoR value is also same as calculated value for > HS200/HS400/SDR104 modes. > But just not to rely on default register values we need this entry. Can you post a patch for sc7180? > >> + bus-width = <4>; > >> + > >> + no-mmc; > >> + no-sdio; > > Similar question to above: why exactly would mmc not work? Are you > > saying that if someone hooked this up to a full sized SD card slot and > > placed an MMC card into the slot that it wouldn't work? Similar > > question about SDIO. If someone placed an external SDIO card into your > > slot, would it not work? > > > As mentioned above, its just to optimize SDcard scan time a little. OK. ...but while the eMMC one can make sense since the eMMC is soldered down (but in the board dts file, not in the SoC dtsi file) I think you should just remove these for SD card because: 1. Even if only a uSD slot is exposed it's still _possible_ for someone to insert a card that uses MMC or SDIO signaling. If nothing else I have a (probably non-compliant) adapter that plugs into a uSD slot and provides a full sided SD slot. I could plug an MMC card or SDIO card in. 2. Presumably the SD card scan time optimization is tiny. -Doug