From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1A3EC43331 for ; Tue, 2 Mar 2021 07:57:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69F5D6146D for ; Tue, 2 Mar 2021 07:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238695AbhCBElg (ORCPT ); Mon, 1 Mar 2021 23:41:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344188AbhCAWvB (ORCPT ); Mon, 1 Mar 2021 17:51:01 -0500 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B488EC06178B for ; Mon, 1 Mar 2021 14:43:31 -0800 (PST) Received: by mail-qk1-x72c.google.com with SMTP id l132so17189991qke.7 for ; Mon, 01 Mar 2021 14:43:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KSW03qXRNzDDWUFd7HDVgAkqmhLV+uIrk9Nn7LdcJQA=; b=drUkO2+KLPEIvI8tMqJjJb9nI3O6lfZOPMqiw32jogITD6yPK2lJ6CRWJyZu2FXq6D eGwQ6llMSy51834BWN+9xSe51F+x0CDiVHP4JgyeIr/DPQEYs0HHYbKvFJwy5nSkT+7o MQmTVUeL6YlzNqkHelJVuAyZ2HtwPyNVBmQdg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KSW03qXRNzDDWUFd7HDVgAkqmhLV+uIrk9Nn7LdcJQA=; b=KGdkCRBAYKYt3On/XjV9Wifi5DaKXzTCEiF5U7LNeD3K2scupXQXbdrr6P44dDXHAG 8FScau3Nj+a1aaEQh8OYP/fbQXmd6mqZEAC3fxeDz1KfuD04yDSUUgfMnFJAeaSepDsK zuVpXJWbX6XVcmSw/i+rpNTGenNGTuKcQXuEY8D7t8Hp/db52Z9sePRN2dubZ7ZO75/q 5DGEmmY5vQQDpX3GMQQ9/HOMr7Tekvcc01RG84jQG+OztXHXTRjD7YSgNe1NkvtB5jxz Fyhmacr/aNU/vbtVshdrOB4MPlywhs/x+PmD2xb7ECo+7uPKknGRh5RWpaXvpMBZPoZ7 pYIA== X-Gm-Message-State: AOAM5312otIl9VIKlFAIvtqi4dFNlBQdBsa16q293T1CwfzUS2HqMTKc sjG7rgky/5zAlT1O1+mGIbQkqqt3lYVoBQ== X-Google-Smtp-Source: ABdhPJzassuVyXZE7zYvuC8zsaAZyFslLl/8r/CSkKU37ikQbJSeVnrFxMsEPeclcCG2E7hdzOJQXQ== X-Received: by 2002:ae9:efc4:: with SMTP id d187mr17199243qkg.316.1614638610766; Mon, 01 Mar 2021 14:43:30 -0800 (PST) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id e15sm12257937qti.79.2021.03.01.14.43.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Mar 2021 14:43:30 -0800 (PST) Received: by mail-yb1-f174.google.com with SMTP id 133so18668517ybd.5 for ; Mon, 01 Mar 2021 14:43:29 -0800 (PST) X-Received: by 2002:a5b:84f:: with SMTP id v15mr24920639ybq.79.1614638609454; Mon, 01 Mar 2021 14:43:29 -0800 (PST) MIME-Version: 1.0 References: <523a5af43615b804aa1211a3f27e06226d7159bc.1614624041.git.saiprakash.ranjan@codeaurora.org> In-Reply-To: <523a5af43615b804aa1211a3f27e06226d7159bc.1614624041.git.saiprakash.ranjan@codeaurora.org> From: Doug Anderson Date: Mon, 1 Mar 2021 14:43:18 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCHv2 2/4] perf evsel: Print warning for excluding kernel mode instruction tracing To: Sai Prakash Ranjan Cc: Mathieu Poirier , Suzuki K Poulose , Mike Leach , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Leo Yan , Jiri Olsa , Namhyung Kim , coresight@lists.linaro.org, Stephen Boyd , Denis Nikitin , Mattias Nissler , Al Grant , linux-arm-msm , LKML , Linux ARM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Mon, Mar 1, 2021 at 11:05 AM Sai Prakash Ranjan wrote: > > Add a warning message to check CONFIG_EXCLUDE_KERNEL_HW_ITRACE kernel > config which excludes kernel mode instruction tracing to help perf tool > users identify the perf event open failure when they attempt kernel mode > tracing with this config enabled. > > Tested-by: Denis Nikitin > Signed-off-by: Sai Prakash Ranjan > --- > tools/perf/util/evsel.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) I'm not really knowledgeable at all about the perf subsystem so my review doesn't hold a lot of weight. However, Sai's patch seems sane to me. Reviewed-by: Douglas Anderson