From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Update flash freq to match reality
Date: Wed, 19 May 2021 09:05:27 -0700 [thread overview]
Message-ID: <CAD=FV=UarqLwPu6mJ7QU8qXWoaizqMHHbjqF4q=KPYvDZrhT-A@mail.gmail.com> (raw)
In-Reply-To: <20210519054030.3217704-1-swboyd@chromium.org>
Hi,
On Tue, May 18, 2021 at 10:40 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> This spi flash part is actually being clocked at 37.5MHz, not 25MHz,
> because of the way the clk driver is rounding up the rate that is
> requested to the nearest supported frequency. Let's update the frequency
> here, and remove the TODO because this is the fastest frequency we're
> going to be able to use here.
>
> Cc: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 24d293ef56d7..af3c0e1e2223 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -335,8 +335,7 @@ flash@0 {
> compatible = "jedec,spi-nor";
> reg = <0>;
>
> - /* TODO: Increase frequency after testing */
> - spi-max-frequency = <25000000>;
> + spi-max-frequency = <37500000>;
> spi-tx-bus-width = <2>;
> spi-rx-bus-width = <2>;
> };
Thanks. Looks right to me. I confirmed that the clock is 150 MHz in my
"clk_summary" which is 4x 37.5.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
-Doug
next prev parent reply other threads:[~2021-05-19 16:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 5:40 [PATCH] arm64: dts: qcom: sc7180-trogdor: Update flash freq to match reality Stephen Boyd
2021-05-19 16:05 ` Doug Anderson [this message]
2021-06-02 15:51 ` Doug Anderson
2021-06-10 14:50 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=UarqLwPu6mJ7QU8qXWoaizqMHHbjqF4q=KPYvDZrhT-A@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).