From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21920C3F68F for ; Wed, 11 Dec 2019 19:43:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EDC6F2173E for ; Wed, 11 Dec 2019 19:43:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="flsBnhRw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726242AbfLKTnm (ORCPT ); Wed, 11 Dec 2019 14:43:42 -0500 Received: from mail-il1-f194.google.com ([209.85.166.194]:45215 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbfLKTnm (ORCPT ); Wed, 11 Dec 2019 14:43:42 -0500 Received: by mail-il1-f194.google.com with SMTP id p8so20479931iln.12 for ; Wed, 11 Dec 2019 11:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WEsvDQ4frWg0g6hsrfrPUpwL5OB0pB+03rAe/lqxJKs=; b=flsBnhRwZYV3x2jeRLaTFJggFGEUKvXMx7aFjFYS3tsR8jzvWNQoAoI6geow1bE3hH Sm1LHlGve7GLu+f76odVmRz0tXt8hYDqPTJrJRYFvL0aMIGYCHbglAf0y9IBgG5JZcf1 BeLTAaE39MIUTOH4uRNWoLbPm1wDCHD8VhJPg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WEsvDQ4frWg0g6hsrfrPUpwL5OB0pB+03rAe/lqxJKs=; b=hdw3NC6idmgoiDiz4qbblGpPnJblOWSrnnzZcbg9A/Px4RYhRKI4UvEoIFDEAV62OQ gV2e9ufs2vo+IYQKKB7RBGOFYC18Z9TbftJg6JzJSxM1aYSnw9ZgxPPq/e1EBtzRVh5T gSDfQrvE+N9mw4zGycAe+zxDSaHOjmr2hQeILALrAhEeNnCpPulgridNZZ6FCB15Al0o eakzArOlKG9fQ4CBJw3qMDYZ9aAzboP9Yq61ZhnzBd8LOtrTDa5ZOkZ26NzXlI0fWjm2 2vhSlKBiLRoOfPH29Kait812oKACGbRr4Q+YY72XuzivY4IR46AJkOB5jT+IGJ2h7YwA qjLA== X-Gm-Message-State: APjAAAUENbKZ2/HUnCJM7S3kiTSjdP1W5VF12qF+lEvRV4JQqa85FfQd 1EUqaEOIyr/GH0Mcs8fvGkUUe8OB8/4= X-Google-Smtp-Source: APXvYqxc5nTGr+vseWP2EJAZJVowmzOx8DdXaxlqU/h3XqudYejAUH3rhQrpvgJ9gkQjqCNLJtJHig== X-Received: by 2002:a92:5b5b:: with SMTP id p88mr4435367ilb.307.1576093421352; Wed, 11 Dec 2019 11:43:41 -0800 (PST) Received: from mail-il1-f180.google.com (mail-il1-f180.google.com. [209.85.166.180]) by smtp.gmail.com with ESMTPSA id w16sm992075ilq.5.2019.12.11.11.43.40 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Dec 2019 11:43:40 -0800 (PST) Received: by mail-il1-f180.google.com with SMTP id b15so20554433iln.3 for ; Wed, 11 Dec 2019 11:43:40 -0800 (PST) X-Received: by 2002:a92:d581:: with SMTP id a1mr4374504iln.218.1576093420076; Wed, 11 Dec 2019 11:43:40 -0800 (PST) MIME-Version: 1.0 References: <1574940787-1004-1-git-send-email-sanm@codeaurora.org> <1574940787-1004-2-git-send-email-sanm@codeaurora.org> In-Reply-To: <1574940787-1004-2-git-send-email-sanm@codeaurora.org> From: Doug Anderson Date: Wed, 11 Dec 2019 11:43:28 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/3] usb: dwc3: Add support for SC7180 SOC To: Sandeep Maheswaram Cc: Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Mark Rutland , Felipe Balbi , Stephen Boyd , linux-arm-msm , linux-usb@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Thu, Nov 28, 2019 at 3:35 AM Sandeep Maheswaram wrote: > > Add compatible for SC7180 SOC in USB DWC3 driver > > Signed-off-by: Sandeep Maheswaram > --- > drivers/usb/dwc3/dwc3-qcom.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index 261af9e..1df2372 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -1,5 +1,5 @@ > // SPDX-License-Identifier: GPL-2.0 > -/* Copyright (c) 2018, The Linux Foundation. All rights reserved. > +/* Copyright (c) 2018-2019, The Linux Foundation. All rights reserved. > * > * Inspired by dwc3-of-simple.c > */ > @@ -753,6 +753,7 @@ static const struct of_device_id dwc3_qcom_of_match[] = { > { .compatible = "qcom,dwc3" }, > { .compatible = "qcom,msm8996-dwc3" }, > { .compatible = "qcom,msm8998-dwc3" }, > + { .compatible = "qcom,sc7180-dwc3" }, > { .compatible = "qcom,sdm845-dwc3" }, It is, of course, up to Felipe. ...but in my opinion this is the wrong change and instead we should be deleting the SoC-specific strings (msm8996, msm8998, sdm845) from this file because they don't buy us anything. To explain how it works: 1. Device tree should have both the "SoC-specific" and generic "qcom,dwc3" strings. Only the "qcom,dwc3" will actually be used but the SoC-specific string is there so if we find a case later where we need to handle a SoC-specific quirk then it'll already be there. 2. Bindings should have both the "SoC-specific" and generic "qcom,dwc3" strings. The binding is describing what's in the device tree. 3. Until we have a SoC-specific quirk to handle, we _don't_ need to add the SoC-specific string to the driver itself. -Doug