From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BD11C43331 for ; Thu, 2 Apr 2020 22:56:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E91B12073B for ; Thu, 2 Apr 2020 22:56:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="AWWeCU4h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389108AbgDBW42 (ORCPT ); Thu, 2 Apr 2020 18:56:28 -0400 Received: from mail-vk1-f193.google.com ([209.85.221.193]:38317 "EHLO mail-vk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729549AbgDBW42 (ORCPT ); Thu, 2 Apr 2020 18:56:28 -0400 Received: by mail-vk1-f193.google.com with SMTP id n128so1504463vke.5 for ; Thu, 02 Apr 2020 15:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ok4wGTvzCTXydODevfiQEyG5yYpGPlaZ9o6pHHlLTpk=; b=AWWeCU4hDYBU+OF5Y1ceaY6RIGtjixFYMB6CHk1om2doQr/qKmzNCgXSJraZDzZfSR Q3KjibosDCnp2LuIKlLoDoqs0C+fmtZlLp/2UoNaSRGfDjVSvofs9p+Yl6XJbvxIbkoT blGSyQI2wo3Vm9+IiP6WpSEAODiHqUPilerQM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ok4wGTvzCTXydODevfiQEyG5yYpGPlaZ9o6pHHlLTpk=; b=eSoWREI9swTqGaD6qeG8MLYLSTXCJc3TfT7q4GWemfh0symckjZkXZOlqL492fIWDh bD8+TqC83kGJvJI4RYs/lcpeCgxzKFc0Sw7ArjYn0aP00/r34RXJST86MxmsL14KfUAF vRIuEGtZTp9MwnoXfSTFHQ77C7rUW0FVR08rPz6NLkmHOecoS+3a8hAKrzUX0isnwDmO VEEsEZOAxCHbCQXkYHc0yiHl+i0xZ4OLCQ/9nleWJgCJqJGRZY8S2jp0iHSxbH9hA/KI s0Yw7lzLIfa2DQ6X7wz3iDPhVdzZWadFQ0BekqLCJSlDCLpdRj1KLTijgce6wAd5HGV4 NhYA== X-Gm-Message-State: AGi0Pub9tqaG1tJ5DFn0d7CpzDOoOcC88vZirZOCNcsaQ9LQN8xu+qMf 1vn+4dmnIgERG9d/8PWzjyEn7Gj+o2Q= X-Google-Smtp-Source: APiQypJGOmAMUAdIfQbPA7tuuoFA4hc3nYrp3T6RbYhrqJsfuXgvU5E+I4vRMCYnHsm7bVTdLN+U2w== X-Received: by 2002:a1f:93d4:: with SMTP id v203mr4145584vkd.78.1585868187125; Thu, 02 Apr 2020 15:56:27 -0700 (PDT) Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com. [209.85.217.48]) by smtp.gmail.com with ESMTPSA id v4sm1763955vkg.17.2020.04.02.15.56.25 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2020 15:56:26 -0700 (PDT) Received: by mail-vs1-f48.google.com with SMTP id s10so3716716vsi.9 for ; Thu, 02 Apr 2020 15:56:25 -0700 (PDT) X-Received: by 2002:a67:1e46:: with SMTP id e67mr4469905vse.106.1585868185329; Thu, 02 Apr 2020 15:56:25 -0700 (PDT) MIME-Version: 1.0 References: <20200402223723.7150-1-john.stultz@linaro.org> In-Reply-To: <20200402223723.7150-1-john.stultz@linaro.org> From: Doug Anderson Date: Thu, 2 Apr 2020 15:56:14 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] phy: qcom-qusb2: Re add "qcom,sdm845-qusb2-phy" compat string To: John Stultz Cc: lkml , Andy Gross , Bjorn Andersson , Rob Herring , Mark Rutland , Manu Gautam , Sandeep Maheswaram , Matthias Kaehlcke , Stephen Boyd , Kishon Vijay Abraham I , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Thu, Apr 2, 2020 at 3:37 PM John Stultz wrote: > > In commit 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 > PHY support"), the change was made to add "qcom,qusb2-v2-phy" > as a generic compat string. However the change also removed > the "qcom,sdm845-qusb2-phy" compat string, which is documented > in the binding and already in use. > > This patch re-adds the "qcom,sdm845-qusb2-phy" compat string > which allows the driver to continue to work with existing dts > entries such as found on the db845c. > > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Rob Herring > Cc: Mark Rutland > Cc: Doug Anderson > Cc: Manu Gautam > Cc: Sandeep Maheswaram > Cc: Matthias Kaehlcke > Cc: Stephen Boyd > Cc: Kishon Vijay Abraham I > Cc: linux-arm-msm@vger.kernel.org > Cc: devicetree@vger.kernel.org > Fixes: 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 PHY support") > Reported-by: YongQin Liu > Signed-off-by: John Stultz > --- > drivers/phy/qualcomm/phy-qcom-qusb2.c | 3 +++ > 1 file changed, 3 insertions(+) Do you have an out-of-tree dts file? If not, I'd prefer that the fix was for this patch to land instead: https://lore.kernel.org/r/1583747589-17267-9-git-send-email-sanm@codeaurora.org While we can land your patch if someone needs it for supporting an out-of-tree dts, it gives people supporting future SoCs the idea that they need to add themselves to this table too. That's now discouraged unless there's a specific quirk that needs to be handled just for this SoC. -Doug