From: Doug Anderson <dianders@chromium.org>
To: Maulik Shah <mkshah@codeaurora.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Evan Green <evgreen@chromium.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Lina Iyer <ilina@codeaurora.org>,
lsrao@codeaurora.org, Taniya Das <tdas@codeaurora.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
Kiran Gunda <kgunda@codeaurora.org>,
Sibi Sankar <sibis@codeaurora.org>
Subject: Re: [PATCH v13 5/5] drivers: qcom: Update rpmh clients to use start and end transactions
Date: Wed, 11 Mar 2020 16:02:49 -0700 [thread overview]
Message-ID: <CAD=FV=VJz4P_XC4S=dGb+0EyKm3dMOT69VFQPvKA6S5-LEGQwg@mail.gmail.com> (raw)
In-Reply-To: <1583746236-13325-6-git-send-email-mkshah@codeaurora.org>
Hi,
On Mon, Mar 9, 2020 at 2:31 AM Maulik Shah <mkshah@codeaurora.org> wrote:
>
> --- a/drivers/interconnect/qcom/bcm-voter.c
> +++ b/drivers/interconnect/qcom/bcm-voter.c
> @@ -263,7 +263,9 @@ int qcom_icc_bcm_voter_commit(struct bcm_voter *voter)
> tcs_list_gen(&voter->commit_list, QCOM_ICC_BUCKET_AMC, cmds, commit_idx);
>
> if (!commit_idx[0])
> - goto out;
> + goto end;
> +
> + rpmh_start_transaction(voter-dev);
>
> ret = rpmh_invalidate(voter->dev);
> if (ret) {
> @@ -312,12 +314,15 @@ int qcom_icc_bcm_voter_commit(struct bcm_voter *voter)
> tcs_list_gen(&voter->commit_list, QCOM_ICC_BUCKET_SLEEP, cmds, commit_idx);
>
> ret = rpmh_write_batch(voter->dev, RPMH_SLEEP_STATE, cmds, commit_idx);
> - if (ret) {
> + if (ret)
> pr_err("Error sending SLEEP RPMH requests (%d)\n", ret);
> - goto out;
> - }
>
> out:
> + ret = rpmh_end_transaction(voter-dev);
One last note is that your code doesn't actually compile for me since
you need "voter->dev" here (and in the start case), not "voter-dev".
-Doug
next prev parent reply other threads:[~2020-03-11 23:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 9:30 [PATCH v13 0/4] Invoke rpmh_flush for non OSI targets Maulik Shah
2020-03-09 9:30 ` [PATCH v13 1/5] arm64: dts: qcom: sc7180: Add cpuidle low power states Maulik Shah
2020-03-09 9:30 ` [PATCH v13 2/5] soc: qcom: rpmh: Update dirty flag only when data changes Maulik Shah
2020-03-09 23:42 ` Doug Anderson
2020-03-13 8:53 ` Maulik Shah
2020-03-09 9:30 ` [PATCH v13 3/5] soc: qcom: rpmh: Invalidate SLEEP and WAKE TCSes before flushing new data Maulik Shah
2020-03-09 23:42 ` Doug Anderson
2020-03-10 11:09 ` Maulik Shah
2020-03-09 9:30 ` [PATCH v13 4/5] soc: qcom: rpmh: Invoke rpmh_flush() for dirty caches Maulik Shah
2020-03-09 23:43 ` Doug Anderson
2020-03-10 11:19 ` Maulik Shah
2020-03-10 15:46 ` Doug Anderson
2020-03-11 6:36 ` Maulik Shah
2020-03-11 23:06 ` Doug Anderson
[not found] ` <5a5274ac-41f4-b06d-ff49-c00cef67aa7f@codeaurora.org>
2020-03-12 15:11 ` Doug Anderson
2020-03-25 17:15 ` Maulik Shah
2020-03-26 18:08 ` Doug Anderson
2020-03-09 9:30 ` [PATCH v13 5/5] drivers: qcom: Update rpmh clients to use start and end transactions Maulik Shah
2020-03-09 23:44 ` Doug Anderson
2020-03-10 11:46 ` Maulik Shah
2020-03-10 15:46 ` Doug Anderson
2020-03-11 23:02 ` Doug Anderson [this message]
2020-03-09 23:42 ` [PATCH v13 0/4] Invoke rpmh_flush for non OSI targets Doug Anderson
2020-03-10 11:49 ` Maulik Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VJz4P_XC4S=dGb+0EyKm3dMOT69VFQPvKA6S5-LEGQwg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=okukatla@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).