From: Doug Anderson <dianders@chromium.org>
To: Doug Anderson <dianders@chromium.org>,
Sharat Masetty <smasetty@codeaurora.org>,
freedreno <freedreno@lists.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
dri-devel@freedesktop.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Matthias Kaehlcke <mka@chromium.org>,
Rob Clark <robdclark@chromium.org>,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7180: Add A618 gpu dt blob
Date: Fri, 31 Jan 2020 13:21:07 -0800 [thread overview]
Message-ID: <CAD=FV=VLGPd4jiq8ELqaaC68S6-Fs=FXov1VOMQtAtfzOR+w5A@mail.gmail.com> (raw)
In-Reply-To: <20200131211813.GA16531@jcrouse1-lnx.qualcomm.com>
Hi,
On Fri, Jan 31, 2020 at 1:18 PM Jordan Crouse <jcrouse@codeaurora.org> wrote:
>
> On Fri, Jan 31, 2020 at 08:08:09AM -0800, Doug Anderson wrote:
> > Hi,
> >
> > On Fri, Jan 31, 2020 at 4:16 AM <smasetty@codeaurora.org> wrote:
> > >
> > > >> + reg = <0 0x0506a000 0 0x31000>, <0 0x0b290000
> > > >> 0 0x10000>,
> > > >> + <0 0x0b490000 0 0x10000>;
> > > >> + reg-names = "gmu", "gmu_pdc", "gmu_pdc_seq";
> > > >> + interrupts = <GIC_SPI 304
> > > >> IRQ_TYPE_LEVEL_HIGH>,
> > > >> + <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>;
> > > >> + interrupt-names = "hfi", "gmu";
> > > >> + clocks = <&gpucc GPU_CC_CX_GMU_CLK>,
> > > >> + <&gpucc GPU_CC_CXO_CLK>,
> > > >> + <&gcc GCC_DDRSS_GPU_AXI_CLK>,
> > > >> + <&gcc GCC_GPU_MEMNOC_GFX_CLK>;
> > > >> + clock-names = "gmu", "cxo", "axi", "memnoc";
> > > >> + power-domains = <&gpucc CX_GDSC>;
> > > >
> > > > Bindings claim that you need both CX and GC. Is sc7180 somehow
> > > > different? Bindings also claim that you should be providing
> > > > power-domain-names.
> > > No this is still needed, We need the GX power domain for GPU recovery
> > > use cases where the shutdown was not successful.
> >
> > This almost sounds as if the bindings should mark the GX power domain
> > as optional? The driver can function without it but doesn't get all
> > the features? As the binding is written right now I think it is
> > "invalid" to not specify a a GX power domain and once the yaml
> > conversion is done then it will even be flagged as an error. That's
> > going to make it harder to land the your patch...
>
> For GMU attached targets the GX power domain is mandatory assuming you want to
> recover successfully from a hard GMU hang, that is.
Sure. I guess we can quibble about whether this means optional or
mandatory, but it won't gain much. ;-)
...seems like for now (assuming it works) we should at least specify
it and put a <0>. Then we should make it a relatively high priority
to get it hooked up more properly.
-Doug
prev parent reply other threads:[~2020-01-31 21:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 9:29 [PATCH v2] arm64: dts: qcom: sc7180: Add A618 gpu dt blob Sharat Masetty
2020-01-27 22:29 ` Doug Anderson
2020-01-28 15:35 ` Jordan Crouse
2020-01-31 12:16 ` smasetty
2020-01-31 16:08 ` Doug Anderson
2020-01-31 21:18 ` Jordan Crouse
2020-01-31 21:21 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VLGPd4jiq8ELqaaC68S6-Fs=FXov1VOMQtAtfzOR+w5A@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robdclark@chromium.org \
--cc=smasetty@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).