From: Doug Anderson <dianders@chromium.org>
To: Maulik Shah <mkshah@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Matthias Kaehlcke <mka@chromium.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Evan Green <evgreen@chromium.org>,
Lina Iyer <ilina@codeaurora.org>,
Stephen Boyd <swboyd@chromium.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFT PATCH v2 06/10] drivers: qcom: rpmh-rsc: Comment tcs_is_free() + warn if state mismatch
Date: Thu, 2 Apr 2020 13:19:11 -0700 [thread overview]
Message-ID: <CAD=FV=VVArTaPqaWJJ9ONF5p+fg6c-ZiWUtdpqy4U96Ee-Pn9A@mail.gmail.com> (raw)
In-Reply-To: <7a6edff1-3916-e802-0441-25b31989619f@codeaurora.org>
Hi,
On Wed, Apr 1, 2020 at 4:39 AM Maulik Shah <mkshah@codeaurora.org> wrote:
>
> Hi,
>
> On 3/12/2020 4:43 AM, Douglas Anderson wrote:
> > tcs_is_free() had two checks in it: does the software think that the
> > TCS is free and does the hardware think that the TCS is free. Let's
> > comment this and also add a warning in the case that software and
> > hardware disagree, at least for ACTIVE_ONLY TCS.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
> > ---
> >
> > Changes in v2:
> > - Comment tcs_is_free() new for v2; replaces old patch 6.
> >
> > drivers/soc/qcom/rpmh-rsc.c | 23 +++++++++++++++++++++--
> > 1 file changed, 21 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> > index 9d2669cbd994..93f5d1fb71ca 100644
> > --- a/drivers/soc/qcom/rpmh-rsc.c
> > +++ b/drivers/soc/qcom/rpmh-rsc.c
> > @@ -181,8 +181,27 @@ static void write_tcs_reg_sync(struct rsc_drv *drv, int reg, int tcs_id,
> > */
> > static bool tcs_is_free(struct rsc_drv *drv, int tcs_id)
> > {
> > - return !test_bit(tcs_id, drv->tcs_in_use) &&
> > - read_tcs_reg(drv, RSC_DRV_STATUS, tcs_id);
> > + /* If software thinks it's in use then it's definitely in use */
> > + if (test_bit(tcs_id, drv->tcs_in_use))
> > + return false;
> > +
> > + /* If hardware agrees it's free then it's definitely free */
> > + if (read_tcs_reg(drv, RSC_DRV_STATUS, tcs_id) != 0)
> > + return true;
> > +
> > + /*
> > + * If we're here then software and hardware disagree about whether
> > + * the TCS is free. Software thinks it is free and hardware thinks
> > + * it is not.
> > + *
> > + * Maybe this should be a warning in all cases, but it's almost
> > + * certainly a warning for the ACTIVE_TCS where nobody else should
> > + * be doing anything else behind our backs. For now we'll just
> > + * warn there and then still return that we're in use.
> > + */
> > + WARN(drv->tcs[tcs_id].type == ACTIVE_TCS,
> > + "Driver thought TCS was free but HW reported busy\n");
> This warning can come for borrowed WAKE_TCS as well.
> > + return false;
> > }
>
> We have a patch on downstream variant to optimize this by only checking
> tcs_in_use flag (SW check) and HW check is removed.
>
> static bool tcs_is_free(struct rsc_drv *drv, int tcs_id)
> {
> - return !test_bit(tcs_id, drv->tcs_in_use) &&
> - read_tcs_reg(drv, RSC_DRV_STATUS, tcs_id, 0);
> + return !test_bit(tcs_id, drv->tcs_in_use);
> }
>
> With this we are good and don't require to put above warning as well.
>
> if you want me to upload, i can post it and then you can drop this
> change from your series.
>
> Or if you want to modify it as above and keep in this series i am ok.
Probably easiest for me to replace this patch in the series with one
that removes the read from RSC_DRV_STATUS. Then it will all be
clearer.
next prev parent reply other threads:[~2020-04-02 20:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 23:13 [RFT PATCH v2 00/10] drivers: qcom: rpmh-rsc: Cleanup / add lots of comments Douglas Anderson
2020-03-11 23:13 ` [RFT PATCH v2 01/10] drivers: qcom: rpmh-rsc: Clean code reading/writing regs/cmds Douglas Anderson
2020-04-01 8:12 ` Maulik Shah
2020-03-11 23:13 ` [RFT PATCH v2 02/10] drivers: qcom: rpmh-rsc: Document the register layout better Douglas Anderson
2020-04-01 8:14 ` Maulik Shah
2020-04-02 20:15 ` Doug Anderson
2020-03-11 23:13 ` [RFT PATCH v2 03/10] drivers: qcom: rpmh-rsc: Fold tcs_ctrl_write() into its single caller Douglas Anderson
2020-04-01 8:17 ` Maulik Shah
2020-03-11 23:13 ` [RFT PATCH v2 04/10] drivers: qcom: rpmh-rsc: Remove get_tcs_of_type() abstraction Douglas Anderson
2020-04-01 8:18 ` Maulik Shah
2020-03-11 23:13 ` [RFT PATCH v2 05/10] drivers: qcom: rpmh-rsc: A lot of comments Douglas Anderson
2020-04-01 11:29 ` Maulik Shah
2020-04-02 20:18 ` Doug Anderson
2020-04-08 11:10 ` Maulik Shah
2020-03-11 23:13 ` [RFT PATCH v2 06/10] drivers: qcom: rpmh-rsc: Comment tcs_is_free() + warn if state mismatch Douglas Anderson
2020-04-01 11:38 ` Maulik Shah
2020-04-02 20:19 ` Doug Anderson [this message]
2020-03-11 23:13 ` [RFT PATCH v2 07/10] drivers: qcom: rpmh-rsc: Warning if tcs_write() used for non-active Douglas Anderson
2020-04-01 12:40 ` Maulik Shah
2020-04-02 20:19 ` Doug Anderson
2020-03-11 23:13 ` [RFT PATCH v2 08/10] drivers: qcom: rpmh-rsc: spin_lock_irqsave() for tcs_invalidate() Douglas Anderson
2020-03-26 21:44 ` Doug Anderson
2020-03-11 23:13 ` [RFT PATCH v2 09/10] drivers: qcom: rpmh-rsc: Kill cmd_cache and find_match() with fire Douglas Anderson
2020-03-11 23:13 ` [RFT PATCH v2 10/10] drivers: qcom: rpmh-rsc: Always use -EAGAIN, never -EBUSY Douglas Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VVArTaPqaWJJ9ONF5p+fg6c-ZiWUtdpqy4U96Ee-Pn9A@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).