linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Alexandru M Stan <amstan@chromium.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Rob Clark <robdclark@chromium.org>,
	Gwendal Grignou <gwendal@chromium.org>,
	Tzung-Bi Shih <tzungbi@chromium.org>,
	Judy Hsiao <judyhsiao@chromium.org>,
	Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus
Date: Fri, 26 Feb 2021 16:55:37 -0800	[thread overview]
Message-ID: <CAD=FV=VY3V=8ii+E_Yva3i-HngKwFj9u8W_6pkLe-c2gG0Oz3A@mail.gmail.com> (raw)
In-Reply-To: <161436510419.1254594.15131518424468767659@swboyd.mtv.corp.google.com>

Hi,

On Fri, Feb 26, 2021 at 10:45 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Douglas Anderson (2021-02-25 14:13:10)
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > new file mode 100644
> > index 000000000000..5def9953d82b
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz.dtsi
> > @@ -0,0 +1,249 @@
> [...]
> > +
> > +/*
> > + * There's no SAR sensor, so i2c5 is re-purposed.  We leave the
> > + * proximity@28 node under i2c5 (from trogdor.dtsi) since it's "disabled"
> > + * and doesn't hurt.
> > + */
> > +i2c_wlc: &i2c5 {
> > +       /* Currently not connected to anything; see b/168652326 */
> > +};
>
> Can we remove this? As far as I know this will always be this way and
> thus doesn't provide anything meaningful to leave this bug comment here
> that doesn't work for people.

Yeah, that sounds good.  We just want to delete this whole comment and the node.

That seems like enough reason to repost the series.  I'll plan to do
it early next week.  Of course, I wouldn't object to any of these
things:
* This patch landing and having the node and I'll do a follow-up patch
to remove it.
* Bjorn removing the comment and node as he applies.

-Doug

      reply	other threads:[~2021-02-27  0:56 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25 22:12 [PATCH 00/13] arm64: dts: qcom: Update sc7180-trogdor variants from downstream Douglas Anderson
2021-02-25 22:12 ` [PATCH 01/13] arm64: dts: qcom: sc7180: Update dts for DP phy inside QMP phy Douglas Anderson
2021-03-14  0:28   ` Dmitry Baryshkov
2021-03-15 17:40     ` Doug Anderson
2021-02-25 22:12 ` [PATCH 02/13] arm64: dts: qcom: Move sc7180 MI2S config to board files and make pulldown Douglas Anderson
2021-02-25 22:55   ` Konrad Dybcio
2021-02-25 22:57     ` Doug Anderson
2021-02-25 23:07       ` Konrad Dybcio
2021-02-25 23:48   ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 03/13] arm64: dts: qcom: Prep sc7180-trogdor trackpad IRQ for new boards Douglas Anderson
2021-02-25 23:54   ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 04/13] arm64: dts: qcom: Unify the sc7180-trogdor panel nodes Douglas Anderson
2021-02-25 23:58   ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 05/13] arm64: dts: qcom: trogdor: Only wakeup from pen eject Douglas Anderson
2021-02-26  0:02   ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 06/13] arm64: dts: qcom: Disable camera clk on sc7180-trogdor devices by default Douglas Anderson
2021-02-26  0:06   ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 07/13] arm64: dts: qcom: sc7180-trogdor: Remove fp control pins in prep for coachz Douglas Anderson
2021-02-26  0:14   ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 08/13] arm64: dts: qcom: sc7180: Remove clock for bluetooth on Trogdor Douglas Anderson
2021-02-26  0:19   ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 09/13] arm64: dts: qcom: sc7180: add GO_LAZOR variant property for lazor Douglas Anderson
2021-02-26  0:25   ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 10/13] arm64: dts: qcom: sc7180: Set up lazor r3+ as sc7180-lite SKUs Douglas Anderson
2021-02-25 22:13 ` [PATCH 11/13] arm64: dts: qcom: Add sc7180-lazor-limozeen skus Douglas Anderson
2021-02-26  0:40   ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 12/13] arm64: dts: qcom: Add sc7180-lazor-pompom skus Douglas Anderson
2021-02-25 22:25   ` Doug Anderson
2021-02-26  2:13   ` Matthias Kaehlcke
2021-02-25 22:13 ` [PATCH 13/13] arm64: dts: qcom: Add sc7180-lazor-coachz skus Douglas Anderson
2021-02-26 17:14   ` Matthias Kaehlcke
2021-02-26 18:45   ` Stephen Boyd
2021-02-27  0:55     ` Doug Anderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAD=FV=VY3V=8ii+E_Yva3i-HngKwFj9u8W_6pkLe-c2gG0Oz3A@mail.gmail.com' \
    --to=dianders@chromium.org \
    --cc=agross@kernel.org \
    --cc=amstan@chromium.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gwendal@chromium.org \
    --cc=judyhsiao@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=robdclark@chromium.org \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    --cc=tzungbi@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).