From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6FD3C07E99 for ; Fri, 9 Jul 2021 22:38:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8AB6613BF for ; Fri, 9 Jul 2021 22:38:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229792AbhGIWlH (ORCPT ); Fri, 9 Jul 2021 18:41:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbhGIWlG (ORCPT ); Fri, 9 Jul 2021 18:41:06 -0400 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E655EC0613DD for ; Fri, 9 Jul 2021 15:38:21 -0700 (PDT) Received: by mail-qk1-x731.google.com with SMTP id 14so11185255qkh.0 for ; Fri, 09 Jul 2021 15:38:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=in4kX7sLTOvzGIkTNM27VoAm2lJJuZoW6Y2T2jtB9og=; b=hszLVAfastfyWky57gCrlZ/WcIVeDaPB73el6QR1RDtWzS2BSVi5iqH/MQAzIHxy9k pHW1JsuN2pCSrLkXKRkr++6Pme3Qy33J8zG25hrOIwCdJkxlunSag78fgccRAvjjFmtz P3mWNoFQitYr6cojWimJYGR8YaL3h6x/XYMAU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=in4kX7sLTOvzGIkTNM27VoAm2lJJuZoW6Y2T2jtB9og=; b=d8OLLjz8fqTJr0jEClgbBWJtLMli5AUppzLKHJGCGeP4GeZjCtq6nNtQ9xEpilJyts erTClsAiORi5XLBzS5njapJTyaOgZTswMGynBaRMfpPHYd8OK4gk5zW2TjlA/ZImB2M0 ujn7kKbzMHlirvZbm8P1+J2CBGysM3PTfG4eZSq265g0Jb0UkBcM+WXvcdYiNB0TUH8g M99DHdC9/BDzAccjS05Nbw+LI6u68+rzV49e65aA/zQkFZMEqwy50nO6ZUl3t42bl2sW qHQOR6meylOOqEHmXaulAu+rF1aO3bTcAF3dj36bjOKeguSF9EoXHtITEhnRJOgoXYD/ D55A== X-Gm-Message-State: AOAM531XVW9YQC2tQUxPbGzsrS2/11gvCh+PR18oHriVL7oJKRJCN0Yf IUnPdzH9JsFAjnLRcoj4td2gWJ8Swl76+g== X-Google-Smtp-Source: ABdhPJzFZcnA2G3/MV6r0Igi42ocoyG/VLfdQu8WAyZljS6gw0M+fY4zxp3sj/OW/+FS9+u1ZDCh5g== X-Received: by 2002:a05:620a:14b5:: with SMTP id x21mr3010132qkj.148.1625870301046; Fri, 09 Jul 2021 15:38:21 -0700 (PDT) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com. [209.85.219.175]) by smtp.gmail.com with ESMTPSA id n64sm3105658qkd.79.2021.07.09.15.38.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Jul 2021 15:38:20 -0700 (PDT) Received: by mail-yb1-f175.google.com with SMTP id k184so16851544ybf.12 for ; Fri, 09 Jul 2021 15:38:20 -0700 (PDT) X-Received: by 2002:a25:60c1:: with SMTP id u184mr49707810ybb.343.1625869916303; Fri, 09 Jul 2021 15:31:56 -0700 (PDT) MIME-Version: 1.0 References: <1624726268-14869-1-git-send-email-rajeevny@codeaurora.org> In-Reply-To: From: Doug Anderson Date: Fri, 9 Jul 2021 15:31:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v8 0/6] drm: Support basic DPCD backlight in panel-simple and add a new panel ATNA33XC20 To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Rajeev Nandan , linux-fbdev@vger.kernel.org, dri-devel , Andrzej Hajda , Thierry Reding , Laurent Pinchart , "Kristian H. Kristensen" , Sam Ravnborg , Daniel Thompson , Lee Jones , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jani Nikula , linux-arm-msm , Abhinav Kumar , Sean Paul , Kalyan Thota , Krishna Manikandan , Jingoo Han , LKML , freedreno Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Fri, Jul 9, 2021 at 1:41 PM Ville Syrj=C3=A4l=C3=A4 wrote: > > On Fri, Jul 09, 2021 at 06:54:05AM -0700, Doug Anderson wrote: > > Hi, > > > > On Sat, Jun 26, 2021 at 9:52 AM Rajeev Nandan = wrote: > > > > > > This series adds the support for the eDP panel that needs the backlig= ht > > > controlling over the DP AUX channel using DPCD registers of the panel > > > as per the VESA's standard. > > > > > > This series also adds support for the Samsung eDP AMOLED panel that > > > needs DP AUX to control the backlight, and introduces new delays in t= he > > > @panel_desc.delay to support this panel. > > > > > > This patch series depends on the following two series: > > > - Doug's series [1], exposed the DP AUX channel to the panel-simple. > > > - Lyude's series [2], introduced new drm helper functions for DPCD > > > backlight. > > > > > > This series is the logical successor to the series [3]. > > > > > > Changes in v1: > > > - Created dpcd backlight helper with very basic functionality, added > > > backlight registration in the ti-sn65dsi86 bridge driver. > > > > > > Changes in v2: > > > - Created a new DisplayPort aux backlight driver and moved the code f= rom > > > drm_dp_aux_backlight.c (v1) to the new driver. > > > > > > Changes in v3: > > > - Fixed module compilation (kernel test bot). > > > > > > Changes in v4: > > > - Added basic DPCD backlight support in panel-simple. > > > - Added support for a new Samsung panel ATNA33XC20 that needs DPCD > > > backlight controlling and has a requirement of delays between enabl= e > > > GPIO and regulator. > > > > > > Changes in v5: > > > Addressed review suggestions from Douglas: > > > - Created a new API drm_panel_dp_aux_backlight() in drm_panel.c > > > - Moved DP AUX backlight functions from panel-simple.c to drm_panel.c > > > - panel-simple probe() calls drm_panel_dp_aux_backlight() to create > > > backlight when the backlight phandle is not specified in panel DT > > > and DP AUX channel is present. > > > - Added check for drm_edp_backlight_supported() before registering. > > > - Removed the @uses_dpcd_backlight flag from panel_desc as this > > > should be auto-detected. > > > - Updated comments/descriptions. > > > > > > Changes in v6: > > > - Rebased > > > - Updated wanrning messages, fixed word wrapping in comments. > > > - Fixed ordering of memory allocation > > > > > > Changes in v7: > > > - Updated the disable_to_power_off and power_to_enable panel delays > > > as discovered at (Douglas) > > > > > > Changes in v8: > > > - Now using backlight_is_blank() to get the backlight blank status (S= am Ravnborg) > > > - Added a new patch #4 to fix the warnings for eDP panel description = (Sam Ravnborg) > > > > > > [1] https://lore.kernel.org/dri-devel/20210525000159.3384921-1-diande= rs@chromium.org/ > > > [2] https://lore.kernel.org/dri-devel/20210514181504.565252-1-lyude@r= edhat.com/ > > > [3] https://lore.kernel.org/dri-devel/1619416756-3533-1-git-send-emai= l-rajeevny@codeaurora.org/ > > > > > > Rajeev Nandan (6): > > > drm/panel: add basic DP AUX backlight support > > > drm/panel-simple: Support DP AUX backlight > > > drm/panel-simple: Support for delays between GPIO & regulator > > > drm/panel-simple: Update validation warnings for eDP panel descript= ion > > > dt-bindings: display: simple: Add Samsung ATNA33XC20 > > > drm/panel-simple: Add Samsung ATNA33XC20 > > > > > > .../bindings/display/panel/panel-simple.yaml | 2 + > > > drivers/gpu/drm/drm_panel.c | 108 +++++++++++= ++++++++++ > > > drivers/gpu/drm/panel/panel-simple.c | 73 +++++++++++= ++- > > > include/drm/drm_panel.h | 15 ++- > > > 4 files changed, 190 insertions(+), 8 deletions(-) > > > > Pushed to drm-misc-next. > > > > 4bfe6c8f7c23 drm/panel-simple: Add Samsung ATNA33XC20 > > c20dec193584 dt-bindings: display: simple: Add Samsung ATNA33XC20 > > 13aceea56fd5 drm/panel-simple: Update validation warnings for eDP > > panel description > > 18a1488bf1e1 drm/panel-simple: Support for delays between GPIO & regula= tor > > bfd451403d70 drm/panel-simple: Support DP AUX backlight > > 10f7b40e4f30 drm/panel: add basic DP AUX backlight support > > depmod: ERROR: Cycle detected: drm_kms_helper -> drm -> drm_kms_helper > > Looks to be due to drm_edp_backlight_enable(). Ugh. Thanks for the report! I've taken a schwag at a fix here: https://lore.kernel.org/lkml/20210709152909.1.I23eb4cc5a680341e7b3e791632a6= 35566fa5806a@changeid/ -Doug