From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Srinivasa Rao Mandadapu <srivasam@qti.qualcomm.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Judy Hsiao <judyhsiao@chromium.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Rohit kumar <rohitkr@codeaurora.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
V Sujith Kumar Reddy <vsujithk@codeaurora.org>
Subject: Re: [PATCH v4 2/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI
Date: Wed, 11 Aug 2021 15:10:09 -0700 [thread overview]
Message-ID: <CAD=FV=VgwLNiAZKur7PPpB=_mOnZrkBa2cG1DZYsCxQRAd42NA@mail.gmail.com> (raw)
In-Reply-To: <CAE-0n52hdv0ehzQi2si3rPumBiO+=stoU3kkK=0e7fU_5+xUZw@mail.gmail.com>
Hi,
On Tue, Aug 10, 2021 at 11:06 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Srinivasa Rao Mandadapu (2021-07-21 01:05:49)
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > index 31bf7c698b8f..a4cb9ee567ff 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > @@ -288,6 +288,7 @@ sound: sound {
> > "Headphone Jack", "HPOL",
> > "Headphone Jack", "HPOR";
> >
> > + #sound-dai-cells = <0>;
> > #address-cells = <1>;
> > #size-cells = <0>;
> >
> > @@ -314,6 +315,18 @@ sound_multimedia1_codec: codec {
> > sound-dai = <&max98357a>;
> > };
> > };
> > +
> > + dai-link@2 {
> > + link-name = "MultiMedia2";
> > + reg = <2>;
>
> Should this be
>
> reg = <LPASS_DP_RX>;
>
> ? And then the dai-link@2 should change to dai-link@5? It doesn't seem
> to really matter though, so maybe not.
>
> > + cpu {
> > + sound-dai = <&lpass_cpu 2>;
>
> This should be
>
> sound-dai = <&lpass_cpu LPASS_DP_RX>;
>
> ? At least from what I can tell without having it be 5 it doesn't work
> properly and external audio over DP doesn't enumerate.
I swear I provided feedback just like that. Yeah, here:
https://lore.kernel.org/r/CAD=FV=W3X8W90vPdrDAymzTKj-J7QPyn4ukaLSOhEkCme3+r_Q@mail.gmail.com
I think the problem is that the wrong patch landed. The one I see that
landed last week was v4 but I also see v7 of the same patch:
https://lore.kernel.org/r/20210726120910.20335-3-srivasam@codeaurora.org/
next prev parent reply other threads:[~2021-08-11 22:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 8:05 [PATCH v4 0/2] Qualcomm's lpass device tree changes Srinivasa Rao Mandadapu
2021-07-21 8:05 ` [PATCH v4 1/2] arm64: dts: qcom: sc7180: Update lpass cpu node for audio over dp Srinivasa Rao Mandadapu
2021-07-21 8:05 ` [PATCH v4 2/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI Srinivasa Rao Mandadapu
2021-08-11 6:06 ` Stephen Boyd
2021-08-11 22:10 ` Doug Anderson [this message]
2021-08-11 22:20 ` Stephen Boyd
2021-07-21 8:30 [PATCH v4 0/2] Qualcomm's lpass device tree changes Srinivasa Rao Mandadapu
2021-07-21 8:30 ` [PATCH v4 2/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VgwLNiAZKur7PPpB=_mOnZrkBa2cG1DZYsCxQRAd42NA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=srivasam@qti.qualcomm.com \
--cc=swboyd@chromium.org \
--cc=vsujithk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).