From: Doug Anderson <dianders@chromium.org>
To: Maulik Shah <mkshah@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
Marc Zyngier <maz@kernel.org>, LinusW <linus.walleij@linaro.org>,
Stephen Boyd <swboyd@chromium.org>,
Evan Green <evgreen@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Andy Gross <agross@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Rajendra Nayak <rnayak@codeaurora.org>,
Lina Iyer <ilina@codeaurora.org>,
Srinivas Rao L <lsrao@codeaurora.org>
Subject: Re: [PATCH v6 3/6] genirq/PM: Introduce IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND flag
Date: Mon, 28 Sep 2020 14:12:46 -0700 [thread overview]
Message-ID: <CAD=FV=VqkgWTrGLrUMdBWGD8_wd4yMr+e6U-xCxFg4B2LfhTRw@mail.gmail.com> (raw)
In-Reply-To: <1601267524-20199-4-git-send-email-mkshah@codeaurora.org>
Hi,
On Sun, Sep 27, 2020 at 9:32 PM Maulik Shah <mkshah@codeaurora.org> wrote:
>
> An interrupt that is disabled/masked but set for wakeup still needs to
> be able to wake up the system from sleep states like "suspend to RAM".
>
> This change introduces IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND flag. If irqchip
> have this flag set then irq PM will enable/unmask irqs that are marked
> for wakeup but are in disabled state.
>
> On resume such irqs will be restored back to disabled state.
>
> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> ---
> include/linux/irq.h | 49 ++++++++++++++++++++++++++++++-------------------
> kernel/irq/debugfs.c | 3 +++
> kernel/irq/pm.c | 34 ++++++++++++++++++++++++++++++----
> 3 files changed, 63 insertions(+), 23 deletions(-)
I will freely admit not being an expert on this code / knowing all the
subtle edge conditions, but this seems reasonable to me.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2020-09-28 21:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 4:31 [PATCH v6 0/6] irqchip: qcom: pdc: Introduce irq_set_wake call Maulik Shah
2020-09-28 4:31 ` [PATCH v6 1/6] pinctrl: qcom: Set IRQCHIP_SET_TYPE_MASKED and IRQCHIP_MASK_ON_SUSPEND flags Maulik Shah
2020-09-28 4:32 ` [PATCH v6 2/6] pinctrl: qcom: Use return value from irq_set_wake() call Maulik Shah
2020-09-28 4:32 ` [PATCH v6 3/6] genirq/PM: Introduce IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND flag Maulik Shah
2020-09-28 21:12 ` Doug Anderson [this message]
2020-09-29 20:18 ` Thomas Gleixner
2020-09-28 4:32 ` [PATCH v6 4/6] pinctrl: qcom: Set " Maulik Shah
2020-09-28 4:32 ` [PATCH v6 5/6] irqchip: qcom-pdc: " Maulik Shah
2020-09-28 4:32 ` [PATCH v6 6/6] irqchip: qcom-pdc: Reset PDC interrupts during init Maulik Shah
2020-10-01 8:13 ` [PATCH v6 0/6] irqchip: qcom: pdc: Introduce irq_set_wake call Stephen Boyd
2020-10-06 10:29 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VqkgWTrGLrUMdBWGD8_wd4yMr+e6U-xCxFg4B2LfhTRw@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=maz@kernel.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).