From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 536BFC433B4 for ; Mon, 3 May 2021 20:41:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D8E5611EE for ; Mon, 3 May 2021 20:41:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229596AbhECUmQ (ORCPT ); Mon, 3 May 2021 16:42:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229594AbhECUmN (ORCPT ); Mon, 3 May 2021 16:42:13 -0400 Received: from mail-vs1-xe35.google.com (mail-vs1-xe35.google.com [IPv6:2607:f8b0:4864:20::e35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B09FEC061761 for ; Mon, 3 May 2021 13:41:19 -0700 (PDT) Received: by mail-vs1-xe35.google.com with SMTP id 66so3629882vsk.9 for ; Mon, 03 May 2021 13:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BVEWhYBD+xtNsbo3lAuegOEINH/TnK8x6KkSQvrHSkc=; b=maWCCqkx0oH1zSZ/q/GRT9vao0fkAFsVj063WxGPB1qM8s/UjGnuJdKNRT6bMP4kiw L4+J9CU69hnWD+bOSoUADl1jrTF4/psQ7Di/8qRinh3NO5KHgbf6pU9EjtVGOwIETAec L/cXPywRZw9M6rUEbphDnPpsXBS7J0droG0iU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BVEWhYBD+xtNsbo3lAuegOEINH/TnK8x6KkSQvrHSkc=; b=CsR+3n9OSljJRoaythxSi4ivSq8lliGkJKnuV8PMW9gcdXr15RYVwNJtTwmzNN0Deg KPs7TZZ3Ef/qMMPYweGOSQc5Sm3RSzC75BKvtHyZORPKoMPIEsk1j7fjfh6Ia6jEUpJS IElB0oIR216tx2ndJmC+0efZW6hg/5i4Dy0LbdAJQLb10IfNKwf7QYSbvpYaJcUgd0re 6vOpZAt7jVoMCVVH4wHeoy+ie/hHlUs0d/7K081pr7mf4bWv26rS9bL5MG2KM/4LM26G Iv+uHIlVDn0qFU7CyGeaUqTQ2CJJQep/IkgS8FXge2m08YVQ8qKC9M5PdlvnX9/Fvy4y NKWQ== X-Gm-Message-State: AOAM533zYT9Vi0eqpvnvEsKhAE94FjJsk1Bx0iY7ulXBvFZP8667WWlg 0pSdhh+W9r7GjJfJnH/ZEednYYEGD2IbYg== X-Google-Smtp-Source: ABdhPJwo3t/U8ODtcKlVuHhUUXRKxyU98+Vyy64EteCjzuhH7BT2QEsXWWuhiLlZrxtxKgqnB9Fjfw== X-Received: by 2002:a67:f353:: with SMTP id p19mr6733697vsm.56.1620074478110; Mon, 03 May 2021 13:41:18 -0700 (PDT) Received: from mail-ua1-f44.google.com (mail-ua1-f44.google.com. [209.85.222.44]) by smtp.gmail.com with ESMTPSA id j12sm664250vsp.10.2021.05.03.13.41.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 May 2021 13:41:17 -0700 (PDT) Received: by mail-ua1-f44.google.com with SMTP id h1so2375520uar.0 for ; Mon, 03 May 2021 13:41:16 -0700 (PDT) X-Received: by 2002:a9f:2183:: with SMTP id 3mr17021447uac.0.1620074475074; Mon, 03 May 2021 13:41:15 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.1.I9e6af2529d6c61e5daf86a15a1211121c5223b9a@changeid> In-Reply-To: From: Doug Anderson Date: Mon, 3 May 2021 13:41:03 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls To: Linus Walleij Cc: Andrzej Hajda , Laurent Pinchart , Bjorn Andersson , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang , MSM , Rob Clark , Stanislav Lisovskiy , Stephen Boyd , Steev Klimaszewski , Maarten Lankhorst , linux-i2c , "open list:DRM PANEL DRIVERS" , Daniel Vetter , David Airlie , Thierry Reding , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Sat, May 1, 2021 at 5:07 AM Linus Walleij wrote: > > Hi Doug, > > On Fri, Apr 30, 2021 at 11:04 PM Doug Anderson wrote: > > > Pushed this one patch. Rest of the series is pending adult > > supervision. Overall summary: > > > > 1. I could probably push some of the early sn65dsi86 cleanup patches > > in this series since they have Bjorn's review and are pretty much > > no-ops / simple cleanups, but there's probably not tons gained for > > shoving those in early. > > Those look good to me as well. I'd say just apply them. > > To me it looks like up until and including patch 18? > Feel free to add my > Acked-by: Linus Walleij > > On these. OK, thanks! I've just pushed these patches to drm-misc-next with your Ack: 63358e24ee79 drm/panel: panel-simple: Cache the EDID as long as we retain power 31e25395d8b7 drm/panel: panel-simple: Power the panel when reading the EDID 4318ea406e02 drm/panel: panel-simple: Remove extra call: drm_connector_update_edid_property() b137406d9679 drm/bridge: ti-sn65dsi86: If refclk, DP AUX can happen w/out pre-enable f7a5ee2cd3e2 drm/bridge: ti-sn65dsi86: Code motion of refclk management functions 9bede63127c6 drm/bridge: ti-sn65dsi86: Use pm_runtime autosuspend 5c4381eeb709 drm/panel: panel-simple: Get rid of hacky HPD chicken-and-egg code bf73537f411b drm/bridge: ti-sn65dsi86: Break GPIO and MIPI-to-eDP bridge into sub-drivers bef236a5206c drm/bridge: ti-sn65dsi86: Move all the chip-related init to the start f94eb8a32863 drm/bridge: ti-sn65dsi86: Cleanup managing of drvdata 3636fc25f760 drm/bridge: ti-sn65dsi86: Add local var for "dev" to simplify probe 52d54819c8ae drm/bridge: ti-sn65dsi86: Clean debugfs code dea2500a820c drm/bridge: ti-sn65dsi86: Use devm to do our runtime_disable 905d66d08d0f drm/bridge: ti-sn65dsi86: More renames in prep for sub-devices db0036db4851 drm/bridge: ti-sn65dsi86: Rename the main driver data structure Things not pushed: [v5,15/20] i2c: i2c-core-of: Fix corner case of finding adapter by node -> Can't push i2c things [v5,14/20] drm/bridge: ti-sn65dsi86: Promote the AUX channel to its own sub-dev -> Won't work without rework. See [1] [v5,19/20] drm/bridge: ti-sn65dsi86: Don't read EDID blob over DDC -> Needs Laurent and also patch 14/20 to be resolved. [v5,20/20] arm64: dts: qcom: Link the panel to the bridge's DDC bus -> Needs all the rest resolved. Let me see if I can find a way to work around the AUX channel stuff and then I'll push a v6 of just what's left. > Just to keep you busy and make sure you don't run out of work > (haha) I noticed that the gpio_chip in this driver can use > the new GPIO_REGMAP helper library with the fixes just > landed in Torvald's tree. > > At your convenience and when you think there is too little > stuff in your sn65dsi86 TODO, check out > pinctrl-bcm63xx.c for an example of select GPIO_REGMAP > made very simple (this works fine as long as they are bit > offsets starting from 0). I seem to recall you mentioning something like this. When I looked at it in the past I wasn't convinced it would be easy. See my response [2]. The rough summary is that I didn't think the helpers were happy with the pm_runtime() model that I'm using. Did I get that wrong? [1] https://lore.kernel.org/dri-devel/CAD=FV=UTmOP8LDaf-Tyx17OORQK6pJH6O_w3cP0Bu-KRYaHkYw@mail.gmail.com/ [2] https://lore.kernel.org/r/CAD=FV=VqD-dY=v23KYuTqy8aRNQJJzJ7h_UOcdEBYuK9X51MQQ@mail.gmail.com -Doug