From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F10EC433DB for ; Wed, 10 Mar 2021 15:50:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45DD664FA1 for ; Wed, 10 Mar 2021 15:50:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233193AbhCJPuZ (ORCPT ); Wed, 10 Mar 2021 10:50:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231282AbhCJPuR (ORCPT ); Wed, 10 Mar 2021 10:50:17 -0500 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ECF98C061760 for ; Wed, 10 Mar 2021 07:50:16 -0800 (PST) Received: by mail-qk1-x72d.google.com with SMTP id z190so17233048qka.9 for ; Wed, 10 Mar 2021 07:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ekC/nFGtEL8dr/twPzXg0dnfB2QA+TE97mZugeSHujE=; b=nVkPzA5PWbGKtCV/O4KmTjeguVxqEHa6Hi0oXmfFqd10i1m8jjjEQhhgSjYPF+fLce zj1kn0HYxG66PKVD7er7Gyp5uhw6VNo0qjaeAELNT2PxkcVWosl+R+ofwLIXwwxDiHyD nzESW7a1Mo27/b4fw+lEToDuDuOcPyNzUMHIk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ekC/nFGtEL8dr/twPzXg0dnfB2QA+TE97mZugeSHujE=; b=j/q8NXxFyt9i+3hjUxeE1rSOhcrpQpyXRFz2msyvlWVDk6XZPVo3g89y5dNl4q9sx8 LIr0lVWXXBH5eZkiDl/SswKuieO7ikN9cx22mBaJTuUnts7wM24ROKjMn1W6H/hLJWkZ PAk0Lkam/LdiwQ5CCcR0X+8waEGcMBNMAG3LzycFj3gafy8KrmziwKiyY3KnzrFR0+u2 J/YvD2FRe5SPWI0UhiS4Ki9iC5WolnwtItWopUx2dEB01AoCrvHRazbqH32IkDQrfe4w 3SEMRBT8l0U7EuSNz6t8mgDZs/CGt4Ek0TouJ2wjK1YJQaLnveXLDI51hVusEPC07YiR JKpQ== X-Gm-Message-State: AOAM532Iz48uf/Mar3VoYec3kGctkFNhwAyt1P7c8xbIhcxtZKMiQgBe a8dD9wv1imtd9TpMwjL1AcBrM+jBeHRF4Q== X-Google-Smtp-Source: ABdhPJx6z9eo+encjGZ2xkgECEASGGW2atnxBy1kcexIr+ZDcAkFrb7JmIlk2RY05ZoWpHSaVqIf3Q== X-Received: by 2002:a05:620a:22b7:: with SMTP id p23mr3290943qkh.365.1615391415667; Wed, 10 Mar 2021 07:50:15 -0800 (PST) Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com. [209.85.219.176]) by smtp.gmail.com with ESMTPSA id a2sm11567683qtj.76.2021.03.10.07.50.14 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Mar 2021 07:50:14 -0800 (PST) Received: by mail-yb1-f176.google.com with SMTP id u75so18286292ybi.10 for ; Wed, 10 Mar 2021 07:50:14 -0800 (PST) X-Received: by 2002:a05:6902:70a:: with SMTP id k10mr1604610ybt.257.1615391414296; Wed, 10 Mar 2021 07:50:14 -0800 (PST) MIME-Version: 1.0 References: <20210305162546.1.I323dad4343256b48af2be160b84b1e87985cc9be@changeid> <8e274cc7-0c9e-b983-7dd9-c501c159e95a@linaro.org> In-Reply-To: <8e274cc7-0c9e-b983-7dd9-c501c159e95a@linaro.org> From: Doug Anderson Date: Wed, 10 Mar 2021 07:50:02 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] nvmem: core: Add functions to make number reading easy To: Srinivas Kandagatla Cc: "Rafael J . Wysocki" , Rob Clark , Jordan Crouse , Ulf Hansson , Stephen Boyd , linux-arm-msm , Bjorn Andersson , Akhil P Oommen , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Wed, Mar 10, 2021 at 2:37 AM Srinivas Kandagatla wrote: > > > > On 06/03/2021 00:26, Douglas Anderson wrote: > > Sometimes the clients of nvmem just want to get a number out of > > nvmem. They don't want to think about exactly how many bytes the nvmem > > cell took up. They just want the number. Let's make it easy. > > > > In general this concept is useful because nvmem space is precious and > > usually the fewest bits are allocated that will hold a given value on > > a given system. However, even though small numbers might be fine on > > one system that doesn't mean that logically the number couldn't be > > bigger. Imagine nvmem containing a max frequency for a component. On > > one system perhaps that fits in 16 bits. On another system it might > > fit in 32 bits. The code reading this number doesn't care--it just > > wants the number. > > > > We'll provide two functions: nvmem_cell_read_variable_le_u32() and > > nvmem_cell_read_variable_le_u64(). > > > > Comparing these to the existing functions like nvmem_cell_read_u32(): > > * These new functions have no problems if the value was stored in > > nvmem in fewer bytes. It's OK to use these function as long as the > > value stored will fit in 32-bits (or 64-bits). > > * These functions avoid problems that the earlier APIs had with bit > > offsets. For instance, you can't use nvmem_cell_read_u32() to read a > > value has nbits=32 and bit_offset=4 because the nvmem cell must be > > at least 5 bytes big to hold this value. The new API accounts for > > this and works fine. > > * These functions make it very explicit that they assume that the > > number was stored in little endian format. The old functions made > > this assumption whenever bit_offset was non-zero (see > > nvmem_shift_read_buffer_in_place()) but didn't whenever the > > bit_offset was zero. > > > > NOTE: it's assumed that we don't need an 8-bit or 16-bit version of > > this function. The 32-bit version of the function can be used to read > > 8-bit or 16-bit data. > > > > At the moment, I'm only adding the "unsigned" versions of these > > functions, but if it ends up being useful someone could add a "signed" > > version that did 2's complement sign extension. > > > > At the moment, I'm only adding the "little endian" versions of these > > functions. Adding the "big endian" version would require adding "big > > endian" support to nvmem_shift_read_buffer_in_place(). > > > > Signed-off-by: Douglas Anderson > > --- > > This is a logical follow-up to: > > https://lore.kernel.org/r/20210227002603.3260599-1-dianders@chromium.org/ > > ...but since it doesn't really share any of the same patches I'm not > > marking it as a v2. > > > > drivers/nvmem/core.c | 95 ++++++++++++++++++++++++++++++++++ > > include/linux/nvmem-consumer.h | 4 ++ > > 2 files changed, 99 insertions(+) > > > > This patch as it is LGTM. > > If you plan to take this via other trees, here is > > Reviewed-by: Srinivas Kandagatla Thanks! I think none of this is terribly urgent, though. Unless someone has a different opinion, my thought would be: * This patch lands in your tree for 5.13. * I'll snooze the email for 2 months and poke patch #2 and #3 once 5.13-rc1 is out. Does that sound OK to you? -Doug