From: Doug Anderson <dianders@chromium.org>
To: Maulik Shah <mkshah@codeaurora.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Matthias Kaehlcke <mka@chromium.org>,
Joe Perches <joe@perches.com>, Stephen Boyd <swboyd@chromium.org>,
Evan Green <evgreen@chromium.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] soc: qcom: rpmh-rsc: Timeout after 1 second in write_tcs_reg_sync()
Date: Thu, 28 May 2020 07:51:03 -0700 [thread overview]
Message-ID: <CAD=FV=WwMggCMntyjOcms68Jm223_sHjBHUoc8qfG7D_QcAjxA@mail.gmail.com> (raw)
In-Reply-To: <ff140959-98f9-7a67-e3de-f543e4ff3ac0@codeaurora.org>
Hi,
On Thu, May 28, 2020 at 4:44 AM Maulik Shah <mkshah@codeaurora.org> wrote:
>
> Hi Doug,
>
> During suspend-resume with this change on sc7180 using latest
> linux-next, below warning was reported.
>
> WARNING: CPU: 0 PID: 5324 at kernel/time/timekeeping.c:754
> ktime_get+0x94/0x9c
> ktime_get+0x94/0x9c
> write_tcs_reg_sync+0x4c/0x130
> tcs_invalidate+0x64/0xa4
> rpmh_rsc_invalidate+0x20/0x38
> rpmh_flush+0x58/0x1ec
> rpmh_rsc_cpu_pm_callback+0xe4/0x144
> notifier_call_chain+0x58/0x90
> __atomic_notifier_call_chain+0x48/
> cpu_pm_notify+0x40/0x6c
> cpu_pm_enter+0x34/0x7c
> cpu_pm_suspend+0x10/0x20
> syscore_suspend+0x128/0x2a4
> suspend_devices_and_enter+0x5e0/0x8a0
>
> This seems to be because timekeeping is already suspend by this time.
Thanks for the report. I posted:
https://lore.kernel.org/r/20200528074530.1.Ib86e5b406fe7d16575ae1bb276d650faa144b63c@changeid
I think there are still a bunch of not-yet-landed patches needed for
suspend-resume so I only confirmed that the code still works OK for
the idle case. Hopefully you can confirm s2r is good, though I'd
believe it should be exactly the same. I'm 99% sure that udelay()
still works fine even when timekeeping is suspended.
-Doug
prev parent reply other threads:[~2020-05-28 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-15 17:00 [PATCH v3 1/2] soc: qcom: rpmh-rsc: Factor "tcs_reg_addr" and "tcs_cmd_addr" calculation Douglas Anderson
2020-04-15 17:00 ` [PATCH v3 2/2] soc: qcom: rpmh-rsc: Timeout after 1 second in write_tcs_reg_sync() Douglas Anderson
2020-05-28 11:44 ` Maulik Shah
2020-05-28 14:51 ` Doug Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=WwMggCMntyjOcms68Jm223_sHjBHUoc8qfG7D_QcAjxA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=evgreen@chromium.org \
--cc=joe@perches.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=mkshah@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).