From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62251C47097 for ; Thu, 3 Jun 2021 20:34:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40D0B611ED for ; Thu, 3 Jun 2021 20:34:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229801AbhFCUgW (ORCPT ); Thu, 3 Jun 2021 16:36:22 -0400 Received: from mail-qt1-f181.google.com ([209.85.160.181]:36841 "EHLO mail-qt1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229617AbhFCUgW (ORCPT ); Thu, 3 Jun 2021 16:36:22 -0400 Received: by mail-qt1-f181.google.com with SMTP id s12so5405809qta.3 for ; Thu, 03 Jun 2021 13:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CWdL8xo0vHpWIgIBdECu+RNiDuRV629s7OGWjc46l1Q=; b=n6a/oJMr+5W2Mhz4wGcI8n6C0FC8XTzSB7bxg187Zmsnm//6MWq6vCPwEl+T/+TZHT EyA1fF4K1YQ73atxpYKYtS8RIeL0WKUB7CLjXPNYYz0AqHQAyCAysYSfzoXWit/v9R04 td8OfK6skei2EiDN76u0iJqFG+XzJGVsUNvvY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CWdL8xo0vHpWIgIBdECu+RNiDuRV629s7OGWjc46l1Q=; b=YUo8jjZUMZWMWTdn/aNaMb4Cm7jYAZyFv04cN49y8IXtePqbAFiGhTiYlVOimJHmHr rV7QWwWRIhTL/somugf4BpUxbu6JV+iEhRPLpZanqejsMe46aTdtO0hbJz7a1f8r+NFw ajb56r/+C8Avgeh54lW48/lv+MAGRjyumkhqBFcjL8Eb6wJ9a5uVx7mD8FIS3FbE+9ld TsFxiTT09wt8+fyj3/pMhbN5sciybD2N5Gux/sjIjAEpc+ukG7Nqk5BRGSJIh77DJj6q IOxrH8HJsEQpLbiBIPd4nGv2zSuRP9GUVzOvYZZxHKxBCFT7FIBQdG8y88upJEon0NsV /ChQ== X-Gm-Message-State: AOAM532JBa2IdobaCQnQ2zKW3xn+5pqa68NA2NQks0mpqYX2l9s66RkZ mhUR/yC8Xv+rMzZU9j4bfwqq/Lq5LZmuuQ== X-Google-Smtp-Source: ABdhPJz5Q636IrmDCHjD3JQgSyckFg5RktWGR+9NAwjXAzyM2WNo4fSMLi+Q9CA3taO4GcZ62Elo8w== X-Received: by 2002:ac8:4a95:: with SMTP id l21mr1290561qtq.317.1622752401503; Thu, 03 Jun 2021 13:33:21 -0700 (PDT) Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com. [209.85.219.173]) by smtp.gmail.com with ESMTPSA id p10sm2542569qkg.74.2021.06.03.13.33.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jun 2021 13:33:20 -0700 (PDT) Received: by mail-yb1-f173.google.com with SMTP id 207so10637196ybd.1 for ; Thu, 03 Jun 2021 13:33:20 -0700 (PDT) X-Received: by 2002:a25:80d4:: with SMTP id c20mr424281ybm.345.1622752399765; Thu, 03 Jun 2021 13:33:19 -0700 (PDT) MIME-Version: 1.0 References: <20210602191338.1995827-1-sujitka@chromium.org> <20210602121313.v3.2.I52f30ddfe62041b7e6c3c362f0ad8f695ac28224@changeid> In-Reply-To: <20210602121313.v3.2.I52f30ddfe62041b7e6c3c362f0ad8f695ac28224@changeid> From: Doug Anderson Date: Thu, 3 Jun 2021 13:33:07 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sc7180: SD-card GPIO pin set bias-pull up To: Sujit Kautkar Cc: Andy Gross , Bjorn Andersson , Rob Herring , Sibi Sankar , Rajendra Nayak , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Wed, Jun 2, 2021 at 12:14 PM Sujit Kautkar wrote: > > Some SC7180 based board do not have external pull-up for cd-gpio. nit: s/board/boards Presumably Bjorn could fix this when he applies the patch. I wouldn't re-post just for this fix unless Bjorn asks you to. > Set this pin to internal pull-up for sleep config to avoid frequent > regulator toggle events. > > Signed-off-by: Sujit Kautkar > --- > > Changes in v3: > - remove 'trogdor' from commit message > - move reference patch from commit message > > Changes in v2: > - added pull-up for IDP > > This change is with reference to Qualcomm's DT change posted at: > https://patchwork.kernel.org/patch/11675347/ > > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 2 +- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) FYI: I had my Reviewed-by tag on v2. While you did make changes between v2 and v3, in this case I don't think the changes were significant enough to warrant removing my Reviewed-by tag and I would have been happy if you'd kept it. In general, if you ever have questions about whether you should keep someone's reviewed tag, it never hurts to mention your logic "after the cut" (I think you use patman so this would be "Commit-notes:"). For instance, you could say this if you removed Reviewed-by tags: I totally recombobulated the frobnication logic in v3 and removed previous Reviewed-by tags. Hopefully reviewers can re-add if they still think the patch is good. ...or, you could say this if you kept them but you weren't totally sure it was OK: Even though every single line in the v3 patch changed from v2, it's only because I fixed a stoopid spelling Mistake. Thus, I kept previous Reviewed-by tags. Please yell if you object. Who knew that the only acceptable spelling of the English word "stupid" in kerneldoc comments was written as "stoopid". Live and learn. :-) In any case, here's my Reviewed-by tag again. I also agree that Bjorn's comments made sense and were good to fix... Reviewed-by: Douglas Anderson