From: Doug Anderson <dianders@chromium.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Sibi Sankar <sibis@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Evan Green <evgreen@chromium.org>, Ben Chan <benchan@google.com>,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH v3 02/10] arm64: dts: qcom: sdm845: Define rmtfs memory
Date: Tue, 22 Jan 2019 15:26:22 -0800 [thread overview]
Message-ID: <CAD=FV=X0x4hQ=8yQ6wDWE8ximf9A8hpgpRWTdPrFXDD4FVO8VQ@mail.gmail.com> (raw)
In-Reply-To: <20190122055112.30943-3-bjorn.andersson@linaro.org>
Hi,
On Mon, Jan 21, 2019 at 9:51 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> Define the rmtfs memory node, as described in version 10 of the memory
> map.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>
> Changes since v2:
> - New patch
>
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index cdcac3704c13..64f57cc5c61a 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -72,6 +72,15 @@
> #size-cells = <2>;
> ranges;
>
> + rmtfs@85d00000 {
> + compatible = "qcom,rmtfs-mem";
> + reg = <0 0x85d00000 0 0x200000>;
> + no-map;
> +
> + qcom,client-id = <1>;
> + qcom,vmid = <15>;
> + };
Ah, I saw this after I posted my comments to patch #1. I guess this
is the same as this node we have in our cheza board file downstream
(need to get that posted upstream soon):
rmtfs@88f00000 {
compatible = "qcom,rmtfs-mem";
reg = <0x0 0x88f00000 0x0 0x800000>;
no-map;
qcom,client-id = <1>;
};
That brings up a few things:
1. You should add a node label here. This allows us to act on the
node more easily from board files, like setting it to disabled or
changing it.
2. In https://crrev.com/c/1119572, the argument was made that the size
of this carveout is board-specific. That makes it hard to put it in
sdm845.dts.
-Doug
next prev parent reply other threads:[~2019-01-22 23:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 5:51 [PATCH v3 00/10] Qualcomm AOSS QMP driver and modem dts Bjorn Andersson
2019-01-22 5:51 ` [PATCH v3 01/10] arm64: dts: qcom: sdm845: Update PIL region memory map Bjorn Andersson
2019-01-22 18:58 ` Stephen Boyd
2019-01-22 19:24 ` Bjorn Andersson
2019-01-22 23:10 ` Doug Anderson
2019-01-23 0:30 ` Bjorn Andersson
2019-01-22 23:16 ` Doug Anderson
2019-01-23 0:39 ` Bjorn Andersson
2019-01-25 17:40 ` Sibi Sankar
2019-01-22 5:51 ` [PATCH v3 02/10] arm64: dts: qcom: sdm845: Define rmtfs memory Bjorn Andersson
2019-01-22 23:26 ` Doug Anderson [this message]
2019-01-22 23:34 ` Brian Norris
2019-01-23 0:47 ` Bjorn Andersson
2019-01-22 5:51 ` [PATCH v3 03/10] arm64: dts: sdm845: Introduce ADSP and CDSP PAS nodes Bjorn Andersson
2019-01-22 23:46 ` Doug Anderson
2019-01-23 0:26 ` Bjorn Andersson
2019-01-23 0:40 ` Doug Anderson
2019-01-23 1:09 ` Bjorn Andersson
2019-01-23 23:24 ` Doug Anderson
2019-01-24 6:22 ` Stephen Boyd
2019-01-22 5:51 ` [PATCH v3 04/10] dt-bindings: soc: qcom: Add AOSS QMP binding Bjorn Andersson
2019-01-22 19:04 ` Stephen Boyd
2019-01-22 19:25 ` Bjorn Andersson
2019-01-22 19:28 ` Stephen Boyd
2019-01-22 5:51 ` [PATCH v3 05/10] soc: qcom: Add AOSS QMP communication driver Bjorn Andersson
2019-01-22 5:51 ` [PATCH v3 06/10] soc: qcom: Add AOSS QMP genpd provider Bjorn Andersson
2019-01-22 5:51 ` [PATCH v3 07/10] remoteproc: q6v5-mss: Vote for rpmh power domains Bjorn Andersson
2019-01-23 0:01 ` Doug Anderson
2019-01-22 5:51 ` [PATCH v3 08/10] remoteproc: q6v5-mss: Active powerdomain for SDM845 Bjorn Andersson
2019-01-22 5:51 ` [PATCH v3 09/10] arm64: dts: qcom: Add AOSS QMP node Bjorn Andersson
2019-01-22 5:51 ` [PATCH v3 10/10] arm64: dts: qcom: sdm845: Add Q6V5 MSS node Bjorn Andersson
2019-01-23 0:28 ` Doug Anderson
2019-01-23 1:10 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=X0x4hQ=8yQ6wDWE8ximf9A8hpgpRWTdPrFXDD4FVO8VQ@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=andy.gross@linaro.org \
--cc=benchan@google.com \
--cc=bjorn.andersson@linaro.org \
--cc=briannorris@chromium.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).