From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44BD2C433B4 for ; Fri, 30 Apr 2021 21:46:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1210D61158 for ; Fri, 30 Apr 2021 21:46:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230226AbhD3Vqy (ORCPT ); Fri, 30 Apr 2021 17:46:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229915AbhD3Vqx (ORCPT ); Fri, 30 Apr 2021 17:46:53 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC520C06174A for ; Fri, 30 Apr 2021 14:46:02 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id n32-20020a9d1ea30000b02902a53d6ad4bdso10707524otn.3 for ; Fri, 30 Apr 2021 14:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O+NCC185GvVdiBCa7+Pd+oKQFpxMk0PeHhw7on/LJY0=; b=EwcYXa4w+hFOwVcOG79Z1xFiI0pBpKJ5X2X980Q7KB/i0nON6cxaQ52synEx6n8OMm 6eigW5MUkaQK1NfJcoKnLyG6JQBTYIQ2uBFeWDyjhqOnznt1s5ubxm1zdvYB5wO+TvJF P1bSP2R62bPtFDeRMklaQWNRq7DdjgKeGkFSg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O+NCC185GvVdiBCa7+Pd+oKQFpxMk0PeHhw7on/LJY0=; b=EErSGVA5zvlr4AtHDnr7am0mKHWBl88HKVSZ8iwJKqoC3DVyKawxpGg1gqSUuOyEil 4q0lrWu/s53gAlQwLiPD2oExTeRDp2mleX2005c0Ft+s+JU+emagu3Y4ra8XjAWTXxLL Vk/4ENuIgeodYC/wZehdJTReG/wDX2zlIKhjPy7C/zjaIQaWKi5HZLazrjm0ZrI3vnHo KuDYhVR3FA0vjKHADjwmb9RSDU4klkR+rmj5bLTXlsoiR5ao18QBknt8qRzxfCCfGpmY agiEarq3iEKL+Ys6cSRQoe8T92gw7ediBfwfKMroGU99asFcAtfjoZz2VllYQoZ+DUKz 0dGA== X-Gm-Message-State: AOAM5302Ve25qcFMYnzL/Vz1j9iqWTBWFyHaddP/ZwGVpIJpgjA245OZ xvin6vF76TpWyStig7ha6TIhkvLgyCLH3Q== X-Google-Smtp-Source: ABdhPJyhHM/p0BDyTDSg0HxWH2FX76OL7ifGtZn7+z8Us66PYO0Qb+auDqelGwKjThhXvcRImWK5sQ== X-Received: by 2002:a05:6830:3495:: with SMTP id c21mr3508351otu.53.1619819162001; Fri, 30 Apr 2021 14:46:02 -0700 (PDT) Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com. [209.85.210.49]) by smtp.gmail.com with ESMTPSA id a10sm1052342oiy.9.2021.04.30.14.46.01 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Apr 2021 14:46:01 -0700 (PDT) Received: by mail-ot1-f49.google.com with SMTP id f75-20020a9d03d10000b0290280def9ab76so60585877otf.12 for ; Fri, 30 Apr 2021 14:46:01 -0700 (PDT) X-Received: by 2002:a25:80d4:: with SMTP id c20mr10228081ybm.345.1619818721319; Fri, 30 Apr 2021 14:38:41 -0700 (PDT) MIME-Version: 1.0 References: <1619416756-3533-1-git-send-email-rajeevny@codeaurora.org> <1619416756-3533-2-git-send-email-rajeevny@codeaurora.org> <20210429180435.GA1385465@robh.at.kernel.org> <78c4bd291bd4a17ae2a1d02d0217de43@codeaurora.org> In-Reply-To: <78c4bd291bd4a17ae2a1d02d0217de43@codeaurora.org> From: Doug Anderson Date: Fri, 30 Apr 2021 14:38:29 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v3 1/2] dt-bindings: backlight: add DisplayPort aux backlight To: Rajeev Nandan Cc: Rob Herring , dri-devel , linux-arm-msm , freedreno , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Rob Clark , mkrishn@codeaurora.org, Kalyan Thota , "Kristian H. Kristensen" , Abhinav Kumar , Sean Paul , Jani Nikula , Lyude Paul , "Lankhorst, Maarten" , Laurent Pinchart , Andrzej Hajda Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Fri, Apr 30, 2021 at 8:10 AM wrote: > > On 30-04-2021 02:33, Doug Anderson wrote: > > Hi, > > > > On Thu, Apr 29, 2021 at 11:04 AM Rob Herring wrote: > >> > >> On Mon, Apr 26, 2021 at 11:29:15AM +0530, Rajeev Nandan wrote: > >> > Add bindings for DisplayPort aux backlight driver. > >> > > >> > Changes in v2: > >> > - New > >> > > >> > Signed-off-by: Rajeev Nandan > >> > --- > >> > .../bindings/leds/backlight/dp-aux-backlight.yaml | 49 ++++++++++++++++++++++ > >> > 1 file changed, 49 insertions(+) > >> > create mode 100644 Documentation/devicetree/bindings/leds/backlight/dp-aux-backlight.yaml > >> > > >> > diff --git a/Documentation/devicetree/bindings/leds/backlight/dp-aux-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/dp-aux-backlight.yaml > >> > new file mode 100644 > >> > index 00000000..0fa8bf0 > >> > --- /dev/null > >> > +++ b/Documentation/devicetree/bindings/leds/backlight/dp-aux-backlight.yaml > >> > @@ -0,0 +1,49 @@ > >> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> > +%YAML 1.2 > >> > +--- > >> > +$id: http://devicetree.org/schemas/leds/backlight/dp-aux-backlight.yaml# > >> > +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> > + > >> > +title: DisplayPort aux backlight driver bindings > >> > + > >> > +maintainers: > >> > + - Rajeev Nandan > >> > + > >> > +description: > >> > + Backlight driver to control the brightness over DisplayPort aux channel. > >> > + > >> > +allOf: > >> > + - $ref: common.yaml# > >> > + > >> > +properties: > >> > + compatible: > >> > + const: dp-aux-backlight > >> > + > >> > + ddc-i2c-bus: > >> > + $ref: /schemas/types.yaml#/definitions/phandle > >> > + description: > >> > + A phandle to the system I2C controller connected to the DDC bus used > >> > + for the DisplayPort AUX channel. > >> > + > >> > + enable-gpios: > >> > + maxItems: 1 > >> > + description: GPIO specifier for backlight enable pin. > >> > + > >> > + max-brightness: true > >> > + > >> > +required: > >> > + - compatible > >> > + - ddc-i2c-bus > >> > + > >> > +additionalProperties: false > >> > + > >> > +examples: > >> > + - | > >> > + backlight { > >> > + compatible = "dp-aux-backlight"; > >> > + ddc-i2c-bus = <&sn65dsi86_bridge>; > >> > + enable-gpios = <&tlmm 12 GPIO_ACTIVE_HIGH>; > >> > >> So the DDC bus is connected to a backlight and also a panel? This > >> binding is not reflecting the h/w, but rather what you want for some > >> driver. > >> > >> There's only one thing here and that's an eDP panel which supports > >> backlight control via DP aux channel. You can figure all that out from > >> the panel's compatible and/or reading the EDID. > >> > >> You might also be interested in this thread: > >> > >> https://lore.kernel.org/lkml/YIKsDtjcIHGNvW0u@orome.fritz.box/ > > > > I think Rajeev needs to rework everything anyway as per: > > > > https://lore.kernel.org/r/87zgxl5qar.fsf@intel.com > > > > ...but you're right that it makes sense not to model the backlight as > > a separate node in the device tree. The panel driver can handle > > setting up the backlight. > > > > -Doug > > It was not a good idea to create a separate backlight driver and use > ddc-i2c-bus to get access to DP aux. I am working to move the code > to the panel driver and to utilize the new DRM helper functions > (drm_edp_backlight_*) Lyude has added [1]. > > To use these helper functions, the panel driver should have access to > the > "struct drm_dp_aux *". The simple-panel has a "ddc-i2c-bus" property > to give the panel access to the DDC bus and is currently being used to > get the EDID from the panel. Can I use the same ddc bus i2c_adapter to > get > the "struct drm_dp_aux *"? > > As per the suggestion [2], I get the "struct drm_dp_aux *" from the > i2c_adapter of ddc bus (maybe I didn't understand the suggestion > correctly), > and, it turned out, the way I have implemented is not the right way [3]. > So, I am afraid to use the same method in the panel driver. > > > [1] https://lore.kernel.org/dri-devel/871rb5bcf9.fsf@intel.com/ > [2] https://www.spinics.net/lists/dri-devel/msg295429.html > [3] > https://lore.kernel.org/dri-devel/20210426111116.4lc3ekxjugjr3oho@maple.lan/ So it's definitely up to maintainers, not me. ...but I guess I would have expected something like a new property called "ddc-aux-bus". Then you'd have to create a new API call called something like "of_find_ddc_aux_adapter_by_node()" that would allow you to find it. I guess an alternate way to solve this (I'm not totally sure whether it's better or worse) would be to add a function that would walk up the chain of parent bridges and ask them for a pointer to the aux bus. I definitely haven't thought it all the way through, but I'd imagine something like drm_bridge_chain_get_ddc_aux(). This is _probably_ better than adding the "ddc-aux-bus" property but it assumes that the aux bus is provided by one of our parents. Hrm, looking at this briefly, though, I'm not sure how to do it. It doesn't seem possible to get the parent bridges from the panel structure. Even if you assume that your parent is wrapping you with a panel_bridge it still doesn't seem possible? This probably needs more drm-expertise. -Doug