From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BC01C04AB4 for ; Fri, 17 May 2019 18:35:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D36F21726 for ; Fri, 17 May 2019 18:35:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="f0K0xxpV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726750AbfEQSfN (ORCPT ); Fri, 17 May 2019 14:35:13 -0400 Received: from mail-ua1-f67.google.com ([209.85.222.67]:37185 "EHLO mail-ua1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726554AbfEQSfN (ORCPT ); Fri, 17 May 2019 14:35:13 -0400 Received: by mail-ua1-f67.google.com with SMTP id t18so3063080uar.4 for ; Fri, 17 May 2019 11:35:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D7Ld6ak/BcDR+qMn0+Bwsy5o52SxdEie1Dd6vVWMNQc=; b=f0K0xxpVCF0ZLjARllhNmUlWPrNzNN5Nc31omR/w66TNZzX+6LZi+uLIHRG3pOjbld Gz5edzdihDaQQN/cpB2qydPoWipFpiGBOL0D0BXOabrGcCiX/KO1sGrfrMjUCGjDWKd7 jKY9WFgb8JoT9kHtActzd8jbPHp6fFMTBZJ+s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D7Ld6ak/BcDR+qMn0+Bwsy5o52SxdEie1Dd6vVWMNQc=; b=cGp0FIV/pqmmDkJXEvgCdByUILalDtvWG3cmLGjvnxI0Ub7Ntkklvwjlmu6yQuER41 hwGUDkQcct5D5/wtbWBQSeZaoH3qTwAAlyYwX3S1bvzS/w2A9v7jTXAp4jgeQDdU9V0+ S9eopF0hYqx1c0f5O1XeE3yHOjcZ0mJ9jg9OWwXQoHu7Vys8bflSyamyGzZjcARhNjul CtZhlqUWVjNoi3ZBFjtZ3UV4Duqg7A8pEkeWTor4r+7TrtAYrZPePy1TMYNvqulcj0kc KF9LnTJcwMVezOYmr8IGav3nMlR84LKZidwuO/hwYSlTDbMvbGfqfTfQGrDQVFXztzAP NLqw== X-Gm-Message-State: APjAAAU8Ve/VJmcp9XuhtsQFpN1D3LhcOCmWWrKQ9OCBYB12YVoMNkd2 Eu+sXNQKsfdnKOYcCylu84H1mgbV1yE= X-Google-Smtp-Source: APXvYqwQgVTUi4QHqTwW9JzJL+EH8sSa/CMX1py3pfsZ40u703+Fwmgo36qaN6E3MPVN8hdKB8G7oA== X-Received: by 2002:ab0:1410:: with SMTP id b16mr27333321uae.1.1558118112002; Fri, 17 May 2019 11:35:12 -0700 (PDT) Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com. [209.85.222.50]) by smtp.gmail.com with ESMTPSA id b83sm6378298vsd.32.2019.05.17.11.35.10 for (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Fri, 17 May 2019 11:35:11 -0700 (PDT) Received: by mail-ua1-f50.google.com with SMTP id d4so3056342uaj.7 for ; Fri, 17 May 2019 11:35:10 -0700 (PDT) X-Received: by 2002:a9f:24a3:: with SMTP id 32mr5229332uar.109.1558118110537; Fri, 17 May 2019 11:35:10 -0700 (PDT) MIME-Version: 1.0 References: <20190517015305.23194-1-robdclark@gmail.com> In-Reply-To: <20190517015305.23194-1-robdclark@gmail.com> From: Doug Anderson Date: Fri, 17 May 2019 11:34:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: dts: qcom: sdm845-cheza: add initial cheza dt To: Rob Clark Cc: linux-arm-msm , Bjorn Andersson , Stephen Boyd , Rob Clark , Sibi Sankar , Evan Green , Matthias Kaehlcke , Abhinav Kumar , Brian Norris , Venkat Gopalakrishnan , Rajendra Nayak , Andy Gross , David Brown , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Thu, May 16, 2019 at 6:53 PM Rob Clark wrote: > > From: Rob Clark > > This is essentialy a squash of a bunch of history of cheza dt updates > from chromium kernel, some of which were themselves squashes of history > from older chromium kernels. > > I don't claim any credit other than wanting to more easily boot upstream > kernel on cheza to have an easier way to test upstream driver work ;-) > > I've added below in Cc tags all the original actual authors (apologies > if I missed any). > > Cc: Douglas Anderson > Cc: Sibi Sankar > Cc: Evan Green > Cc: Matthias Kaehlcke > Cc: Abhinav Kumar > Cc: Brian Norris > Cc: Venkat Gopalakrishnan > Cc: Rajendra Nayak > Signed-off-by: Rob Clark > --- > Updated from review comments and squashed. I left out the the patch > related to deleting gpu_mem/zap_shader nodes as the corresponding > patch that adds them in sdm845.dtsi hasn't landed yet, but once it > has we will need to revisit that patch for cheza. > > arch/arm64/boot/dts/qcom/Makefile | 3 + > arch/arm64/boot/dts/qcom/sdm845-cheza-r1.dts | 238 ++++ > arch/arm64/boot/dts/qcom/sdm845-cheza-r2.dts | 238 ++++ > arch/arm64/boot/dts/qcom/sdm845-cheza-r3.dts | 174 +++ > arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 1326 ++++++++++++++++++ > 5 files changed, 1979 insertions(+) Looks sane to me. Thanks! Reviewed-by: Douglas Anderson