From: Doug Anderson <dianders@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Philip Chen <philipchen@chromium.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] arm64: dts: sc7180: Support Parade ps8640 edp bridge
Date: Thu, 30 Sep 2021 09:21:48 -0700 [thread overview]
Message-ID: <CAD=FV=XoOhSNP2EXurkA=G9iG2BnH9VzkvSEiNJ8W71s8N9bgg@mail.gmail.com> (raw)
In-Reply-To: <CAE-0n53EBvKv-RdMwiiOsUkb+LOKAKwrpP7cDavx4meA2vbvcA@mail.gmail.com>
Hi,
On Wed, Sep 29, 2021 at 9:02 PM Stephen Boyd <swboyd@chromium.org> wrote:
>
> > + pp3300_brij_ps8640: pp3300-brij-ps8640 {
> > + compatible = "regulator-fixed";
> > + status = "okay";
> > + regulator-name = "pp3300_brij_ps8640";
> > +
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > +
> > + gpio = <&tlmm 32 GPIO_ACTIVE_HIGH>;
>
> Doesn't this need
>
> enable-active-high;
Looks like it. Without that it looks like it assumes active low.
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&en_pp3300_edp_brij_ps8640>;
> > +
> > + vin-supply = <&pp3300_a>;
> > + };
> > +};
> > +
> > +&dsi0_out {
> > + remote-endpoint = <&ps8640_in>;
>
> Should this also have data-lanes to be "complete"?
That's still back in the main trogdor.dtsi, isn't it?
> > +edp_brij_i2c: &i2c2 {
> > + status = "okay";
> > + clock-frequency = <400000>;
> > +
> > + ps8640_bridge: edp-bridge@8 {
>
> Just bridge@8 to match ti bridge? Also, is the label used? If not
> please drop it.
I agree with Stephen about it being "bridge@8". Personally I don't
mind labels like this even if they're not used since they don't hurt
and it creates less churn to add them now, but I won't fight hard to
keep them.
> > + aux_bus: aux-bus {
>
> Is this label used either?
Yeah, I'd get rid of this one since there you didn't add it in the
sn65dsi86 dtsi file and it seems exceedingly unlikely we'd need it for
any reason.
-Doug
next prev parent reply other threads:[~2021-09-30 16:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 0:34 [PATCH v2 1/3] arm64: dts: sc7180: Factor out ti-sn65dsi86 support Philip Chen
2021-09-30 0:34 ` [PATCH v2 3/3] arm64: dts: sc7180: Support Parade ps8640 edp bridge Philip Chen
2021-09-30 4:02 ` Stephen Boyd
2021-09-30 16:21 ` Doug Anderson [this message]
2021-10-07 18:15 ` Philip Chen
2021-10-08 18:46 ` Philip Chen
2021-10-08 23:12 ` Doug Anderson
2021-10-08 23:39 ` Philip Chen
2021-09-30 16:22 ` [PATCH v2 1/3] arm64: dts: sc7180: Factor out ti-sn65dsi86 support Doug Anderson
2021-10-07 22:29 ` Philip Chen
2021-10-07 22:46 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XoOhSNP2EXurkA=G9iG2BnH9VzkvSEiNJ8W71s8N9bgg@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=philipchen@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).