From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77A5EC3F68F for ; Tue, 28 Jan 2020 16:37:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FB9824688 for ; Tue, 28 Jan 2020 16:37:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Jy6LgqTm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726548AbgA1Qh1 (ORCPT ); Tue, 28 Jan 2020 11:37:27 -0500 Received: from mail-vs1-f67.google.com ([209.85.217.67]:41464 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726323AbgA1Qh1 (ORCPT ); Tue, 28 Jan 2020 11:37:27 -0500 Received: by mail-vs1-f67.google.com with SMTP id k188so8457733vsc.8 for ; Tue, 28 Jan 2020 08:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wdBTmzXhmHeC2y+w5bp3Tmr7OlXTeRKWIpwTGn8ME1U=; b=Jy6LgqTmfR3UQAL/nf0tfINNueuVMCNCsDnr62JvGnqxaaSO6eh3MGvzb2gsmFEIh9 v8t62XCbAvdWKGGuypZ0FLwOEZ78/yTzMfyma+7Mhjly532URlcehmPWG8YJYOtWvU7+ LRsSBxPVZR7oanCNXskMFWyNcGIxQQbm+e0KQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wdBTmzXhmHeC2y+w5bp3Tmr7OlXTeRKWIpwTGn8ME1U=; b=jiXxWI7yyMoOfJGhbJyFdG10HmmwalS55TIYRQsifHuKlZVrC7RpcnFHpjTDnhcTjG 75zGlWPuWeWdmw01aM3JL2ivw3ZzCPCnHTP7dtfLPO21FwcZPiyHm1jDaNGnY6WitQGW 9kICDzh8nQyeXeDLH9M0bMB/fhpqU4UrmpkaKQBWImk7NlyaHeVh1BC0OFCyyzZxIHzU rd09oAE8MtzOsCNIWmxmI3CpELYWcGf5pIdqCVI1U1VugntxfLtVnSnnG6Y/G096wpz4 /7uaB/az42YtP4u8i8HwiYXvlJ0Yf82hxPeInht0QbsH4CrKr+stsj0jVoZ09Nh9zET2 5ErA== X-Gm-Message-State: APjAAAWh6GVj4Au/2Qqz3jQtA/AXO/5+Rkzfnvk/OIjvQJCI7sJHaYj3 PiqG5UjyFWcYvPDHfstoWSRus2xrrwQ= X-Google-Smtp-Source: APXvYqxYgyCEdFDOLbFY34SbHlSYM7fKouFuxodGexRbt+Sax8s+Wb5/WLNd3xiuInjplo2EHdWaTw== X-Received: by 2002:a67:e9cc:: with SMTP id q12mr6780041vso.173.1580229445948; Tue, 28 Jan 2020 08:37:25 -0800 (PST) Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com. [209.85.217.54]) by smtp.gmail.com with ESMTPSA id n189sm5500872vkc.10.2020.01.28.08.37.23 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Jan 2020 08:37:24 -0800 (PST) Received: by mail-vs1-f54.google.com with SMTP id k188so8457644vsc.8 for ; Tue, 28 Jan 2020 08:37:23 -0800 (PST) X-Received: by 2002:a67:fbcb:: with SMTP id o11mr14305246vsr.109.1580229443406; Tue, 28 Jan 2020 08:37:23 -0800 (PST) MIME-Version: 1.0 References: <20200124224225.22547-1-dianders@chromium.org> <20200124144154.v2.7.I3bf44e33f4dc7ecca10a50dbccb7dc082894fa59@changeid> <6e585554-d0bd-39d7-2150-e7968dd51fb3@codeaurora.org> In-Reply-To: <6e585554-d0bd-39d7-2150-e7968dd51fb3@codeaurora.org> From: Doug Anderson Date: Tue, 28 Jan 2020 08:37:09 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 07/10] clk: qcom: Fix sc7180 gpucc parent data To: Taniya Das Cc: Rob Herring , Andy Gross , Bjorn Andersson , Jeffrey Hugo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , Harigovindan P , Matthias Kaehlcke , kalyan_t@codeaurora.org, Mark Rutland , linux-clk , "Kristian H. Kristensen" , Michael Turquette , Stephen Boyd , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Mon, Jan 27, 2020 at 9:55 PM Taniya Das wrote: > > Hi Doug, > > Thanks for your patch. But as mentioned earlier we really want to avoid > updating the auto generated code. As per my reply [1], I think you need to update your auto-generation tools to generate the code that results from my patch. The existing code either requires using global clock names to match or requires to pass clocks in the dts that aren't documented in the bindings. That needs to be fixed and my patch fixes it. [1] https://lore.kernel.org/r/CAD=FV=XFFCPj8S7-WPjPLFe=iygpkYiyMqbneY0DMXsMz+j73w@mail.gmail.com -Doug