From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 125CCC48BE5 for ; Tue, 22 Jun 2021 16:54:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA96461357 for ; Tue, 22 Jun 2021 16:54:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231207AbhFVQ4c (ORCPT ); Tue, 22 Jun 2021 12:56:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230102AbhFVQ4b (ORCPT ); Tue, 22 Jun 2021 12:56:31 -0400 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 053EBC06175F for ; Tue, 22 Jun 2021 09:54:14 -0700 (PDT) Received: by mail-qk1-x72d.google.com with SMTP id w21so27420225qkb.9 for ; Tue, 22 Jun 2021 09:54:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ln0rqCYelsyqtkFalmwSESWUlyrC6dhevN9AgMvP0es=; b=ZLQfwSSaECfOSlROL5O1FHfITEWnKqUE8cvB9T5PPjirTAOMnWmZdjsUCwl1g4kPPr XUPv7VEcFM2DmgpmjLKv4cmbNnZ/u/O0jZo4fu3vmcnnzDdkB8qyMAD8QUQsW3EriGRk ZuK+8EDXiwWgHqRMyWcUdrrzbS0u3BRBjDKaM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ln0rqCYelsyqtkFalmwSESWUlyrC6dhevN9AgMvP0es=; b=UYA44PT2/eNF6It1EXFAWp3FY6sCWfQ4EA1wvBiBMtWmZ6XW9NTlyvSybR+IhLeVfM EAmlSPF2aM4ho4GqSfshmTJQmQkYGL0nObGfKO5rtynpCikMT88jPNf/Fw9/1IuMKin9 hQAp8yCeIOyy6NXPZi2SYDhOr8jlvl6gMuxfcd5ebdvuRa6bsePoFkKAcNzNlocsJxIA mokQUIVJsHZE3K9FBmVuemw5c/0Zc26H6uGRpNcimPBSxvm8mkv4uTAUy+MormX7XOpy O9yzuDGWfIu07oRsyc6jECTxOIpvSAMkhQJ/44rms9T0sCVRJqYPo6oipjieGYgO5KC4 fkKA== X-Gm-Message-State: AOAM530c91MmxaUur3GZxc+A82wZRTwY3Ta9q7nf+40eEFbl5mRWnddR xfFC8K1pVXujB6FO7j7bvSEA5BJncrTsig== X-Google-Smtp-Source: ABdhPJzU30SBG9774C0ns94UlrVr9DP2JSx840gvG3w+l9YMEqVbY4HySKFBoSivxiT/aZoQKW8GKQ== X-Received: by 2002:a37:8906:: with SMTP id l6mr5316267qkd.210.1624380853865; Tue, 22 Jun 2021 09:54:13 -0700 (PDT) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com. [209.85.222.170]) by smtp.gmail.com with ESMTPSA id a134sm13222356qkg.114.2021.06.22.09.54.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Jun 2021 09:54:13 -0700 (PDT) Received: by mail-qk1-f170.google.com with SMTP id bj15so39420233qkb.11 for ; Tue, 22 Jun 2021 09:54:12 -0700 (PDT) X-Received: by 2002:a25:2405:: with SMTP id k5mr5864261ybk.405.1624380851918; Tue, 22 Jun 2021 09:54:11 -0700 (PDT) MIME-Version: 1.0 References: <20210621235248.2521620-1-dianders@chromium.org> <20210621165230.4.Id84a954e705fcad3fdb35beb2bc372e4bf2108c7@changeid> In-Reply-To: From: Doug Anderson Date: Tue, 22 Jun 2021 09:53:59 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/6] iommu: Combine device strictness requests with the global default To: Lu Baolu Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , "Rafael J. Wysocki" , Will Deacon , Robin Murphy , Joerg Roedel , Bjorn Andersson , Ulf Hansson , Adrian Hunter , Bjorn Helgaas , Rob Clark , LKML , Saravana Kannan , linux-arm-msm , Linux MMC List , quic_c_gdjako@quicinc.com, "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , linux-pci@vger.kernel.org, Joel Fernandes , Rajat Jain , Sonny Rao , Veerabhadrarao Badiganti Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, On Mon, Jun 21, 2021 at 7:05 PM Lu Baolu wrote: > > On 6/22/21 7:52 AM, Douglas Anderson wrote: > > @@ -1519,7 +1542,8 @@ static int iommu_get_def_domain_type(struct device *dev) > > > > static int iommu_group_alloc_default_domain(struct bus_type *bus, > > struct iommu_group *group, > > - unsigned int type) > > + unsigned int type, > > + struct device *dev) > > { > > struct iommu_domain *dom; > > > > @@ -1534,6 +1558,12 @@ static int iommu_group_alloc_default_domain(struct bus_type *bus, > > if (!dom) > > return -ENOMEM; > > > > + /* Save the strictness requests from the device */ > > + if (dev && type == IOMMU_DOMAIN_DMA) { > > + dom->request_non_strict = dev->request_non_strict_iommu; > > + dom->force_strict = dev->force_strict_iommu; > > + } > > + > > An iommu default domain might be used by multiple devices which might > have different "strict" attributions. Then who could override who? My gut instinct would be that if multiple devices were part of a given domain that it would be combined like this: 1. Any device that requests strict makes the domain strict force strict. 2. To request non-strict all of the devices in the domain would have to request non-strict. To do that I'd have to change my patchset obviously, but I don't think it should be hard. We can just keep a count of devices and a count of the strict vs. non-strict requests? If there are no other blockers I'll try to do that in my v2. -Doug