From: Stephen Boyd <firstname.lastname@example.org>
Cc: email@example.com, firstname.lastname@example.org,
email@example.com, firstname.lastname@example.org, email@example.com,
Subject: Re: [PATCH v4 1/2] drm/msm/dp: handle irq_hpd with sink_count = 0 correctly
Date: Fri, 21 May 2021 13:54:14 -0700 [thread overview]
Message-ID: <CAE-0n50qKmGUZn6nP-J=BfVA3cUnJ5vPBj2_Z=nCAwRBe3cYEQ@mail.gmail.com> (raw)
Quoting firstname.lastname@example.org (2021-05-21 12:45:35)
> On 2021-05-21 12:18, Stephen Boyd wrote:
> > Quoting email@example.com (2021-05-21 08:21:58)
> >> >
> >> > Ok. So you're saying that we want to put both events on the queue
> >> > regardless, and put IRQ_HPD there first because we want to check the
> >> > status bit? Doesn't reading the status bit require the dongle to be
> >> > connected though? So if an unplug came in along with an irq_hpd we may
> >> > queue both the irq_hpd and the unplug, but when it comes time to
> >> > process
> >> > the irq_hpd in the kthread the link will be gone and so trying the dpcd
> >> > read for the link status will fail?
> >> >
> >> yes,
> >> we had a previous bug with this scenarios already.
> >> https://partnerissuetracker.corp.google.com/issues/170598152
> >> At this case, dongle produce two interrupts, irq_hpd followed by
> >> unplug
> >> immediately (not presented at isr status register at same time), at
> >> the
> >> time dongle unplugged form DTU.
> >> But due to dp ctrl reset at handling irq_hpd which cause unplug mask
> >> bit
> >> be cleared so that unplug interrupt got lost.
> > Again, wouldn't that be too late if the hardirq handler is delayed to
> > the point that the two irqs are pending in the isr status register?
> but that not much dp driver can do.
> As long as DP driver can recovery (shut down gracefully) and ready for
> next plugin, then i think it should be fine.
Yes. I'm trying to make the point that the least the DP driver could do
would be to mask the interrupts for HPD IRQ when unplug irq happens at
hardirq context and also ignore HPD IRQ when unplug is also there. And
going even further, it feels like we should only enable the unplug irq
once a plug in irq happens, and vice versa, so that we don't get into
the case where a super long delayed irq sees all three bits: plug,
unplug, and hpd irq.
next prev parent reply other threads:[~2021-05-21 20:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 17:35 [PATCH v4 1/2] drm/msm/dp: handle irq_hpd with sink_count = 0 correctly Kuogee Hsieh
2021-05-18 21:42 ` Stephen Boyd
2021-05-19 16:01 ` khsieh
2021-05-19 21:06 ` Stephen Boyd
2021-05-20 16:08 ` khsieh
2021-05-20 19:28 ` Stephen Boyd
2021-05-20 20:05 ` khsieh
2021-05-20 21:28 ` Stephen Boyd
2021-05-20 22:39 ` khsieh
2021-05-21 5:00 ` Stephen Boyd
2021-05-21 15:21 ` khsieh
2021-05-21 19:18 ` Stephen Boyd
2021-05-21 19:45 ` khsieh
2021-05-21 20:54 ` Stephen Boyd [this message]
2021-05-20 20:36 ` khsieh
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).