From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C16CC636CD for ; Fri, 16 Jul 2021 21:49:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2FA6613F5 for ; Fri, 16 Jul 2021 21:49:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236046AbhGPVwO (ORCPT ); Fri, 16 Jul 2021 17:52:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235859AbhGPVwN (ORCPT ); Fri, 16 Jul 2021 17:52:13 -0400 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DCC6C061762 for ; Fri, 16 Jul 2021 14:49:17 -0700 (PDT) Received: by mail-ot1-x333.google.com with SMTP id 42-20020a9d012d0000b02904b98d90c82cso11345578otu.5 for ; Fri, 16 Jul 2021 14:49:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=GQDiZqD2pdLaFLvt6YO5hNfdrLCG8I79aRHQBk9fUg8=; b=A1voHxkPWVXJ574pJpTR3a+8/EmLeYnM6Vnn+05dnKzAXUHI0NNt/AmTnpGtPl9DpI y3D+IC2/VJ2Xbp2y2Kp9lms2SVOWSCfXVGx7zDVcTzmdVn8N2dyV1gSZSvRB1XcfthF+ BVHvXjKEIr/6DUBT73WFwVXNgTkJEx2XlsnNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=GQDiZqD2pdLaFLvt6YO5hNfdrLCG8I79aRHQBk9fUg8=; b=ZRv7wzQzHoje2EKO/DFWLHoDN4hrJgfD+JsLAWijr89uDWBff8kLKWvuBj4QQnVpQL WiMgzBjddeD2yQNZcmwGkM6i2JW89ls/kGMF0fbxQDY3TNxLv41+3UYVcwu2m1uSRWY1 uMwmS9Tpmg3mjnsiXHaP9mwS+BEmOPmWp/YPpdkpU+0txVzvqZ1EN5JfZnS4Gk8qf8Wz f8NDq4/4MrIx83dYlmjy2MXEV1bTmugx8bFre/W1/tvpejZCHXc0MBwqyTnw/SUIv0OK lbkLSC1vTuMifFKFy2i1q9c0vtTAKzx31EkJhQ9Owq1bgUqjxm+mdjRkRqZ1oWkHzQ+S 9BHA== X-Gm-Message-State: AOAM530XdXw9Oj5u9Fl2+k23m/w9OUSg/cx7KKrS3/DtKLtcbYw/T8FC z1YpZWCByaRKAFR3/FO9TTxONBryydGd7OG/B8Lu0A== X-Google-Smtp-Source: ABdhPJwlEwvL0WjNbQUy+fXj6ZREuGVXfD0zE/qGrqA2YbvgWdQaHCOUy4fpVloWIh9CgMJba4/mUUCebsPCHWXxZ+Y= X-Received: by 2002:a9d:650e:: with SMTP id i14mr9744534otl.233.1626472156558; Fri, 16 Jul 2021 14:49:16 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 16 Jul 2021 23:49:16 +0200 MIME-Version: 1.0 In-Reply-To: References: <1626429658-18961-1-git-send-email-rnayak@codeaurora.org> <1626429658-18961-3-git-send-email-rnayak@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Fri, 16 Jul 2021 23:49:16 +0200 Message-ID: Subject: Re: [PATCH v4 2/2] arm64: dts: sc7180: Add required-opps for i2c To: Bjorn Andersson Cc: Rajendra Nayak , ulf.hansson@linaro.org, viresh.kumar@linaro.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, rojay@codeaurora.org, stephan@gerhold.net Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Bjorn Andersson (2021-07-16 13:52:12) > On Fri 16 Jul 15:21 CDT 2021, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2021-07-16 13:18:56) > > > On Fri 16 Jul 05:00 CDT 2021, Rajendra Nayak wrote: > > > > > > > qup-i2c devices on sc7180 are clocked with a fixed clock (19.2 MHz) > > > > Though qup-i2c does not support DVFS, it still needs to vote for a > > > > performance state on 'CX' to satisfy the 19.2 Mhz clock frequency > > > > requirement. > > > > > > > > > > Sounds good, but... > > > > > > > Use 'required-opps' to pass this information from > > > > device tree, and also add the power-domains property to specify > > > > the CX power-domain. > > > > > > > > > > ..is the required-opps really needed with my rpmhpd patch in place? > > > > > > > Yes? Because rpmhpd_opp_low_svs is not the lowest performance state for > > CX. > > On e.g. sm8250 the first available non-zero corner presented in cmd-db > is low_svs. Indeed. On sc7180 it's not the first non-zero corner. I suppose retention for CX isn't actually used when the SoC is awake so your rpmhpd patch is putting in a vote for something that doesn't do anything at runtime for CX? I imagine that rpmh only sets the aggregate corner to retention when the whole SoC is suspended/sleeping, otherwise things wouldn't go very well. Similarly, min_svs may be VDD minimization? If so, those first two states are basically states that shouldn't be used at runtime, almost like sleep states. > > And if this (which?) clock requires a higher corner than the lowest > possible in order to tick at this "lowest" frequency, I'm certainly > interested in some more details. >