From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D155CC4743D for ; Fri, 4 Jun 2021 21:54:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADA4D613B4 for ; Fri, 4 Jun 2021 21:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbhFDVz7 (ORCPT ); Fri, 4 Jun 2021 17:55:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229668AbhFDVz6 (ORCPT ); Fri, 4 Jun 2021 17:55:58 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F240AC061766 for ; Fri, 4 Jun 2021 14:53:55 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id q9-20020a9d66490000b02903c741e5b703so9377121otm.0 for ; Fri, 04 Jun 2021 14:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=3DYU5t9nuzfAYYmhd6HSphs3gWfN50+sEv5DeMPpACI=; b=D5ZewtXrnc2df+El9ZmfGqxur9CwKbv7QtTt11dEm496Zbj/vpTj51UtzaxzEAXBr6 L/eHi2e9aQCgj07t/dd+/GotaJPivYRZhFgcCJu2sGoi+af6wI6H/qjcliSmLtHLr3MF rkfGTjIHp7q8uBfn3aCI/FAuKpt6Yx53rawIc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=3DYU5t9nuzfAYYmhd6HSphs3gWfN50+sEv5DeMPpACI=; b=rZtkUzCjcPbutKEXXl4ObmB/77i0m06kQbk+gYncWajxe8UZzLRB5j3kslc7hlQFYW N9Ub2nlpjSQdrVoaUsRdo+MoiAUJwmpKeeAAX6y5cgNO5rM5iS5XbzJxxJ8kPZfB4+px AEUyLew4yRu3kqawpcWdxCMKw0CO3oWCYOw64uWeMHXqwAD+ko9vHV6npeqbVdnmem+F DcesFZ0g2S1p2mblWuee7UsWEeSlmv/th5GdKxtM6+DcPnqNN8Xjr+g6SFiNja3bx0pz mpiBx7iHZJxlScU8vwa9Dig/dMbCXvqZhxCKmSOUrxz78XIvQ4utk+8kmr8Ym1EbNXkW n9FA== X-Gm-Message-State: AOAM532q8y0wtM1L9JJpPoQRbNxCTscoKljUZ8+E8j2AoUJjIydd4vmi 1vnVlsyd+klhvvM1GQ/iuRRvd3lF0nnn0lYXLVkmkQ== X-Google-Smtp-Source: ABdhPJzIN2HfxqmojBCJq27yYqlMih2sw4bfo6I3KvfxVP/kroq1o9U9zXFAQ7Q5SdEXUbDSz1CAhW5dVGm8SShsQzY= X-Received: by 2002:a05:6830:3154:: with SMTP id c20mr5439195ots.233.1622843635345; Fri, 04 Jun 2021 14:53:55 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 4 Jun 2021 21:53:54 +0000 MIME-Version: 1.0 In-Reply-To: References: <1621596371-26482-1-git-send-email-mkshah@codeaurora.org> <1621596371-26482-4-git-send-email-mkshah@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Fri, 4 Jun 2021 21:53:54 +0000 Message-ID: Subject: Re: [PATCH v8 3/5] arm64: dts: qcom: sc7180: Enable SoC sleep stats To: Bjorn Andersson Cc: Maulik Shah , evgreen@chromium.org, mka@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, agross@kernel.org, dianders@chromium.org, linux@roeck-us.net, rnayak@codeaurora.org, lsrao@codeaurora.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Bjorn Andersson (2021-06-02 19:44:40) > On Wed 02 Jun 19:26 CDT 2021, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2021-05-31 10:57:03) > > > On Wed 26 May 18:30 CDT 2021, Stephen Boyd wrote: > > > > > > > Quoting Maulik Shah (2021-05-21 04:26:09) > > > > > @@ -3223,6 +3223,11 @@ > > > > > #power-domain-cells = <1>; > > > > > }; > > > > > > > > > > + rpmh-sleep-stats@c3f0000 { > > > > > + compatible = "qcom,rpmh-sleep-stats"; > > > > > + reg = <0 0x0c3f0000 0 0x400>; > > > > > + }; > > > > > + > > > > > > > > Does this need to be in DT? Can the sc7180-aoss-qmp driver use the > > > > aux-bus and stick the sleep stats device on there? > > > > > > > > > > The AOSS memory space has N chunks of "message ram", one is used for the > > > QMP protocol (presumably the APSS specific one), a different one is used > > > for the sleep stats. > > > > > > I presume we could have come up with a binding for the entire AOSS/AOP > > > and then describe (either implicit or explicitly) the QMP and > > > debug-stats under that. > > > > > > But we'd also have to come up with the same container-device for the RPM > > > case. > > > > Because the rpm node doesn't include this region of memory today? I > > still fail to see why we're changing the existing binding and adding a > > DT node for this new region that is basically a debug feature. > > We're not changing the binding, the memory region for the "AOSS QMP" > thing was never larger than 0x400. > > 0x100000 is the size of all the AOSS "msg_ram" regions. We don't have > this whole thing described in a binding and we don't have an > implementation for the whole thing. > > If we're going for that we'd need to extend the binding to indicate > which of the msg_ram regions are used for APSS QMP and for debug stats > on particular platform (either by compatible, explicit properties or as > some subnodes). Fair enough. At the least, can we change the name of the node then to 'sram' or 'ram'? The 'rpmh-sleep-stats' node name is nonsense. > > > That said, as I looked into my other objection, for the RPM > (non-hardened) case it seems that we're actually describing the RPM > region. So there it would make sense to describe it as such in DT - but > we don't have any other code (that I'm aware of) that would implement > the "qcom,-rpm". > I only half parsed this part. Are you saying that because we don't have a driver for qcom,-rpm we shouldn't keep it all within the rpm node?