From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F7BAC4320E for ; Wed, 1 Sep 2021 05:04:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFFE661074 for ; Wed, 1 Sep 2021 05:04:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241894AbhIAFFi (ORCPT ); Wed, 1 Sep 2021 01:05:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241865AbhIAFFh (ORCPT ); Wed, 1 Sep 2021 01:05:37 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5DF98C061764 for ; Tue, 31 Aug 2021 22:04:41 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id v2so2256233oie.6 for ; Tue, 31 Aug 2021 22:04:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=p8e7JkeHrWXVLh1MnUKItckaxSfNSDYY50SArchtkhg=; b=iKhQHWUjGc6kitjMj/4aFfuK5hnjf85PJAuyGFLfsjm98jwSTCo3WJkM+6B9rnZrJ3 XeCNcTCH+Bjt/19WnqWb+OJPAfRifb+a1avCcNV8SuV/uHWG2smfn6A3grVkODpxHHVF hhDapZ/sEKcFkBAJTbyLASirtrHoX+gvIwLRg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=p8e7JkeHrWXVLh1MnUKItckaxSfNSDYY50SArchtkhg=; b=TlMHwBVuT8ohMTOWxiGM+d6NBfaM76bjmzqDmeuO7CLmW8qFEBzw6ITFY6aifWrNuo Pmn9pK8w9jPrvvrf6PfaXAlS6D4IQGYHrPc6lF0U2tllXb55HPyf5rHbhy3RcHR2AQ65 ncKvhU4/ac1syXN65yyMzZnSXIxutKKNcpw5RRnPKXv/Bbru7yuMbugBVDW8NCeDpI4i GLaGyW93o5QLeluQaGtlI0yfdDkjzC5XQNscf8RTg3CDIMje2L2KWmnsxDjDWtuPSkkT iNTRYeTi8sehRjGtK0XM/Q4yRXuzp/BHuaUZXNgyQbY/yYYefNoremuvUaWf0uUrOMfa fZIA== X-Gm-Message-State: AOAM530v8LTV6rHhDQu4obVRf8qe/uB9CoDtgzPnQKkiM64MDoPZcm9o ZKZeCoGEj0dCh0AL2fLq59mDHmAJRntYJSbuAdWFCg== X-Google-Smtp-Source: ABdhPJyTV7/lFyg1x6j69L4Ied61ZtzKWwbVYP+niMFttTrFi7QCrPGoum+eE0eBzLOBShQH1PQbNpCyZnVyoyHSUpc= X-Received: by 2002:a05:6808:909:: with SMTP id w9mr5913567oih.164.1630472680751; Tue, 31 Aug 2021 22:04:40 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 31 Aug 2021 22:04:40 -0700 MIME-Version: 1.0 In-Reply-To: <18995b9913c9acb7880b01a4f61ee5d0@codeaurora.org> References: <1629983731-10595-1-git-send-email-rajpat@codeaurora.org> <1629983731-10595-7-git-send-email-rajpat@codeaurora.org> <18995b9913c9acb7880b01a4f61ee5d0@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Tue, 31 Aug 2021 22:04:40 -0700 Message-ID: Subject: Re: [PATCH V6 6/7] arm64: dts: sc7280: Add QUPv3 wrapper_1 nodes To: rajpat@codeaurora.org Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, rnayak@codeaurora.org, saiprakash.ranjan@codeaurora.org, msavaliy@qti.qualcomm.com, skakit@codeaurora.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting rajpat@codeaurora.org (2021-08-31 08:28:51) > On 2021-08-26 23:41, Stephen Boyd wrote: > > Quoting Rajesh Patil (2021-08-26 06:15:30) > >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > >> b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > >> index 7c106c0..65126a7 100644 > >> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > >> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > >> @@ -225,6 +225,10 @@ > >> status = "okay"; > >> }; > >> > >> +&qupv3_id_1 { > >> + status = "okay"; > >> +}; > >> + > > > > Why enable this here but not any of the i2c/spi/uart devices that are a > > child? Can this hunk be split off to a different patch? > > > > Currently there is no usecase on qup1 and hence not enabled. > Regarding splitting this, I did not get the exact reason why we need to > split. This patch adds all the qup wrapper1 nodes and we are enabling it > in board file. I'm happy to see this part dropped from the patch. If nothing is enabled that's a child of the qup then enabling it serves no purpose.