From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8AF7C07E95 for ; Wed, 7 Jul 2021 22:48:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFA6561CCA for ; Wed, 7 Jul 2021 22:48:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbhGGWvC (ORCPT ); Wed, 7 Jul 2021 18:51:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39282 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230109AbhGGWuy (ORCPT ); Wed, 7 Jul 2021 18:50:54 -0400 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4C16C061760 for ; Wed, 7 Jul 2021 15:48:12 -0700 (PDT) Received: by mail-ot1-x331.google.com with SMTP id o17-20020a9d76510000b02903eabfc221a9so3959233otl.0 for ; Wed, 07 Jul 2021 15:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=TlJ0F5dHSC5zR5+dmIIRirAimmk6emojztfdcHPFyhM=; b=iMgiT/t2DG9+L36g6Z700bppQIeVqoM9zkbhhy9SIfRX4frPRyU+ouQTFXMl2R0sPJ LgFhnvvMRiiZj8S2wa4NJ8Vz/mvohesUF9FmRmrKoQBLP8NAEICnfegtJAZyEZci1MnR YXNnhH4XnQ6qFU9A6Nak7+ldW82JmnVqr9Ne0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=TlJ0F5dHSC5zR5+dmIIRirAimmk6emojztfdcHPFyhM=; b=ZCrPBNVRMR8CJo3kE0Y3RcjVGympEie51Fa9Aybpoo9KrDr3TESIRLt6j4BdG+V7/K OHfFdidG5fIJ9h0tR0Ul1W5APGebDVhAFIqo8UVbu9D901nX+lq/vOnpCnbibnnjmLxg zD5tmRMKvDARY4xdblDw/ZnYlwin+CY9MfP/V8HR8q1DNk+rtnyko+3MKfBv7Tcnztqe T0yi4AjyW7w+cIfPBUYrH0ojDVX+oB2mMKieEbLkd6cmJ2AcBJOQx3yUiZQJSYZqaUnq BuEmGXYaypTRVDwvJPX07AAkUOYPETaCdFRVp46NTU0Ckg+oJWAJyPyAFU8jfopafLkt QMNw== X-Gm-Message-State: AOAM530GMlQQSeOPctMEJ2I+Pap81lpQJEDD8bbKuZG9zTHe7wQbfpnz Zr8H8Ky2iNhwzjT0lMGn8oZ6rsP//h53/YLr/4LMRA== X-Google-Smtp-Source: ABdhPJyK2J6zY8vd+mAvTD6S4Q34neALxBbIk2xo/Gd2aFsHatAbSL4Frt0t2jEEBoiHqPWNmkE4CS05ggxrMn4Vy0o= X-Received: by 2002:a9d:2781:: with SMTP id c1mr20809050otb.34.1625698092020; Wed, 07 Jul 2021 15:48:12 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 7 Jul 2021 22:48:11 +0000 MIME-Version: 1.0 In-Reply-To: <20210707074517.2775-1-thunder.leizhen@huawei.com> References: <20210707074517.2775-1-thunder.leizhen@huawei.com> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Wed, 7 Jul 2021 22:48:11 +0000 Message-ID: Subject: Re: [PATCH 1/1] media: venus: hfi: fix return value check in sys_get_prop_image_version() To: Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Stanimir Varbanov , Zhen Lei , linux-arm-msm , linux-kernel , linux-media Cc: Dikshita Agarwal Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Zhen Lei (2021-07-07 00:45:17) > In case of error, the function qcom_smem_get() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check > should be replaced with IS_ERR(). > > Fixes: d566e78dd6af ("media: venus : hfi: add venus image info into smem") > Reported-by: Hulk Robot > Signed-off-by: Zhen Lei > --- Reviewed-by: Stephen Boyd