From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AF69C433B4 for ; Sat, 8 May 2021 07:58:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3205A61432 for ; Sat, 8 May 2021 07:58:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229752AbhEHH7P (ORCPT ); Sat, 8 May 2021 03:59:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229701AbhEHH7O (ORCPT ); Sat, 8 May 2021 03:59:14 -0400 Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADE28C061761 for ; Sat, 8 May 2021 00:58:13 -0700 (PDT) Received: by mail-oi1-x22d.google.com with SMTP id k25so10972235oic.4 for ; Sat, 08 May 2021 00:58:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to; bh=Uw9Olfn2D8yzVfU3MJmVflzhzFabExtk1M2ft9XYJsU=; b=ODWfTkzhtdY+iO1STfLTqoWZo1FgeWy/Rh+y88jZXZOuUKRyhbe10GSJvCa//KzEG6 oq4Y/yFABv678zU21xy2Sv8WfudBkEnCN+Jz+CoVy2jYLU3m5juKT7bn2CbPODwg/RiA JjAKRoZkexVzG2VEOb8nxJlTl4N5fwDQsW5jI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to; bh=Uw9Olfn2D8yzVfU3MJmVflzhzFabExtk1M2ft9XYJsU=; b=ciHQmv1xtMzOTNAw0O4OMI5GiUusYUK9MLCGB0SiUGXWkE46jPBLpzYrwhUKjBCKw7 vitCcSvXNPsNRIbZbnbaIztZop8owNDbGVYoPXdZSSDjRY5zpEzlItqeEty8aw+TKqAu vgSBjMgV7zM7CtkMxr1nysTL5rcHsOLAk/5vTI+IsJWXeYFfAVHQz5L24xeCRT9qs8jA bO7tR4fRVIiHQZirUr8RfrGzlFWr+YjMmFlVwVmOfrDcGsxF+50fVAGa5hW7WHMkjmKt CmJlxjeOanO7+6OsThrs6EMm3WhpEe1djRWUgUcA/+VM23fXdQ7Y7q6+7sgDn53nUdH4 xNbA== X-Gm-Message-State: AOAM531qzNZgTaT1ZuNUouYuK5me6vq82kNxd0w/ZVnT+8Twf6kgQeJZ 67l55y4tZILjmcgwn235rV00y7O2a5hUTkJet7QGPQ== X-Google-Smtp-Source: ABdhPJzrNGN1d3ArMyBqXNzK81NAUjTSujijWd+FBZXWmyAwv5ebCgCLG+Xb0meYDyj+0NecXnNTw7K8ngzlJGc3SWE= X-Received: by 2002:aca:654d:: with SMTP id j13mr17878718oiw.125.1620460693146; Sat, 08 May 2021 00:58:13 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 8 May 2021 03:58:12 -0400 MIME-Version: 1.0 In-Reply-To: <4f6ab4db-958d-c2c5-7879-aa9a0d3b87ae@huawei.com> References: <20210508024254.1877-1-thunder.leizhen@huawei.com> <4f6ab4db-958d-c2c5-7879-aa9a0d3b87ae@huawei.com> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Sat, 8 May 2021 03:58:12 -0400 Message-ID: Subject: Re: [PATCH 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init() To: Daniel Vetter , David Airlie , Leizhen , Rob Clark , Sean Paul , dri-devel , freedreno , linux-arm-msm , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Leizhen (ThunderTown) (2021-05-08 00:55:04) > > > On 2021/5/8 14:09, Stephen Boyd wrote: > > Quoting Zhen Lei (2021-05-07 19:42:54) > >> Fix to return a negative error code from the error handling case instead > >> of 0, as done elsewhere in this function. > >> > >> Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip") > >> Reported-by: Hulk Robot > >> Signed-off-by: Zhen Lei > >> --- > >> drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c > >> index 06b56fec04e0..1b6c9fb500a1 100644 > >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c > >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c > >> @@ -253,8 +253,10 @@ int dpu_mdss_init(struct drm_device *dev) > >> goto irq_domain_error; > >> > >> irq = platform_get_irq(pdev, 0); > >> - if (irq < 0) > >> + if (irq < 0) { > >> + ret = irq; > >> goto irq_error; > >> + } > > > > It would be even better if ret wasn't assigned to 0 at the start of this > > function. > > The returned error code is not unique. > What does it mean? I was saying this ----8<---- diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c index cd4078807db1..0fcf190f6322 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c @@ -263,7 +263,7 @@ int dpu_mdss_init(struct drm_device *dev) struct msm_drm_private *priv = dev->dev_private; struct dpu_mdss *dpu_mdss; struct dss_module_power *mp; - int ret = 0; + int ret; int irq; dpu_mdss = devm_kzalloc(dev->dev, sizeof(*dpu_mdss), GFP_KERNEL); @@ -297,8 +297,10 @@ int dpu_mdss_init(struct drm_device *dev) goto irq_domain_error; irq = platform_get_irq(pdev, 0); - if (irq < 0) + if (irq < 0) { + ret = irq; goto irq_error; + } irq_set_chained_handler_and_data(irq, dpu_mdss_irq, dpu_mdss); @@ -309,7 +311,7 @@ int dpu_mdss_init(struct drm_device *dev) dpu_mdss_icc_request_bw(priv->mdss); - return ret; + return 0; irq_error: _dpu_mdss_irq_domain_fini(dpu_mdss);