From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8C07C433B4 for ; Fri, 7 May 2021 19:59:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2ACA61430 for ; Fri, 7 May 2021 19:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230093AbhEGUAE (ORCPT ); Fri, 7 May 2021 16:00:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230083AbhEGUAC (ORCPT ); Fri, 7 May 2021 16:00:02 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 142FBC061761 for ; Fri, 7 May 2021 12:59:02 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id i81so9778155oif.6 for ; Fri, 07 May 2021 12:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=1Ev/AqlCuAuxmBP5/qpJD12HiDRJtO97+BpGUTNb6rM=; b=RM1pf/f5OHyMOspoU/mxDuhXfnGnk3N8Yt8iAD4/3qGiKa4Fpl6bFuqYYK685F0Qra j8l4Cdm6WePTc6xFMcFqIo7HauGjPoWbTmrp6GAgwIoLWlji8gU0eIySUu6XUkEWj9lx +6yw0GzV2Jzll+k5Jsa9Mvf6StSpabvsVYU0E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=1Ev/AqlCuAuxmBP5/qpJD12HiDRJtO97+BpGUTNb6rM=; b=PvknxMz5v+KfP/pBh5AYBa2o1fNialFB669KoFnlLvvMg04ytC9CdqsGISK9eL4UAL +4iOTSF2GVf3PO1M3dANzT4jqzL33TdRl7bZuRxie3Mcv/BsQSvQ9B2xyDOrd7zAu2uN bpZHnlozjSqMjklH5d8kMUXCsecKpRxCJE6a6Ss5HEmnuqmwbUD9iPcQ7KK19cjnYoN5 PWW2qJqCiyG9HLFvSfgnKeNUSxG2V8TEGCqggnWatV1gv+Ks/XKlNmofdK0SN0oB/r34 RAlvgxRdjOVpdVGHmmsgPEntxIE84uytRGwODXlC9RAgiyAuvP22467ND+96e4/iGLIp sCLg== X-Gm-Message-State: AOAM5312dhGzOX76CgaXdbhMZYjUZfy1U4JR2kCwOnRAQypR+A4/DZ8m M1S35ibHSNPRKzexIUT3LXZtx/qSjqXwpX8h/PiBjA== X-Google-Smtp-Source: ABdhPJwYQ0v6l65w9JuRCI64AGgQD1xZrXIhLQyHL/uOFiEknxIY9lk8wZUueo2xEF0siVW3cor1TnMZGmvB6RmCAog= X-Received: by 2002:aca:211a:: with SMTP id 26mr8203109oiz.19.1620417541429; Fri, 07 May 2021 12:59:01 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 7 May 2021 12:59:00 -0700 MIME-Version: 1.0 In-Reply-To: <1620382648-17395-2-git-send-email-pmaliset@codeaurora.org> References: <1620382648-17395-1-git-send-email-pmaliset@codeaurora.org> <1620382648-17395-2-git-send-email-pmaliset@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Fri, 7 May 2021 12:59:00 -0700 Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: pci: qcom: Document PCIe bindings for SC720 To: Andy Gross , Bjorn Andersson , Bjorn Helgaas , Prasad Malisetty , Rob Herring Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, mgautam@codeaurora.org, dianders@chromium.org, mka@chromium.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Prasad Malisetty (2021-05-07 03:17:26) > Document the PCIe DT bindings for SC7280 SoC.The PCIe IP is similar > to the one used on SM8250. Add the compatible for SC7280. > > Signed-off-by: Prasad Malisetty > --- > Documentation/devicetree/bindings/pci/qcom,pcie.txt | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt b/Documentation/devicetree/bindings/pci/qcom,pcie.txt > index 0da458a..e5245ed 100644 > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt > @@ -12,6 +12,7 @@ > - "qcom,pcie-ipq4019" for ipq4019 > - "qcom,pcie-ipq8074" for ipq8074 > - "qcom,pcie-qcs404" for qcs404 > + - "qcom,pcie-sc7280" for sc7280 > - "qcom,pcie-sdm845" for sdm845 > - "qcom,pcie-sm8250" for sm8250 > > @@ -133,6 +134,22 @@ > - "slave_bus" AXI Slave clock > > - clock-names: > + Usage: required for sc7280 > + Value type: > + Definition: Should contain the following entries > + - "aux" Auxiliary clock > + - "cfg" Configuration clock > + - "bus_master" Master AXI clock > + - "bus_slave" Slave AXI clock > + - "slave_q2a" Slave Q2A clock > + - "tbu" PCIe TBU clock > + - "ddrss_sf_tbu" PCIe SF TBU clock > + - "pipe" PIPE clock > + - "pipe_src" PIPE MUX Is pipe_src necessary? Is it the parent of the pipe clk? If so, please remove it and do whatever is necessary on the pipe clk instead of the parent of the clk. > + - "pipe_ext" PIPE output clock Is pipe output different from pipe? > + - "ref" REFERENCE clock > + >