From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E77C433F5 for ; Tue, 21 Sep 2021 01:32:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D14460F43 for ; Tue, 21 Sep 2021 01:32:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229990AbhIUBdf (ORCPT ); Mon, 20 Sep 2021 21:33:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229965AbhIUBd3 (ORCPT ); Mon, 20 Sep 2021 21:33:29 -0400 Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88E6DC0430CC for ; Mon, 20 Sep 2021 12:52:00 -0700 (PDT) Received: by mail-ot1-x32b.google.com with SMTP id l16-20020a9d6a90000000b0053b71f7dc83so25159996otq.7 for ; Mon, 20 Sep 2021 12:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=QR+41d2CWnF6y8POX2yCYnotLJD1rZ1O8icCQ6F8e+Y=; b=XuHIYliUFLKnsbgeeINNatgMmsCdIboPP8+sAg9LU+cvRVtTq7lOTS7H4haZNHxvM9 p1N88SB3352wydMgXNSFCzuDo1DZcDyV0oK/h/kEhNHzNJY4QOT/B0F4P7Or8YCoOR13 O91X05MpZ4Ws801ghrVoeaLbpMLQaIZh4DV4Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=QR+41d2CWnF6y8POX2yCYnotLJD1rZ1O8icCQ6F8e+Y=; b=xtWMW3Pf6cDHKsv5ux4RmEcNd5K/KW+tbX7UaTeRM/+mGLuQhV+3IhXANueaFkQnkQ 0EyyUPGO3VRX8Vl0Krj/FvvZt/RdjVAmF1STS8RAgDwLZw8p5M1n1+8rWKVp2/lLj5R/ 4GhPt3avuh4UmI5L3gM7Tnyua1suenm9CnWl6xwdUK975bXIWWw/tXmSDQSsCoWwEqxn JJWUF6zWIPdd8waNmnG0phMeV9hmIG5uwhRbuKeiSuN25Elx3b/diqY6m7Ta1yCWa+oS kbUqNVkzo9lHaUSw/0zZi6TNQwgNIDwHmaKfk6IDmjX/6qO/elunBu6bzhyuCQC0ObJH dG5A== X-Gm-Message-State: AOAM533LEmmbuohIZuGovqOcA2QDHwiKeFi+m6/DCl9SZ7r9AuMGctUd 3JVb6qOFuc4UbPwz4PNGMw8sxLsNG+Cr4Q4wLcohGg== X-Google-Smtp-Source: ABdhPJwtIzCWSMh71giNnyYDptJRLaxEGCqlnvwoau2/hKz6p8Jc9WJ7gdkc0BAR/4i0a9R3CQlqSIDvb9uYW+loKUw= X-Received: by 2002:a05:6830:1212:: with SMTP id r18mr21399600otp.159.1632167519891; Mon, 20 Sep 2021 12:51:59 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 20 Sep 2021 12:51:59 -0700 MIME-Version: 1.0 In-Reply-To: <1631898947-27433-4-git-send-email-pmaliset@codeaurora.org> References: <1631898947-27433-1-git-send-email-pmaliset@codeaurora.org> <1631898947-27433-4-git-send-email-pmaliset@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 20 Sep 2021 12:51:59 -0700 Message-ID: Subject: Re: [PATCH v8 3/4] arm64: dts: qcom: sc7280: Add PCIe nodes for IDP board To: Prasad Malisetty , agross@kernel.org, bhelgaas@google.com, bjorn.andersson@linaro.org, lorenzo.pieralisi@arm.com, robh+dt@kernel.org, svarbanov@mm-sol.com Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, mka@chromium.org, vbadigan@codeaurora.org, sallenki@codeaurora.org, manivannan.sadhasivam@linaro.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Prasad Malisetty (2021-09-17 10:15:46) > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > index 99f9ee5..ee00df0 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi > @@ -199,6 +199,39 @@ > modem-init; > }; > > +&pcie1 { > + status = "okay"; > + > + perst-gpio = <&tlmm 2 GPIO_ACTIVE_LOW>; > + pinctrl-0 = <&pcie1_default_state &nvme_ldo_enable_pin>; > +}; > + > +&pcie1_phy { > + status = "okay"; > + > + vdda-phy-supply = <&vreg_l10c_0p8>; > + vdda-pll-supply = <&vreg_l6b_1p2>; > +}; > + > +&pcie1_default_state { > + reset-n { > + pins = "gpio2"; > + function = "gpio"; > + > + drive-strength = <16>; > + output-low; > + bias-disable; > + }; > + > + wake-n { > + pins = "gpio3"; > + function = "gpio"; > + > + drive-strength = <2>; > + bias-pull-up; > + }; I think the previous round of this series Bjorn was saying that these should be different nodes and tacked onto the pinctrl-0 list for the pcie1 device instead of adding them as subnodes of the "default state". > +}; > + > &pmk8350_vadc { > pmk8350_die_temp { > reg = ; > @@ -343,3 +376,10 @@ > bias-pull-up; > }; > }; > + > +&tlmm { > + nvme_ldo_enable_pin: nvme_ldo_enable_pin { Please use dashes where you use underscores in node names nvme_ldo_enable_pin: nvme-ldo-enable-pin { > + function = "gpio"; > + bias-pull-up; Of course with that said, the name of this node makes it sound like this is a gpio controlled regulator. Why not use that binding then and enable the regulator either by default with regulator properties like regulator-always-on and regulator-boot-enable and/or reference it from the pcie device somehow so that it can be turned off during suspend? > + }; > +};