From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 518D1C433FE for ; Tue, 5 Oct 2021 01:51:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32AAF60FE3 for ; Tue, 5 Oct 2021 01:51:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230271AbhJEBxi (ORCPT ); Mon, 4 Oct 2021 21:53:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230293AbhJEBxh (ORCPT ); Mon, 4 Oct 2021 21:53:37 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA681C06174E for ; Mon, 4 Oct 2021 18:51:47 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id j11-20020a9d190b000000b00546fac94456so24001281ota.6 for ; Mon, 04 Oct 2021 18:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=/dkkNpzviYCaFJdQwMp6k08JJ4wijyXvlqLTqGJ1jh0=; b=KZCmz7fxQrAK4JnFowRP+/GRUfcb8L4k8Iu9g8CaERdWmvQsS+RiyhmrNv9SvQFEVD T6AKEugQqWmsk78/vMnUt2wqQclXISFFYi59AYl7vZ2GtZoJF0OQYJwQVjb2P9mQb/U/ e3SbW7IIiKTlDvh5hbg3VYgXdxMEdU2XdcDCQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=/dkkNpzviYCaFJdQwMp6k08JJ4wijyXvlqLTqGJ1jh0=; b=W/GbJwe8l8BB56uLRti6ZE1KBZhl69F2ObPqpDfXR6NyMOSBR6RNWowCjA8YOG//Em fNutD/Ur5O7k/YoQIa38BOHUJ9d2m8/xEgx9n0tOh6BSv2evX6C5zGIRmPH2WiNjgHuc ToObtKt2eLAAWoFcG5TIDt75zJ5j9EWAt+jC1G9CTbyzE88UPnsk7sjXNs+h8T4vsbDL 62urguTbD/SOQpqqcHFFlaYzrZL9cogQ3cqyXVTFpxn+gQH5qOSaLo7ir468sZFzp9Y7 5116YyAmSqZWvHnvxwj+4xEnFjMhYJLcHM7u4/xu61R7vECmmaIquprw/ERyFV5X8fa7 gtCg== X-Gm-Message-State: AOAM532xUSQhw6utCOAcZpaM07qKtAUgIaiZ794YpSMGEv70Ba5/Jz0d hCw/jbHd9HQXlsSg7hkdgUVyAyeEnM5tYsQ15CFGhw== X-Google-Smtp-Source: ABdhPJzWLCe5J9N4NEvFccqk7qSekAwNhX8l0RI/XU9tNyqKDe6UT1+tzQun6F9V3idqi29P8qX/SPyM7+msx2mkAW4= X-Received: by 2002:a9d:6a0f:: with SMTP id g15mr12435757otn.126.1633398707037; Mon, 04 Oct 2021 18:51:47 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 4 Oct 2021 21:51:46 -0400 MIME-Version: 1.0 In-Reply-To: <8f344213978f31c04e80b804a931db56@codeaurora.org> References: <1629282424-4070-1-git-send-email-mkrishn@codeaurora.org> <1629282424-4070-2-git-send-email-mkrishn@codeaurora.org> <5adf2ab2c2a162272509d253bd797721@codeaurora.org> <8f344213978f31c04e80b804a931db56@codeaurora.org> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Mon, 4 Oct 2021 21:51:46 -0400 Message-ID: Subject: Re: [PATCH v1 2/4] arm64: dts: qcom: sc7280: add display dt nodes To: mkrishn@codeaurora.org Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kalyan_t@codeaurora.org, sbillaka@codeaurora.org, abhinavk@codeaurora.org, robdclark@gmail.com, bjorn.andersson@linaro.org, khsieh@codeaurora.org, rajeevny@codeaurora.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, robh+dt@kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting mkrishn@codeaurora.org (2021-09-30 23:39:07) > On 2021-09-30 23:28, Stephen Boyd wrote: > > Quoting mkrishn@codeaurora.org (2021-09-30 04:56:59) > >> On 2021-08-19 01:27, Stephen Boyd wrote: > >> > Quoting Krishna Manikandan (2021-08-18 03:27:02) > >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > >> >> b/arch/arm64/boot/dts/qcom/sc7280.dtsi > >> >> index 53a21d0..fd7ff1c 100644 > >> >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > >> >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > >> >> + > >> >> + status = "disabled"; > >> >> + > >> >> + mdp: mdp@ae01000 { > >> > > >> > display-controller@ae01000 > >> > >> Stephen, > >> In the current driver code, there is a substring comparison for > >> "mdp" > >> in device node name as part of probe sequence. If "mdp" is not present > >> in the node name, it will > >> return an error resulting in probe failure. Can we continue using > >> mdp > >> as nodename instead of display controller? > >> > > > > Can we fix the driver to not look for node names and look for > > compatible > > strings instead? It took me a minute to find compare_name_mdp() in > > drivers/gpu/drm/msm/msm_drv.c to understand what you're talking about. > > Perhaps looking for qcom,mdp5 in there will be sufficient instead of > > looking at the node name. > > Sure Stephen. I will make the necessary changes in msm_drv.c to look for > compatible string instead of node name. > Can I include these two changes (changing mdp--> display controller and > msm_drv.c changes) in a separate series ? > Sure. So you'll send the drm driver change now and we'll get the DT change after that with the more generic node name?