* [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
@ 2020-02-04 13:18 Rakesh Pillai
2020-02-07 6:41 ` Sibi Sankar
2020-03-24 17:39 ` Evan Green
0 siblings, 2 replies; 6+ messages in thread
From: Rakesh Pillai @ 2020-02-04 13:18 UTC (permalink / raw)
To: devicetree; +Cc: linux-arm-kernel, linux-kernel, linux-arm-msm, Rakesh Pillai
Add device node for the ath10k SNOC platform driver probe
and add resources required for WCN3990 on sc7180 soc.
Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 5 +++++
arch/arm64/boot/dts/qcom/sc7180.dtsi | 27 +++++++++++++++++++++++++++
2 files changed, 32 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index 388f50a..167f68ac 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -287,6 +287,11 @@
vdda-pll-supply = <&vreg_l4a_0p8>;
};
+&wifi {
+ status = "okay";
+ qcom,msa-fixed-perm;
+};
+
/* PINCTRL - additions to nodes defined in sc7180.dtsi */
&qspi_clk {
diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 8011c5f..e3e8610 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -75,6 +75,11 @@
reg = <0x0 0x80900000 0x0 0x200000>;
no-map;
};
+
+ wlan_fw_mem: memory@93900000 {
+ reg = <0 0x93900000 0 0x200000>;
+ no-map;
+ };
};
cpus {
@@ -1490,6 +1495,28 @@
#freq-domain-cells = <1>;
};
+
+ wifi: wifi@18800000 {
+ compatible = "qcom,wcn3990-wifi";
+ reg = <0 0x18800000 0 0x800000>;
+ reg-names = "membase";
+ iommus = <&apps_smmu 0xc0 0x1>;
+ interrupts =
+ <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH /* CE0 */ >,
+ <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH /* CE1 */ >,
+ <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH /* CE2 */ >,
+ <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH /* CE3 */ >,
+ <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH /* CE4 */ >,
+ <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH /* CE5 */ >,
+ <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH /* CE6 */ >,
+ <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH /* CE7 */ >,
+ <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH /* CE8 */ >,
+ <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH /* CE9 */ >,
+ <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH /* CE10 */>,
+ <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH /* CE11 */>;
+ memory-region = <&wlan_fw_mem>;
+ status = "disabled";
+ };
};
thermal-zones {
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
2020-02-04 13:18 [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Rakesh Pillai
@ 2020-02-07 6:41 ` Sibi Sankar
2020-03-24 17:39 ` Evan Green
1 sibling, 0 replies; 6+ messages in thread
From: Sibi Sankar @ 2020-02-07 6:41 UTC (permalink / raw)
To: Rakesh Pillai
Cc: devicetree, linux-arm-kernel, linux-kernel, linux-arm-msm,
linux-arm-msm-owner
Hey Rakesh,
On 2020-02-04 18:48, Rakesh Pillai wrote:
> Add device node for the ath10k SNOC platform driver probe
> and add resources required for WCN3990 on sc7180 soc.
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 5 +++++
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 27
> +++++++++++++++++++++++++++
> 2 files changed, 32 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 388f50a..167f68ac 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -287,6 +287,11 @@
> vdda-pll-supply = <&vreg_l4a_0p8>;
> };
>
> +&wifi {
> + status = "okay";
I can see that wlan needs to
add the SIDs 0xc2, 0xc3 as well.
Without that I expect wlan will
not come up.
> + qcom,msa-fixed-perm;
are you sure this is required when
used in conjunction with coreboot?
> +};
> +
> /* PINCTRL - additions to nodes defined in sc7180.dtsi */
>
> &qspi_clk {
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 8011c5f..e3e8610 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -75,6 +75,11 @@
> reg = <0x0 0x80900000 0x0 0x200000>;
> no-map;
> };
> +
> + wlan_fw_mem: memory@93900000 {
> + reg = <0 0x93900000 0 0x200000>;
> + no-map;
> + };
> };
>
> cpus {
> @@ -1490,6 +1495,28 @@
>
> #freq-domain-cells = <1>;
> };
> +
> + wifi: wifi@18800000 {
> + compatible = "qcom,wcn3990-wifi";
> + reg = <0 0x18800000 0 0x800000>;
> + reg-names = "membase";
> + iommus = <&apps_smmu 0xc0 0x1>;
> + interrupts =
> + <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH /* CE0 */ >,
> + <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH /* CE1 */ >,
> + <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH /* CE2 */ >,
> + <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH /* CE3 */ >,
> + <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH /* CE4 */ >,
> + <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH /* CE5 */ >,
> + <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH /* CE6 */ >,
> + <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH /* CE7 */ >,
> + <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH /* CE8 */ >,
> + <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH /* CE9 */ >,
> + <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH /* CE10 */>,
> + <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH /* CE11 */>;
> + memory-region = <&wlan_fw_mem>;
> + status = "disabled";
> + };
> };
>
> thermal-zones {
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
2020-02-04 13:18 [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Rakesh Pillai
2020-02-07 6:41 ` Sibi Sankar
@ 2020-03-24 17:39 ` Evan Green
2020-03-25 11:04 ` pillair
1 sibling, 1 reply; 6+ messages in thread
From: Evan Green @ 2020-03-24 17:39 UTC (permalink / raw)
To: Rakesh Pillai
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm Mailing List, LKML, linux-arm-msm
Hi Rakesh,
On Tue, Feb 4, 2020 at 5:21 AM Rakesh Pillai <pillair@codeaurora.org> wrote:
>
> Add device node for the ath10k SNOC platform driver probe
> and add resources required for WCN3990 on sc7180 soc.
>
> Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
What is the status of this? Looks like you have some feedback from
Sibi. Can you reply and spin this? Also a comment below:
> ---
> arch/arm64/boot/dts/qcom/sc7180-idp.dts | 5 +++++
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 27 +++++++++++++++++++++++++++
> 2 files changed, 32 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index 388f50a..167f68ac 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -287,6 +287,11 @@
> vdda-pll-supply = <&vreg_l4a_0p8>;
> };
>
> +&wifi {
> + status = "okay";
> + qcom,msa-fixed-perm;
> +};
> +
> /* PINCTRL - additions to nodes defined in sc7180.dtsi */
>
> &qspi_clk {
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 8011c5f..e3e8610 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -75,6 +75,11 @@
> reg = <0x0 0x80900000 0x0 0x200000>;
> no-map;
> };
> +
> + wlan_fw_mem: memory@93900000 {
> + reg = <0 0x93900000 0 0x200000>;
> + no-map;
> + };
> };
>
> cpus {
> @@ -1490,6 +1495,28 @@
>
> #freq-domain-cells = <1>;
> };
> +
> + wifi: wifi@18800000 {
> + compatible = "qcom,wcn3990-wifi";
> + reg = <0 0x18800000 0 0x800000>;
> + reg-names = "membase";
> + iommus = <&apps_smmu 0xc0 0x1>;
> + interrupts =
> + <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH /* CE0 */ >,
> + <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH /* CE1 */ >,
> + <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH /* CE2 */ >,
> + <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH /* CE3 */ >,
> + <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH /* CE4 */ >,
> + <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH /* CE5 */ >,
> + <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH /* CE6 */ >,
> + <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH /* CE7 */ >,
> + <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH /* CE8 */ >,
> + <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH /* CE9 */ >,
> + <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH /* CE10 */>,
> + <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH /* CE11 */>;
> + memory-region = <&wlan_fw_mem>;
The clocks are missing:
clocks = <&rpmhcc RPMH_RF_CLK2>;
clock-names = "cxo_ref_clk_pin";
> + status = "disabled";
> + };
> };
>
> thermal-zones {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
2020-03-24 17:39 ` Evan Green
@ 2020-03-25 11:04 ` pillair
2020-03-25 16:03 ` Evan Green
0 siblings, 1 reply; 6+ messages in thread
From: pillair @ 2020-03-25 11:04 UTC (permalink / raw)
To: 'Evan Green'
Cc: 'open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE
BINDINGS', 'linux-arm Mailing List', 'LKML',
'linux-arm-msm'
Hi Evan,
I will send out a v7 for this patchset.
Since I have to configure the S2 SIDs, it is dependent on below ath10k patchset.
https://patchwork.kernel.org/project/linux-wireless/list/?series=261367
Thanks,
Rakesh Pillai.
> -----Original Message-----
> From: Evan Green <evgreen@chromium.org>
> Sent: Tuesday, March 24, 2020 11:10 PM
> To: Rakesh Pillai <pillair@codeaurora.org>
> Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; linux-arm Mailing List <linux-arm-
> kernel@lists.infradead.org>; LKML <linux-kernel@vger.kernel.org>; linux-
> arm-msm <linux-arm-msm@vger.kernel.org>
> Subject: Re: [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN
> module device node
>
> Hi Rakesh,
>
> On Tue, Feb 4, 2020 at 5:21 AM Rakesh Pillai <pillair@codeaurora.org> wrote:
> >
> > Add device node for the ath10k SNOC platform driver probe
> > and add resources required for WCN3990 on sc7180 soc.
> >
> > Signed-off-by: Rakesh Pillai <pillair@codeaurora.org>
>
> What is the status of this? Looks like you have some feedback from
> Sibi. Can you reply and spin this? Also a comment below:
>
> > ---
> > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 5 +++++
> > arch/arm64/boot/dts/qcom/sc7180.dtsi | 27
> +++++++++++++++++++++++++++
> > 2 files changed, 32 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > index 388f50a..167f68ac 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> > @@ -287,6 +287,11 @@
> > vdda-pll-supply = <&vreg_l4a_0p8>;
> > };
> >
> > +&wifi {
> > + status = "okay";
> > + qcom,msa-fixed-perm;
> > +};
> > +
> > /* PINCTRL - additions to nodes defined in sc7180.dtsi */
> >
> > &qspi_clk {
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > index 8011c5f..e3e8610 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> > @@ -75,6 +75,11 @@
> > reg = <0x0 0x80900000 0x0 0x200000>;
> > no-map;
> > };
> > +
> > + wlan_fw_mem: memory@93900000 {
> > + reg = <0 0x93900000 0 0x200000>;
> > + no-map;
> > + };
> > };
> >
> > cpus {
> > @@ -1490,6 +1495,28 @@
> >
> > #freq-domain-cells = <1>;
> > };
> > +
> > + wifi: wifi@18800000 {
> > + compatible = "qcom,wcn3990-wifi";
> > + reg = <0 0x18800000 0 0x800000>;
> > + reg-names = "membase";
> > + iommus = <&apps_smmu 0xc0 0x1>;
> > + interrupts =
> > + <GIC_SPI 414 IRQ_TYPE_LEVEL_HIGH /* CE0 */ >,
> > + <GIC_SPI 415 IRQ_TYPE_LEVEL_HIGH /* CE1 */ >,
> > + <GIC_SPI 416 IRQ_TYPE_LEVEL_HIGH /* CE2 */ >,
> > + <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH /* CE3 */ >,
> > + <GIC_SPI 418 IRQ_TYPE_LEVEL_HIGH /* CE4 */ >,
> > + <GIC_SPI 419 IRQ_TYPE_LEVEL_HIGH /* CE5 */ >,
> > + <GIC_SPI 420 IRQ_TYPE_LEVEL_HIGH /* CE6 */ >,
> > + <GIC_SPI 421 IRQ_TYPE_LEVEL_HIGH /* CE7 */ >,
> > + <GIC_SPI 422 IRQ_TYPE_LEVEL_HIGH /* CE8 */ >,
> > + <GIC_SPI 423 IRQ_TYPE_LEVEL_HIGH /* CE9 */ >,
> > + <GIC_SPI 424 IRQ_TYPE_LEVEL_HIGH /* CE10 */>,
> > + <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH /* CE11 */>;
> > + memory-region = <&wlan_fw_mem>;
>
> The clocks are missing:
>
> clocks = <&rpmhcc RPMH_RF_CLK2>;
> clock-names = "cxo_ref_clk_pin";
>
> > + status = "disabled";
> > + };
> > };
> >
> > thermal-zones {
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
2020-03-25 11:04 ` pillair
@ 2020-03-25 16:03 ` Evan Green
2020-03-26 11:23 ` pillair
0 siblings, 1 reply; 6+ messages in thread
From: Evan Green @ 2020-03-25 16:03 UTC (permalink / raw)
To: pillair
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-arm Mailing List, LKML, linux-arm-msm
On Wed, Mar 25, 2020 at 4:05 AM <pillair@codeaurora.org> wrote:
>
> Hi Evan,
>
> I will send out a v7 for this patchset.
> Since I have to configure the S2 SIDs, it is dependent on below ath10k patchset.
> https://patchwork.kernel.org/project/linux-wireless/list/?series=261367
Ah, right. Thanks for the info, I'll check out that series as well.
-Evan
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node
2020-03-25 16:03 ` Evan Green
@ 2020-03-26 11:23 ` pillair
0 siblings, 0 replies; 6+ messages in thread
From: pillair @ 2020-03-26 11:23 UTC (permalink / raw)
To: 'Evan Green'
Cc: 'open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE
BINDINGS', 'linux-arm Mailing List', 'LKML',
'linux-arm-msm'
Hi Evan,
I have sent out the v7 patch by marking a dependency on the below mentioned series
https://patchwork.kernel.org/project/linux-wireless/list/?series=261367
> The clocks are missing:
> clocks = <&rpmhcc RPMH_RF_CLK2>;
> clock-names = "cxo_ref_clk_pin";
These clocks are optional and were required for older firmware.
It's not needed now.
Thanks,
Rakesh Pillai
> -----Original Message-----
> From: Evan Green <evgreen@chromium.org>
> Sent: Wednesday, March 25, 2020 9:34 PM
> To: pillair@codeaurora.org
> Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicetree@vger.kernel.org>; linux-arm Mailing List <linux-arm-
> kernel@lists.infradead.org>; LKML <linux-kernel@vger.kernel.org>; linux-
> arm-msm <linux-arm-msm@vger.kernel.org>
> Subject: Re: [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN
> module device node
>
> On Wed, Mar 25, 2020 at 4:05 AM <pillair@codeaurora.org> wrote:
> >
> > Hi Evan,
> >
> > I will send out a v7 for this patchset.
> > Since I have to configure the S2 SIDs, it is dependent on below ath10k
> patchset.
> > https://patchwork.kernel.org/project/linux-wireless/list/?series=261367
>
> Ah, right. Thanks for the info, I'll check out that series as well.
> -Evan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-26 11:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-04 13:18 [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node Rakesh Pillai
2020-02-07 6:41 ` Sibi Sankar
2020-03-24 17:39 ` Evan Green
2020-03-25 11:04 ` pillair
2020-03-25 16:03 ` Evan Green
2020-03-26 11:23 ` pillair
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).