Re: Re : Query on UFS Lun detection

From: Rob Clark <robdclark@gmail.com>
To: vhiren@codeaurora.com
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	adrian.hunter@intel.com, Rob Herring <robh+dt@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Asutosh Das <asutoshd@codeaurora.org>,
	stummala@codeaurora.org, sayalil@codeaurora.org,
	rampraka@codeaurora.org, vbadigan@codeaurora.org,
	Stephen Boyd <sboyd@kernel.org>,
	Georgi Djakov <georgi.djakov@linaro.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	linux-mmc@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, Andy Gross <agross@kernel.org>,
	linux-mmc-owner@vger.kernel.org, nitirawa@codeaurora.org
Subject: Re: Re : Query on UFS Lun detection
Date: Thu, 10 Jun 2021 07:51:58 -0700	[thread overview]
Message-ID: <CAF6AEGui16Q9uDrkXNuDsi0Do-ZNDJa9aQGWhqG_tjV7O2DReg@mail.gmail.com> (raw)
In-Reply-To: <d60373362ed41b49f763cdb46c9973e2@codeaurora.com>

On Thu, Jun 10, 2021 at 6:28 AM <vhiren@codeaurora.com> wrote:
>
> Hi Community,
>
> We are using UFS as a boot device, and we encountered an error,
> mentioned below while booting through UFS.
>
>
> APPS Crash - Kernel panic - not syncing: VFS: Unable to mount root fs on
> unknown-block(8,7)
>
> Here in Kernel command line we are passing "root=sda7", this is our
> Filesystem partition to be mounted.
>
> While debugging the same we observed the partition which is suppose to
> be mounted as Filesystem is not enumerated  itself.
> The reason behind not enumerating of partition is, the other Lun got
> detected first instead of one which is having FS partition.

Use the UUID or PARTUUID instead, ie:

  root=UUID=13846802-672b-4a5d-9f0a-22d13957add3

(but you'd have to check the actual UUID of your partition with a tool
like blkid

BR,
-R

> We are using async probe, hence we know the detection will happen in
> async way,
>
>
> In working case :  it looks like below
>
> sd 0:0:0:0: sda1 sda2 sda3 sda4 …..sda8
>
> sd 0:0:0:1: sdb1 sdb2
> Here, sd 0:0:0:0 Lun got detected first and enumerated as "sdaN", we
> have FS partition as "sda7" and so we don’t see above mentioned error.
>
>
> In non working case : it looks like below
>
> sd 0:0:0:0: sdb1 sdb2 sdb3 sdb4 …..sdb8
>
> sd 0:0:0:1: sda1 sda2
> Here, sd 0:0:0:1 Lun got detected first and enumerated as "sdaN" but we
> don’t have FS partition in this Lun. Instead FS partition now became
> "sdb7".
>
>
> Observation here is, which ever Lun gets detected first it will have
> "sda" enumeration and so on.
> However, sdx’s driver scsi/sd.c uses async probe to improve performance,
> meaning sdx disks are created in parallel. Whoever calls
> device_add_disk() first becomes sda, the next become sdb….
>
>
> Is there any way, where we can fix this in the Lun detection part of
> code?
>
> Thank You,
> Regards,
> Hiren Gohel