From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73FECC76190 for ; Mon, 22 Jul 2019 15:41:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4C99A2190F for ; Mon, 22 Jul 2019 15:41:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oq1L146U" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726851AbfGVPlr (ORCPT ); Mon, 22 Jul 2019 11:41:47 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:46209 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725890AbfGVPlr (ORCPT ); Mon, 22 Jul 2019 11:41:47 -0400 Received: by mail-ed1-f65.google.com with SMTP id d4so41059226edr.13; Mon, 22 Jul 2019 08:41:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gbhi3M6mI+4oCuQkiXeYBwKqa8lehAmY1ApNgOUqhwo=; b=oq1L146UMTM5yp1F87M46OMRVNjVPxNYCqBgriKVv6dMDXX08s6uRiySQkE09kcK1A Ra2YvaKODVmITKUqtD7D1ZZBRTfaE2EIyiEpJokB2G8dfoqP1hIzdCqNe2owW2cN7JpK /zkAUcT1M6a8ckcpVXXe7ckudGM6GLl5YeRMMzlKGUi8Cgv8GgmvLGEpveZ4wCxnc3C4 GLJFTrJWuI6GKBiuXFR8rfOXC8m6Lg7NcV5ejYFsiYQ+u0UPXpfbJ566t2UX28hlymTM STU8X04EdUcw3iu9gaHq2Zbbe4WfrqN3U1tyLEkqb89i0xg7+i4TO2G0kFl8exgLi//U 0Dvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gbhi3M6mI+4oCuQkiXeYBwKqa8lehAmY1ApNgOUqhwo=; b=Yc7j6P8YglB/ovLHphmCVwKpZdsjQKgN3P+ivbpS9g/tcBa8D+9fHsORaiW/bbuN/H QEN+nEHbVTJLrULMImPIOxc8dQWWuqIGmvZdnZmNRrPHX8YZ3CSWCHVDpz6mGCzVpMue 1//W5KQiPGbZtNexAf1OD+kZYht1DpobyUImeM/rfoOcgLSSjCTZf3/F232S9NiTUw1+ xoUGY1BAR5z350uBDa1pgLOE0YIbS1/tEDKeVCu17VuUkdHhQhGFelCuuyA1xy0F1zWN 4ltV5xUS3U6ZyQzecDGOq8fkHmgBEX7XQIoUDTSeSOzPPbFsc4aW+GAWVFTx8rEaTSxq aofg== X-Gm-Message-State: APjAAAXKmsEVB++I2lTGRdfpVIbXhQDPrkCdQqL74aYE5CZD/hNOKxxX ZzDbbMH+VI7vGujK2oqUyZhNgHlfrMtMXtTqfPQ= X-Google-Smtp-Source: APXvYqxAGVaQMLs79f0ezsPQ6fjGuLy15ZNhz+Hy27pbz3hAzVegkYLJIcY3Cz+18kjo6Re9A52+O183SrZvHqwPE8o= X-Received: by 2002:a50:8bfd:: with SMTP id n58mr60475682edn.272.1563810105719; Mon, 22 Jul 2019 08:41:45 -0700 (PDT) MIME-Version: 1.0 References: <20190702202631.32148-2-robdclark@gmail.com> <20190710182844.25032-1-robdclark@gmail.com> <20190722142833.GB12009@8bytes.org> In-Reply-To: <20190722142833.GB12009@8bytes.org> From: Rob Clark Date: Mon, 22 Jul 2019 08:41:34 -0700 Message-ID: Subject: Re: [PATCH v2] iommu: add support for drivers that manage iommu explicitly To: Joerg Roedel Cc: "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , linux-arm-msm , aarch64-laptops@lists.linaro.org, Rob Clark , Will Deacon , Robin Murphy , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rasmus Villemoes , Andy Shevchenko , Andrew Morton , Heikki Krogerus , Bartosz Golaszewski , Sudeep Holla , Joe Perches , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Jul 22, 2019 at 7:28 AM Joerg Roedel wrote: > > On Wed, Jul 10, 2019 at 11:28:30AM -0700, Rob Clark wrote: > > --- a/include/linux/device.h > > +++ b/include/linux/device.h > > @@ -282,7 +282,8 @@ struct device_driver { > > struct module *owner; > > const char *mod_name; /* used for built-in modules */ > > > > - bool suppress_bind_attrs; /* disables bind/unbind via sysfs */ > > + bool suppress_bind_attrs:1; /* disables bind/unbind via sysfs */ > > + bool driver_manages_iommu:1; /* driver manages IOMMU explicitly */ > > Who will set this bit? > It is set by the driver: https://patchwork.freedesktop.org/patch/315291/ (This doesn't really belong in devicetree, since it isn't a description of the hardware, so the driver is really the only place to set this.. which is fine because it is about a detail of how the driver works.) BR, -R