From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F75CC4338F for ; Wed, 11 Aug 2021 09:42:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D75760FC0 for ; Wed, 11 Aug 2021 09:42:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236680AbhHKJmX (ORCPT ); Wed, 11 Aug 2021 05:42:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236668AbhHKJmX (ORCPT ); Wed, 11 Aug 2021 05:42:23 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DA06C061765 for ; Wed, 11 Aug 2021 02:42:00 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id hv22-20020a17090ae416b0290178c579e424so3776943pjb.3 for ; Wed, 11 Aug 2021 02:42:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ET1+ZjzComT36ndSZVUKzhjE6lLi2eturMaqxLGm5O8=; b=ePOqM1Pw/3iTBXH81cLS6rrfbNInK4idxR4KGzIJxEFexp0L9Fu4L0Hjqha1giq9j5 iF+ZxqxJv6mlVr8uZOFQiWimlcClZ2ojE7Ya9lQ5Aa1MzrqCAzdnrtkUMmJKQfK0YQrq F92rMiB2PKCmYomVyVotPwnUxumq59SldIvA4nXWI0oVxfRDk1WjuEGiNvv5DScTgjPw jt4ryfojp55ZSYKI/C9m4LslwkaHBhr/S/GrX3Qi81V3/kJ+Vt8lws73SDzo7ZsnxYuV KZrUE72+p8qM4yyVeb3UQptDzU1ITUxaaHfdWNt16bdBQNFmGMLQ7/fbkPp/ceu6nj7h KzEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ET1+ZjzComT36ndSZVUKzhjE6lLi2eturMaqxLGm5O8=; b=e4YtmWXhx01QYdYWgwdUmB9/UofNpdlQJtBPGHogIuky7kAn6WSQL05Js9vEtYv6b6 yKfnW9hokJYU4RbeImTDqLTOOZwgrNYYwb/x2VWxtBHbmJvW5jpx/z9MZhu3Fk5r/OYn w9Ya7XDyJwJgcwoyjBb/MFj3GFm3tGmnKSaZiqseEn38avZZtdPPXi7YBM+ifmmCm8Nc wKgU1aS3kF+BsIm/wlcUjT7LmuzajQAUZELSDudGhfUqThrbZEAynb9md5JVatUwTr8R 0DdqSW9mrFNKgX28bVVDHALXGW4obWYUUCIPVLB69G86IS12i3YzzlQGB+dd4TxlXamM KFMA== X-Gm-Message-State: AOAM530ingo15KVS8JjQIo8jTGz+tp0LUFqg7Qew14s5Z+18qXU+z8wm IzDyFYksbLjzDRmk3wLoeicVx+X1JNCzrjb4TAuZFQ== X-Google-Smtp-Source: ABdhPJxYgVxxqbLY47gEt/zvPvdFQD/c+j2VIRTiXnc9r1HKIEXV3Jite9T1g1lAykdBzTwD9KpUlN6GismQCJ/lQn4= X-Received: by 2002:a63:f754:: with SMTP id f20mr99905pgk.385.1628674919479; Wed, 11 Aug 2021 02:41:59 -0700 (PDT) MIME-Version: 1.0 References: <20210810103336.114077-1-robert.foss@linaro.org> <0b694e24-5cc8-4944-d3a2-115306ae7b89@samsung.com> In-Reply-To: <0b694e24-5cc8-4944-d3a2-115306ae7b89@samsung.com> From: Robert Foss Date: Wed, 11 Aug 2021 11:41:48 +0200 Message-ID: Subject: Re: [PATCH v1] media: camss: vfe: Don't use vfe->base before it's assigned To: Marek Szyprowski Cc: Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Hans Verkuil , linux-media , MSM , linux-kernel , Naresh Kamboju , Hans Verkuil , Linux Kernel Functional Testing Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hey Marek, Thanks for testing this. On Wed, 11 Aug 2021 at 09:48, Marek Szyprowski wrote: > > On 10.08.2021 12:33, Robert Foss wrote: > > vfe->ops->hw_version(vfe) being called before vfe->base has been assigned > > is incorrect and causes crashes. > > > > Fixes: b10b5334528a9 ("media: camss: vfe: Don't read hardware version needlessly") > > > > Reported-by: Linux Kernel Functional Testing > > Signed-off-by: Robert Foss > > With this patch applied on top of linux next-20210810 instead of the > NULL pointer dereference I get following error on DragonBoard410c while > loading kernel modules: > > [ 18.480608] qcom-venus 1d00000.video-codec: Adding to iommu group 1 > [ 18.536167] qcom-camss 1b0ac00.camss: Adding to iommu group 2 > [ 18.600373] Internal error: synchronous external abort: 96000010 [#1] > PREEMPT SMP I'll spin a v2 asap.